* [PATCH v2] fs/dcache: fix typos and sentence disorder
@ 2021-03-23 6:52 Xiaofeng Cao
2021-03-23 17:42 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Xiaofeng Cao @ 2021-03-23 6:52 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, Xiaofeng Cao
change 'sould' to 'should'
change 'colocated' to 'co-located'
change 'talke' to 'take'
reorganize sentence
Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>
---
v2:change 'colocated' to 'co-located' instead of 'collocated'
fs/dcache.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 7d24ff7eb206..c23834334314 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -741,7 +741,7 @@ static inline bool fast_dput(struct dentry *dentry)
unsigned int d_flags;
/*
- * If we have a d_op->d_delete() operation, we sould not
+ * If we have a d_op->d_delete() operation, we should not
* let the dentry count go to zero, so use "put_or_lock".
*/
if (unlikely(dentry->d_flags & DCACHE_OP_DELETE))
@@ -1053,7 +1053,7 @@ struct dentry *d_find_alias_rcu(struct inode *inode)
struct dentry *de = NULL;
spin_lock(&inode->i_lock);
- // ->i_dentry and ->i_rcu are colocated, but the latter won't be
+ // ->i_dentry and ->i_rcu are co-located, but the latter won't be
// used without having I_FREEING set, which means no aliases left
if (likely(!(inode->i_state & I_FREEING) && !hlist_empty(l))) {
if (S_ISDIR(inode->i_mode)) {
@@ -1297,7 +1297,7 @@ void shrink_dcache_sb(struct super_block *sb)
EXPORT_SYMBOL(shrink_dcache_sb);
/**
- * enum d_walk_ret - action to talke during tree walk
+ * enum d_walk_ret - action to take during tree walk
* @D_WALK_CONTINUE: contrinue walk
* @D_WALK_QUIT: quit walk
* @D_WALK_NORETRY: quit when retry is needed
@@ -2156,8 +2156,8 @@ EXPORT_SYMBOL(d_obtain_alias);
*
* On successful return, the reference to the inode has been transferred
* to the dentry. In case of an error the reference on the inode is
- * released. A %NULL or IS_ERR inode may be passed in and will be the
- * error will be propagate to the return value, with a %NULL @inode
+ * released. A %NULL or IS_ERR inode may be passed in and the error will
+ * be propagated to the return value, with a %NULL @inode
* replaced by ERR_PTR(-ESTALE).
*/
struct dentry *d_obtain_root(struct inode *inode)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] fs/dcache: fix typos and sentence disorder
2021-03-23 6:52 [PATCH v2] fs/dcache: fix typos and sentence disorder Xiaofeng Cao
@ 2021-03-23 17:42 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-03-23 17:42 UTC (permalink / raw)
To: Xiaofeng Cao, viro; +Cc: linux-fsdevel, linux-kernel, Xiaofeng Cao
On 3/22/21 11:52 PM, Xiaofeng Cao wrote:
> change 'sould' to 'should'
> change 'colocated' to 'co-located'
> change 'talke' to 'take'
> reorganize sentence
>
> Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> v2:change 'colocated' to 'co-located' instead of 'collocated'
> fs/dcache.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/dcache.c b/fs/dcache.c
> index 7d24ff7eb206..c23834334314 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -741,7 +741,7 @@ static inline bool fast_dput(struct dentry *dentry)
> unsigned int d_flags;
>
> /*
> - * If we have a d_op->d_delete() operation, we sould not
> + * If we have a d_op->d_delete() operation, we should not
> * let the dentry count go to zero, so use "put_or_lock".
> */
> if (unlikely(dentry->d_flags & DCACHE_OP_DELETE))
> @@ -1053,7 +1053,7 @@ struct dentry *d_find_alias_rcu(struct inode *inode)
> struct dentry *de = NULL;
>
> spin_lock(&inode->i_lock);
> - // ->i_dentry and ->i_rcu are colocated, but the latter won't be
> + // ->i_dentry and ->i_rcu are co-located, but the latter won't be
> // used without having I_FREEING set, which means no aliases left
> if (likely(!(inode->i_state & I_FREEING) && !hlist_empty(l))) {
> if (S_ISDIR(inode->i_mode)) {
> @@ -1297,7 +1297,7 @@ void shrink_dcache_sb(struct super_block *sb)
> EXPORT_SYMBOL(shrink_dcache_sb);
>
> /**
> - * enum d_walk_ret - action to talke during tree walk
> + * enum d_walk_ret - action to take during tree walk
> * @D_WALK_CONTINUE: contrinue walk
> * @D_WALK_QUIT: quit walk
> * @D_WALK_NORETRY: quit when retry is needed
> @@ -2156,8 +2156,8 @@ EXPORT_SYMBOL(d_obtain_alias);
> *
> * On successful return, the reference to the inode has been transferred
> * to the dentry. In case of an error the reference on the inode is
> - * released. A %NULL or IS_ERR inode may be passed in and will be the
> - * error will be propagate to the return value, with a %NULL @inode
> + * released. A %NULL or IS_ERR inode may be passed in and the error will
> + * be propagated to the return value, with a %NULL @inode
> * replaced by ERR_PTR(-ESTALE).
> */
> struct dentry *d_obtain_root(struct inode *inode)
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 6:52 [PATCH v2] fs/dcache: fix typos and sentence disorder Xiaofeng Cao
2021-03-23 17:42 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.