All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
	mike.leach@linaro.org, alexander.shishkin@linux.intel.com,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword
Date: Tue, 23 Mar 2021 15:19:44 +0800	[thread overview]
Message-ID: <20210323071944.GA55918@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20210323075452.38920-1-zou_wei@huawei.com>

On Tue, Mar 23, 2021 at 07:54:52AM +0000, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 0f603b4094f2..bdbb77334329 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
>  	return sprintf(page, "config:%d\n", pid_fmt);
>  }
>  
> -struct device_attribute format_attr_contextid =
> +static struct device_attribute format_attr_contextid =
>  	__ATTR(contextid, 0444, format_attr_contextid_show, NULL);
>  
>  static struct attribute *etm_config_formats_attr[] = {
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
	mike.leach@linaro.org, alexander.shishkin@linux.intel.com,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword
Date: Tue, 23 Mar 2021 15:19:44 +0800	[thread overview]
Message-ID: <20210323071944.GA55918@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20210323075452.38920-1-zou_wei@huawei.com>

On Tue, Mar 23, 2021 at 07:54:52AM +0000, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 0f603b4094f2..bdbb77334329 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
>  	return sprintf(page, "config:%d\n", pid_fmt);
>  }
>  
> -struct device_attribute format_attr_contextid =
> +static struct device_attribute format_attr_contextid =
>  	__ATTR(contextid, 0444, format_attr_contextid_show, NULL);
>  
>  static struct attribute *etm_config_formats_attr[] = {
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-23  7:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  7:54 [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword Zou Wei
2021-03-23  7:54 ` Zou Wei
2021-03-23  7:19 ` Leo Yan [this message]
2021-03-23  7:19   ` Leo Yan
2021-03-23  9:47 ` Suzuki K Poulose
2021-03-23  9:47   ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323071944.GA55918@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.