All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] crypto: hisilicon/hpre: fix link error
@ 2021-03-23  7:27 Yang Yingliang
  2021-03-23  7:41 ` tanghui20
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-03-23  7:27 UTC (permalink / raw)
  To: linux-crypto, linux-kernel; +Cc: xuzaibo, herbert, davem

Fix the follow link error by select config CRYPTO_ECC and CRYPTO_ECDH.

ERROR: modpost: "ecc_get_curve25519" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined!
ERROR: modpost: "ecc_get_curve" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined!
ERROR: modpost: "crypto_ecdh_decode_key" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined!

Fixes: 90274769cf79 ("crypto: hisilicon/hpre - add 'CURVE25519' algorithm")
Fixes: 05e7b906aa7c ("crypto: hisilicon/hpre - add 'ECDH' algorithm")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/crypto/hisilicon/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index c45adb15ce8d..d87c89af2a7f 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -69,6 +69,8 @@ config CRYPTO_DEV_HISI_HPRE
 	select CRYPTO_DEV_HISI_QM
 	select CRYPTO_DH
 	select CRYPTO_RSA
+	select CRYPTO_ECC
+	select CRYPTO_ECDH
 	help
 	  Support for HiSilicon HPRE(High Performance RSA Engine)
 	  accelerator, which can accelerate RSA and DH algorithms.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] crypto: hisilicon/hpre: fix link error
  2021-03-23  7:27 [PATCH -next] crypto: hisilicon/hpre: fix link error Yang Yingliang
@ 2021-03-23  7:41 ` tanghui20
  0 siblings, 0 replies; 2+ messages in thread
From: tanghui20 @ 2021-03-23  7:41 UTC (permalink / raw)
  To: Yang Yingliang, linux-crypto, linux-kernel; +Cc: xuzaibo, herbert, davem

There is a patch similar to yours that was send in advance, as follows:
https://www.spinics.net/lists/linux-crypto/msg54238.html

On 2021/3/23 15:27, Yang Yingliang wrote:
> Fix the follow link error by select config CRYPTO_ECC and CRYPTO_ECDH.
>
> ERROR: modpost: "ecc_get_curve25519" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined!
> ERROR: modpost: "ecc_get_curve" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined!
> ERROR: modpost: "crypto_ecdh_decode_key" [drivers/crypto/hisilicon/hpre/hisi_hpre.ko] undefined!
>
> Fixes: 90274769cf79 ("crypto: hisilicon/hpre - add 'CURVE25519' algorithm")
> Fixes: 05e7b906aa7c ("crypto: hisilicon/hpre - add 'ECDH' algorithm")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/crypto/hisilicon/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index c45adb15ce8d..d87c89af2a7f 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -69,6 +69,8 @@ config CRYPTO_DEV_HISI_HPRE
>  	select CRYPTO_DEV_HISI_QM
>  	select CRYPTO_DH
>  	select CRYPTO_RSA
> +	select CRYPTO_ECC
> +	select CRYPTO_ECDH
>  	help
>  	  Support for HiSilicon HPRE(High Performance RSA Engine)
>  	  accelerator, which can accelerate RSA and DH algorithms.
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-23  7:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23  7:27 [PATCH -next] crypto: hisilicon/hpre: fix link error Yang Yingliang
2021-03-23  7:41 ` tanghui20

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.