[PATCH v2] fs/exec: fix typos and sentence disorder

[PATCH v2] fs/exec: fix typos and sentence disorder

[Xiaofeng Cao]

change 'backwords' to 'backwards'
change 'and argument' to 'an argument'
change 'visibile' to 'visible'
change 'wont't' to 'won't'
reorganize sentence

Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>
---
v2: resume the right boundary
 fs/exec.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/fs/exec.c b/fs/exec.c
index 18594f11c31f..5e23101f9259 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -536,7 +536,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
 		if (!valid_arg_len(bprm, len))
 			goto out;
 
-		/* We're going to work our way backwords. */
+		/* We're going to work our way backwards. */
 		pos = bprm->p;
 		str += len;
 		bprm->p -= len;
@@ -603,7 +603,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
 }
 
 /*
- * Copy and argument/environment string from the kernel to the processes stack.
+ * Copy an argument/environment string from the kernel to the processes stack.
  */
 int copy_string_kernel(const char *arg, struct linux_binprm *bprm)
 {
@@ -718,9 +718,9 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift)
 	} else {
 		/*
 		 * otherwise, clean from old_start; this is done to not touch
-		 * the address space in [new_end, old_start) some architectures
+		 * the address space in [new_end, old_start). Some architectures
 		 * have constraints on va-space that make this illegal (IA64) -
-		 * for the others its just a little faster.
+		 * for the others it's just a little faster.
 		 */
 		free_pgd_range(&tlb, old_start, old_end, new_end,
 			vma->vm_next ? vma->vm_next->vm_start : USER_PGTABLES_CEILING);
@@ -1120,7 +1120,7 @@ static int de_thread(struct task_struct *tsk)
 		 */
 
 		/* Become a process group leader with the old leader's pid.
-		 * The old leader becomes a thread of the this thread group.
+		 * The old leader becomes a thread of this thread group.
 		 */
 		exchange_tids(tsk, leader);
 		transfer_pid(leader, tsk, PIDTYPE_TGID);
@@ -1142,7 +1142,7 @@ static int de_thread(struct task_struct *tsk)
 		/*
 		 * We are going to release_task()->ptrace_unlink() silently,
 		 * the tracer can sleep in do_wait(). EXIT_DEAD guarantees
-		 * the tracer wont't block again waiting for this thread.
+		 * the tracer won't block again waiting for this thread.
 		 */
 		if (unlikely(leader->ptrace))
 			__wake_up_parent(leader, leader->parent);
@@ -1270,7 +1270,7 @@ int begin_new_exec(struct linux_binprm * bprm)
 
 	/*
 	 * Must be called _before_ exec_mmap() as bprm->mm is
-	 * not visibile until then. This also enables the update
+	 * not visible until then. This also enables the update
 	 * to be lockless.
 	 */
 	set_mm_exe_file(bprm->mm, bprm->file);
-- 
2.25.1

Re: [PATCH v2] fs/exec: fix typos and sentence disorder

[Randy Dunlap]

On 3/23/21 12:42 AM, Xiaofeng Cao wrote:
> change 'backwords' to 'backwards'
> change 'and argument' to 'an argument'
> change 'visibile' to 'visible'
> change 'wont't' to 'won't'
> reorganize sentence
> 
> Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> v2: resume the right boundary
>  fs/exec.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index 18594f11c31f..5e23101f9259 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -536,7 +536,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
>  		if (!valid_arg_len(bprm, len))
>  			goto out;
>  
> -		/* We're going to work our way backwords. */
> +		/* We're going to work our way backwards. */
>  		pos = bprm->p;
>  		str += len;
>  		bprm->p -= len;
> @@ -603,7 +603,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
>  }
>  
>  /*
> - * Copy and argument/environment string from the kernel to the processes stack.
> + * Copy an argument/environment string from the kernel to the processes stack.
>   */
>  int copy_string_kernel(const char *arg, struct linux_binprm *bprm)
>  {
> @@ -718,9 +718,9 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift)
>  	} else {
>  		/*
>  		 * otherwise, clean from old_start; this is done to not touch
> -		 * the address space in [new_end, old_start) some architectures
> +		 * the address space in [new_end, old_start). Some architectures
>  		 * have constraints on va-space that make this illegal (IA64) -
> -		 * for the others its just a little faster.
> +		 * for the others it's just a little faster.
>  		 */
>  		free_pgd_range(&tlb, old_start, old_end, new_end,
>  			vma->vm_next ? vma->vm_next->vm_start : USER_PGTABLES_CEILING);
> @@ -1120,7 +1120,7 @@ static int de_thread(struct task_struct *tsk)
>  		 */
>  
>  		/* Become a process group leader with the old leader's pid.
> -		 * The old leader becomes a thread of the this thread group.
> +		 * The old leader becomes a thread of this thread group.
>  		 */
>  		exchange_tids(tsk, leader);
>  		transfer_pid(leader, tsk, PIDTYPE_TGID);
> @@ -1142,7 +1142,7 @@ static int de_thread(struct task_struct *tsk)
>  		/*
>  		 * We are going to release_task()->ptrace_unlink() silently,
>  		 * the tracer can sleep in do_wait(). EXIT_DEAD guarantees
> -		 * the tracer wont't block again waiting for this thread.
> +		 * the tracer won't block again waiting for this thread.
>  		 */
>  		if (unlikely(leader->ptrace))
>  			__wake_up_parent(leader, leader->parent);
> @@ -1270,7 +1270,7 @@ int begin_new_exec(struct linux_binprm * bprm)
>  
>  	/*
>  	 * Must be called _before_ exec_mmap() as bprm->mm is
> -	 * not visibile until then. This also enables the update
> +	 * not visible until then. This also enables the update
>  	 * to be lockless.
>  	 */
>  	set_mm_exe_file(bprm->mm, bprm->file);
> 


-- 
~Randy