* [PATCH] crash_dump: Fix duplicate included pgtable.h
@ 2021-03-19 12:03 Tian Tao
2021-03-19 12:36 ` Baoquan He
2021-03-23 7:48 ` Baoquan He
0 siblings, 2 replies; 3+ messages in thread
From: Tian Tao @ 2021-03-19 12:03 UTC (permalink / raw)
To: dyoung, bhe; +Cc: kexec
linux/pgtable.h is included more than once, Remove the one that isn't
necessary.
Fixes: ca5999fde0a1 ("mm: introduce include/linux/pgtable.h")
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
include/linux/crash_dump.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index a5192b7..6bd8a33 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,8 +8,6 @@
#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>
-#include <linux/pgtable.h> /* for pgprot_t */
-
#ifdef CONFIG_CRASH_DUMP
#define ELFCORE_ADDR_MAX (-1ULL)
#define ELFCORE_ADDR_ERR (-2ULL)
--
2.7.4
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crash_dump: Fix duplicate included pgtable.h
2021-03-19 12:03 [PATCH] crash_dump: Fix duplicate included pgtable.h Tian Tao
@ 2021-03-19 12:36 ` Baoquan He
2021-03-23 7:48 ` Baoquan He
1 sibling, 0 replies; 3+ messages in thread
From: Baoquan He @ 2021-03-19 12:36 UTC (permalink / raw)
To: Tian Tao; +Cc: dyoung, kexec
On 03/19/21 at 08:03pm, Tian Tao wrote:
> linux/pgtable.h is included more than once, Remove the one that isn't
> necessary.
This trivial clean up has been posted, I would like to ack that one.
You can ack the patch if you have concern.
https://lore.kernel.org/lkml/20210313103521.364854-1-zhang.yunkai@zte.com.cn/
Thanks anyway.
>
> Fixes: ca5999fde0a1 ("mm: introduce include/linux/pgtable.h")
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b7..6bd8a33 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> #ifdef CONFIG_CRASH_DUMP
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.7.4
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crash_dump: Fix duplicate included pgtable.h
2021-03-19 12:03 [PATCH] crash_dump: Fix duplicate included pgtable.h Tian Tao
2021-03-19 12:36 ` Baoquan He
@ 2021-03-23 7:48 ` Baoquan He
1 sibling, 0 replies; 3+ messages in thread
From: Baoquan He @ 2021-03-23 7:48 UTC (permalink / raw)
To: Tian Tao; +Cc: dyoung, kexec, akpm
On 03/19/21 at 08:03pm, Tian Tao wrote:
> linux/pgtable.h is included more than once, Remove the one that isn't
> necessary.
>
> Fixes: ca5999fde0a1 ("mm: introduce include/linux/pgtable.h")
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Thanks, this looks good to me. But the Fixes tag is unnecessary since
this patch is a trivial cleanup, no need to add to stable kernel.
Otherwise,
Acked-by: Baoquan He <bhe@redhat.com>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b7..6bd8a33 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> #ifdef CONFIG_CRASH_DUMP
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.7.4
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-23 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 12:03 [PATCH] crash_dump: Fix duplicate included pgtable.h Tian Tao
2021-03-19 12:36 ` Baoquan He
2021-03-23 7:48 ` Baoquan He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.