From: Lee Jones <lee.jones@linaro.org>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
daniel.thompson@linaro.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence
Date: Tue, 23 Mar 2021 09:40:41 +0000 [thread overview]
Message-ID: <20210323094041.GT2916463@dell> (raw)
In-Reply-To: <1616071180-24493-3-git-send-email-kgunda@codeaurora.org>
On Thu, 18 Mar 2021, Kiran Gunda wrote:
> As per the current implementation, after FSC (Full Scale Current)
> and brightness update the sync bits are set-then-cleared.
> But, the FSC and brightness sync takes place when the sync bits are
> set (e.g. on a rising edge). So the hardware team recommends a
> clear-then-set approach in order to guarantee such a transition
> regardless of the previous register state.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/qcom-wled.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
daniel.thompson@linaro.org, b.zolnierkie@samsung.com,
jingoohan1@gmail.com, Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bjorn.andersson@linaro.org, linux-fbdev@vger.kernel.org,
robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence
Date: Tue, 23 Mar 2021 09:40:41 +0000 [thread overview]
Message-ID: <20210323094041.GT2916463@dell> (raw)
In-Reply-To: <1616071180-24493-3-git-send-email-kgunda@codeaurora.org>
On Thu, 18 Mar 2021, Kiran Gunda wrote:
> As per the current implementation, after FSC (Full Scale Current)
> and brightness update the sync bits are set-then-cleared.
> But, the FSC and brightness sync takes place when the sync bits are
> set (e.g. on a rising edge). So the hardware team recommends a
> clear-then-set approach in order to guarantee such a transition
> regardless of the previous register state.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/qcom-wled.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-23 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:39 [PATCH V5 0/2] Fix WLED FSC Sync and brightness Sync settings Kiran Gunda
2021-03-18 12:39 ` Kiran Gunda
2021-03-18 12:39 ` [PATCH V5 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5 Kiran Gunda
2021-03-18 12:39 ` Kiran Gunda
2021-03-22 17:34 ` Lee Jones
2021-03-22 17:34 ` Lee Jones
2021-03-18 12:39 ` [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence Kiran Gunda
2021-03-18 12:39 ` Kiran Gunda
2021-03-23 9:40 ` Lee Jones [this message]
2021-03-23 9:40 ` Lee Jones
2021-05-26 19:03 ` [PATCH V5 0/2] Fix WLED FSC Sync and brightness Sync settings patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323094041.GT2916463@dell \
--to=lee.jones@linaro.org \
--cc=agross@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.