All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: drivers/opp/of.c:959:12: warning: stack frame size of 1056 bytes in function '_of_add_table_indexed'
Date: Tue, 23 Mar 2021 15:23:24 +0800	[thread overview]
Message-ID: <202103231522.N0bCxZ97-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2838 bytes --]

Hi Viresh,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   84196390620ac0e5070ae36af84c137c6216a7dc
commit: 406e47652161d4f0d9bc4cd6237b36c51497ec75 opp: Create _of_add_table_indexed() to reduce code duplication
date:   7 weeks ago
config: powerpc64-randconfig-r023-20210323 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 14696baaf4c43fe53f738bc292bbe169eed93d5d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=406e47652161d4f0d9bc4cd6237b36c51497ec75
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 406e47652161d4f0d9bc4cd6237b36c51497ec75
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/opp/of.c:959:12: warning: stack frame size of 1056 bytes in function '_of_add_table_indexed' [-Wframe-larger-than=]
   static int _of_add_table_indexed(struct device *dev, int index)
              ^
   1 warning generated.


vim +/_of_add_table_indexed +959 drivers/opp/of.c

   958	
 > 959	static int _of_add_table_indexed(struct device *dev, int index)
   960	{
   961		struct opp_table *opp_table;
   962		int ret, count;
   963	
   964		if (index) {
   965			/*
   966			 * If only one phandle is present, then the same OPP table
   967			 * applies for all index requests.
   968			 */
   969			count = of_count_phandle_with_args(dev->of_node,
   970							   "operating-points-v2", NULL);
   971			if (count == 1)
   972				index = 0;
   973		}
   974	
   975		opp_table = _add_opp_table_indexed(dev, index);
   976		if (IS_ERR(opp_table))
   977			return PTR_ERR(opp_table);
   978	
   979		/*
   980		 * OPPs have two version of bindings now. Also try the old (v1)
   981		 * bindings for backward compatibility with older dtbs.
   982		 */
   983		if (opp_table->np)
   984			ret = _of_add_opp_table_v2(dev, opp_table);
   985		else
   986			ret = _of_add_opp_table_v1(dev, opp_table);
   987	
   988		if (ret)
   989			dev_pm_opp_put_opp_table(opp_table);
   990	
   991		return ret;
   992	}
   993	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33974 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/opp/of.c:959:12: warning: stack frame size of 1056 bytes in function '_of_add_table_indexed'
Date: Tue, 23 Mar 2021 15:23:24 +0800	[thread overview]
Message-ID: <202103231522.N0bCxZ97-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2915 bytes --]

Hi Viresh,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   84196390620ac0e5070ae36af84c137c6216a7dc
commit: 406e47652161d4f0d9bc4cd6237b36c51497ec75 opp: Create _of_add_table_indexed() to reduce code duplication
date:   7 weeks ago
config: powerpc64-randconfig-r023-20210323 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 14696baaf4c43fe53f738bc292bbe169eed93d5d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=406e47652161d4f0d9bc4cd6237b36c51497ec75
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 406e47652161d4f0d9bc4cd6237b36c51497ec75
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/opp/of.c:959:12: warning: stack frame size of 1056 bytes in function '_of_add_table_indexed' [-Wframe-larger-than=]
   static int _of_add_table_indexed(struct device *dev, int index)
              ^
   1 warning generated.


vim +/_of_add_table_indexed +959 drivers/opp/of.c

   958	
 > 959	static int _of_add_table_indexed(struct device *dev, int index)
   960	{
   961		struct opp_table *opp_table;
   962		int ret, count;
   963	
   964		if (index) {
   965			/*
   966			 * If only one phandle is present, then the same OPP table
   967			 * applies for all index requests.
   968			 */
   969			count = of_count_phandle_with_args(dev->of_node,
   970							   "operating-points-v2", NULL);
   971			if (count == 1)
   972				index = 0;
   973		}
   974	
   975		opp_table = _add_opp_table_indexed(dev, index);
   976		if (IS_ERR(opp_table))
   977			return PTR_ERR(opp_table);
   978	
   979		/*
   980		 * OPPs have two version of bindings now. Also try the old (v1)
   981		 * bindings for backward compatibility with older dtbs.
   982		 */
   983		if (opp_table->np)
   984			ret = _of_add_opp_table_v2(dev, opp_table);
   985		else
   986			ret = _of_add_opp_table_v1(dev, opp_table);
   987	
   988		if (ret)
   989			dev_pm_opp_put_opp_table(opp_table);
   990	
   991		return ret;
   992	}
   993	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33974 bytes --]

             reply	other threads:[~2021-03-23  7:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  7:23 kernel test robot [this message]
2021-03-23  7:23 ` drivers/opp/of.c:959:12: warning: stack frame size of 1056 bytes in function '_of_add_table_indexed' kernel test robot
2021-03-23  7:25 ` Viresh Kumar
2021-03-23  7:25   ` Viresh Kumar
2021-03-23  9:39   ` Rong Chen
2021-03-23  9:39     ` Rong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202103231522.N0bCxZ97-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.