All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	ashok.raj@intel.com, kevin.tian@intel.com,
	jacob.jun.pan@intel.com, yi.l.liu@intel.com,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] iommu/vt-d: Remove SVM_FLAG_PRIVATE_PASID
Date: Tue, 23 Mar 2021 17:33:57 +0000	[thread overview]
Message-ID: <20210323173357.GD2463754@infradead.org> (raw)
In-Reply-To: <20210323010600.678627-4-baolu.lu@linux.intel.com>

On Tue, Mar 23, 2021 at 09:05:58AM +0800, Lu Baolu wrote:
> The SVM_FLAG_PRIVATE_PASID has never been referenced in the tree, and
> there's no plan to have anything to use it. So cleanup it.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

But can we take this a little further?  SVM_FLAG_GUEST_PASID is unused
as well.  SVM_FLAG_GUEST_MODE is only used in drivers/iommu/intel/svm.c,
and SVM_FLAG_SUPERVISOR_MODE is actually used as an API flag to
iommu_sva_bind_device.  So IMHO the latter should be elevated to an
IOMMU API level flag, and then include/linux/intel-svm.h can go away
entirely or at least be moved to drivers/iommu/intel/.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: kevin.tian@intel.com, ashok.raj@intel.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	jacob.jun.pan@intel.com, Will Deacon <will@kernel.org>
Subject: Re: [PATCH 3/5] iommu/vt-d: Remove SVM_FLAG_PRIVATE_PASID
Date: Tue, 23 Mar 2021 17:33:57 +0000	[thread overview]
Message-ID: <20210323173357.GD2463754@infradead.org> (raw)
In-Reply-To: <20210323010600.678627-4-baolu.lu@linux.intel.com>

On Tue, Mar 23, 2021 at 09:05:58AM +0800, Lu Baolu wrote:
> The SVM_FLAG_PRIVATE_PASID has never been referenced in the tree, and
> there's no plan to have anything to use it. So cleanup it.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

But can we take this a little further?  SVM_FLAG_GUEST_PASID is unused
as well.  SVM_FLAG_GUEST_MODE is only used in drivers/iommu/intel/svm.c,
and SVM_FLAG_SUPERVISOR_MODE is actually used as an API flag to
iommu_sva_bind_device.  So IMHO the latter should be elevated to an
IOMMU API level flag, and then include/linux/intel-svm.h can go away
entirely or at least be moved to drivers/iommu/intel/.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-03-23 17:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  1:05 [PATCH 0/5] iommu/vt-d: Several misc cleanups Lu Baolu
2021-03-23  1:05 ` Lu Baolu
2021-03-23  1:05 ` [PATCH 1/5] iommu/vt-d: Remove unused dma map/unmap trace events Lu Baolu
2021-03-23  1:05   ` Lu Baolu
2021-03-23 17:26   ` Christoph Hellwig
2021-03-23 17:26     ` Christoph Hellwig
2021-03-23  1:05 ` [PATCH 2/5] iommu/vt-d: Remove svm_dev_ops Lu Baolu
2021-03-23  1:05   ` Lu Baolu
2021-03-23 17:29   ` Christoph Hellwig
2021-03-23 17:29     ` Christoph Hellwig
2021-03-23  1:05 ` [PATCH 3/5] iommu/vt-d: Remove SVM_FLAG_PRIVATE_PASID Lu Baolu
2021-03-23  1:05   ` Lu Baolu
2021-03-23 17:33   ` Christoph Hellwig [this message]
2021-03-23 17:33     ` Christoph Hellwig
2021-03-24  7:25     ` Lu Baolu
2021-03-24  7:25       ` Lu Baolu
2021-03-23  1:05 ` [PATCH 4/5] iommu/vt-d: Remove unused function declarations Lu Baolu
2021-03-23  1:05   ` Lu Baolu
2021-03-23 17:35   ` Christoph Hellwig
2021-03-23 17:35     ` Christoph Hellwig
2021-03-23  1:06 ` [PATCH 5/5] iommu/vt-d: Make unnecessarily global functions static Lu Baolu
2021-03-23  1:06   ` Lu Baolu
2021-03-23 17:37   ` Christoph Hellwig
2021-03-23 17:37     ` Christoph Hellwig
2021-04-07  8:16 ` [PATCH 0/5] iommu/vt-d: Several misc cleanups Joerg Roedel
2021-04-07  8:16   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323173357.GD2463754@infradead.org \
    --to=hch@infradead.org \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@intel.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.