All of lore.kernel.org
 help / color / mirror / Atom feed
* [agd5f:amd-staging-drm-next 2145/2165] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:5: warning: no previous prototype for function 'aldebaran_mode2_reset'
@ 2021-03-23 22:57 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-03-23 22:57 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3635 bytes --]

tree:   https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head:   a34b64a7d2e86965f4a257dc94e764a084faf5a7
commit: d5efb32c00f66ef51a91c563cc1e956dfd7e6143 [2145/2165] drm/amd/pm: Modify mode2 msg sequence on aldebaran
config: arm-randconfig-r035-20210323 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 78a65cd945d006ff02f9d24d9cc20a302ed93b08)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
        git fetch --no-tags agd5f amd-staging-drm-next
        git checkout d5efb32c00f66ef51a91c563cc1e956dfd7e6143
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:5: warning: no previous prototype for function 'aldebaran_mode2_reset' [-Wmissing-prototypes]
   int aldebaran_mode2_reset(struct smu_context *smu)
       ^
   drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int aldebaran_mode2_reset(struct smu_context *smu)
   ^
   static 
   1 warning generated.


vim +/aldebaran_mode2_reset +1435 drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c

  1434	
> 1435	int aldebaran_mode2_reset(struct smu_context *smu)
  1436	{
  1437		u32 smu_version;
  1438		int ret = 0, index;
  1439		struct amdgpu_device *adev = smu->adev;
  1440		int timeout = 10;
  1441	
  1442		smu_cmn_get_smc_version(smu, NULL, &smu_version);
  1443	
  1444		index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG,
  1445							SMU_MSG_GfxDeviceDriverReset);
  1446	
  1447		mutex_lock(&smu->message_lock);
  1448		if (smu_version >= 0x00441400) {
  1449			ret = smu_cmn_send_msg_without_waiting(smu, (uint16_t)index, SMU_RESET_MODE_2);
  1450			/* This is similar to FLR, wait till max FLR timeout */
  1451			msleep(100);
  1452			dev_dbg(smu->adev->dev, "restore config space...\n");
  1453			/* Restore the config space saved during init */
  1454			amdgpu_device_load_pci_state(adev->pdev);
  1455	
  1456			dev_dbg(smu->adev->dev, "wait for reset ack\n");
  1457			while (ret == -ETIME && timeout)  {
  1458				ret = smu_cmn_wait_for_response(smu);
  1459				/* Wait a bit more time for getting ACK */
  1460				if (ret == -ETIME) {
  1461					--timeout;
  1462					usleep_range(500, 1000);
  1463					continue;
  1464				}
  1465	
  1466				if (ret != 1) {
  1467					dev_err(adev->dev, "failed to send mode2 message \tparam: 0x%08x response %#x\n",
  1468							SMU_RESET_MODE_2, ret);
  1469					goto out;
  1470				}
  1471			}
  1472	
  1473		} else {
  1474			dev_err(adev->dev, "smu fw 0x%x does not support MSG_GfxDeviceDriverReset MSG\n",
  1475					smu_version);
  1476		}
  1477	
  1478		if (ret == 1)
  1479			ret = 0;
  1480	out:
  1481		mutex_unlock(&smu->message_lock);
  1482	
  1483		return ret;
  1484	}
  1485	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32349 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [agd5f:amd-staging-drm-next 2145/2165] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:5: warning: no previous prototype for function 'aldebaran_mode2_reset'
@ 2021-03-24 11:56 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-03-24 11:56 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3696 bytes --]

Hi Lijo,

FYI, the error/warning still remains.

tree:   https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head:   a34b64a7d2e86965f4a257dc94e764a084faf5a7
commit: d5efb32c00f66ef51a91c563cc1e956dfd7e6143 [2145/2165] drm/amd/pm: Modify mode2 msg sequence on aldebaran
config: x86_64-randconfig-a015-20210323 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 78a65cd945d006ff02f9d24d9cc20a302ed93b08)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
        git fetch --no-tags agd5f amd-staging-drm-next
        git checkout d5efb32c00f66ef51a91c563cc1e956dfd7e6143
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:5: warning: no previous prototype for function 'aldebaran_mode2_reset' [-Wmissing-prototypes]
   int aldebaran_mode2_reset(struct smu_context *smu)
       ^
   drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int aldebaran_mode2_reset(struct smu_context *smu)
   ^
   static 
   1 warning generated.


vim +/aldebaran_mode2_reset +1435 drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c

  1434	
> 1435	int aldebaran_mode2_reset(struct smu_context *smu)
  1436	{
  1437		u32 smu_version;
  1438		int ret = 0, index;
  1439		struct amdgpu_device *adev = smu->adev;
  1440		int timeout = 10;
  1441	
  1442		smu_cmn_get_smc_version(smu, NULL, &smu_version);
  1443	
  1444		index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG,
  1445							SMU_MSG_GfxDeviceDriverReset);
  1446	
  1447		mutex_lock(&smu->message_lock);
  1448		if (smu_version >= 0x00441400) {
  1449			ret = smu_cmn_send_msg_without_waiting(smu, (uint16_t)index, SMU_RESET_MODE_2);
  1450			/* This is similar to FLR, wait till max FLR timeout */
  1451			msleep(100);
  1452			dev_dbg(smu->adev->dev, "restore config space...\n");
  1453			/* Restore the config space saved during init */
  1454			amdgpu_device_load_pci_state(adev->pdev);
  1455	
  1456			dev_dbg(smu->adev->dev, "wait for reset ack\n");
  1457			while (ret == -ETIME && timeout)  {
  1458				ret = smu_cmn_wait_for_response(smu);
  1459				/* Wait a bit more time for getting ACK */
  1460				if (ret == -ETIME) {
  1461					--timeout;
  1462					usleep_range(500, 1000);
  1463					continue;
  1464				}
  1465	
  1466				if (ret != 1) {
  1467					dev_err(adev->dev, "failed to send mode2 message \tparam: 0x%08x response %#x\n",
  1468							SMU_RESET_MODE_2, ret);
  1469					goto out;
  1470				}
  1471			}
  1472	
  1473		} else {
  1474			dev_err(adev->dev, "smu fw 0x%x does not support MSG_GfxDeviceDriverReset MSG\n",
  1475					smu_version);
  1476		}
  1477	
  1478		if (ret == 1)
  1479			ret = 0;
  1480	out:
  1481		mutex_unlock(&smu->message_lock);
  1482	
  1483		return ret;
  1484	}
  1485	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37407 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 11:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 22:57 [agd5f:amd-staging-drm-next 2145/2165] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1435:5: warning: no previous prototype for function 'aldebaran_mode2_reset' kernel test robot
2021-03-24 11:56 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.