* [PATCH -next] crypto: hisilicon/hpre - fix build error without CONFIG_CRYPTO_ECDH
@ 2021-03-24 14:42 'Wei Yongjun
2021-03-25 2:07 ` tanghui20
0 siblings, 1 reply; 2+ messages in thread
From: 'Wei Yongjun @ 2021-03-24 14:42 UTC (permalink / raw)
To: weiyongjun1, Herbert Xu, Zaibo Xu, Weili Qian, Meng Yu,
YueHaibing, Shukun Tan, Stephen Rothwell
Cc: linux-crypto, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
GCC reports build error as following:
x86_64-linux-gnu-ld: drivers/crypto/hisilicon/hpre/hpre_crypto.o: in function `hpre_ecdh_set_secret':
hpre_crypto.c:(.text+0x269c): undefined reference to `crypto_ecdh_decode_key'
Fix it by selecting CRYPTO_ECDH.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/crypto/hisilicon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index c45adb15ce8d..bb327d6e365a 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -69,6 +69,7 @@ config CRYPTO_DEV_HISI_HPRE
select CRYPTO_DEV_HISI_QM
select CRYPTO_DH
select CRYPTO_RSA
+ select CRYPTO_ECDH
help
Support for HiSilicon HPRE(High Performance RSA Engine)
accelerator, which can accelerate RSA and DH algorithms.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] crypto: hisilicon/hpre - fix build error without CONFIG_CRYPTO_ECDH
2021-03-24 14:42 [PATCH -next] crypto: hisilicon/hpre - fix build error without CONFIG_CRYPTO_ECDH 'Wei Yongjun
@ 2021-03-25 2:07 ` tanghui20
0 siblings, 0 replies; 2+ messages in thread
From: tanghui20 @ 2021-03-25 2:07 UTC (permalink / raw)
To: 'Wei Yongjun, Herbert Xu, Zaibo Xu, Weili Qian, Meng Yu,
YueHaibing, Shukun Tan, Stephen Rothwell
Cc: linux-crypto, kernel-janitors, Hulk Robot
Thinks, there is a similar patch to yours that was send in advance:
https://www.spinics.net/lists/linux-crypto/msg54238.html
On 2021/3/24 22:42, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> GCC reports build error as following:
>
> x86_64-linux-gnu-ld: drivers/crypto/hisilicon/hpre/hpre_crypto.o: in function `hpre_ecdh_set_secret':
> hpre_crypto.c:(.text+0x269c): undefined reference to `crypto_ecdh_decode_key'
>
> Fix it by selecting CRYPTO_ECDH.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/crypto/hisilicon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index c45adb15ce8d..bb327d6e365a 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -69,6 +69,7 @@ config CRYPTO_DEV_HISI_HPRE
> select CRYPTO_DEV_HISI_QM
> select CRYPTO_DH
> select CRYPTO_RSA
> + select CRYPTO_ECDH
> help
> Support for HiSilicon HPRE(High Performance RSA Engine)
> accelerator, which can accelerate RSA and DH algorithms.
>
> .
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 14:42 [PATCH -next] crypto: hisilicon/hpre - fix build error without CONFIG_CRYPTO_ECDH 'Wei Yongjun
2021-03-25 2:07 ` tanghui20
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.