All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qais Yousef <qais.yousef@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support
Date: Wed, 24 Mar 2021 16:10:54 +0000	[thread overview]
Message-ID: <20210324161054.pg5272lh45n364ko@e107158-lin> (raw)
In-Reply-To: <2404ff10-7acc-3946-6592-31508f257f33@gmail.com>

Hi Florian

On 03/23/21 20:37, Florian Fainelli wrote:
> Hi Qais,
> 
> On 3/23/2021 3:22 PM, Qais Yousef wrote:
> > Hi Alexander
> > 
> > On 03/22/21 18:02, Alexander Sverdlin wrote:
> >> Hi Qais,
> >>
> >> On 22/03/2021 17:32, Qais Yousef wrote:
> >>> Yes you're right. I was a bit optimistic on CONFIG_DYNAMIC_FTRACE will imply
> >>> CONFIG_ARM_MODULE_PLTS is enabled too.
> >>>
> >>> It only has an impact on reducing ifdefery when calling
> >>>
> >>> 	ftrace_call_replace_mod(rec->arch.mod, ...)
> >>>
> >>> Should be easy to wrap rec->arch.mod with its own accessor that will return
> >>> NULL if !CONFIG_ARM_MODULE_PLTS or just ifdef the functions.
> >>>
> >>> Up to Alexander to pick what he prefers :-)
> >>
> >> well, I of course prefer v7 as-is, because this review is running longer than two
> >> years and I actually hope these patches to be finally merged at some point.
> >> But you are welcome to optimize them with follow up patches :)
> > 
> > I appreciate that and thanks a lot for your effort. My attempt to review and
> > test here is to help in getting this merged.
> > 
> > FWIW my main concern is about duplicating the range check in
> > ftrace_call_replace() and using magic values that already exist in
> > __arm_gen_branch_{arm, thumb2}() and better remain encapsulated there.
> 
> Your patch in addition to Alexander's patch work for me as well, so feel
> free to add a:
> 
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> FWIW, what is nice about Alexander's original patch is that it applies
> relatively cleanly to older kernels as well where this is equally

How old are we talking? Was the conflict that bad for the stable maintainers to
deal with it? ie: would it require sending the backport separately?

> needed. There is not currently any Fixes: tag being provided but maybe
> we should amend the second patch with one?

I'm not sure if this will be considered new feature or a bug fix. FWIW,
tagging it for stable sounds reasonable to me.

Thanks!

--
Qais Yosuef

WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support
Date: Wed, 24 Mar 2021 16:10:54 +0000	[thread overview]
Message-ID: <20210324161054.pg5272lh45n364ko@e107158-lin> (raw)
In-Reply-To: <2404ff10-7acc-3946-6592-31508f257f33@gmail.com>

Hi Florian

On 03/23/21 20:37, Florian Fainelli wrote:
> Hi Qais,
> 
> On 3/23/2021 3:22 PM, Qais Yousef wrote:
> > Hi Alexander
> > 
> > On 03/22/21 18:02, Alexander Sverdlin wrote:
> >> Hi Qais,
> >>
> >> On 22/03/2021 17:32, Qais Yousef wrote:
> >>> Yes you're right. I was a bit optimistic on CONFIG_DYNAMIC_FTRACE will imply
> >>> CONFIG_ARM_MODULE_PLTS is enabled too.
> >>>
> >>> It only has an impact on reducing ifdefery when calling
> >>>
> >>> 	ftrace_call_replace_mod(rec->arch.mod, ...)
> >>>
> >>> Should be easy to wrap rec->arch.mod with its own accessor that will return
> >>> NULL if !CONFIG_ARM_MODULE_PLTS or just ifdef the functions.
> >>>
> >>> Up to Alexander to pick what he prefers :-)
> >>
> >> well, I of course prefer v7 as-is, because this review is running longer than two
> >> years and I actually hope these patches to be finally merged at some point.
> >> But you are welcome to optimize them with follow up patches :)
> > 
> > I appreciate that and thanks a lot for your effort. My attempt to review and
> > test here is to help in getting this merged.
> > 
> > FWIW my main concern is about duplicating the range check in
> > ftrace_call_replace() and using magic values that already exist in
> > __arm_gen_branch_{arm, thumb2}() and better remain encapsulated there.
> 
> Your patch in addition to Alexander's patch work for me as well, so feel
> free to add a:
> 
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> FWIW, what is nice about Alexander's original patch is that it applies
> relatively cleanly to older kernels as well where this is equally

How old are we talking? Was the conflict that bad for the stable maintainers to
deal with it? ie: would it require sending the backport separately?

> needed. There is not currently any Fixes: tag being provided but maybe
> we should amend the second patch with one?

I'm not sure if this will be considered new feature or a bug fix. FWIW,
tagging it for stable sounds reasonable to me.

Thanks!

--
Qais Yosuef

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-24 16:11 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 11:09 [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE Alexander A Sverdlin
2021-01-27 11:09 ` Alexander A Sverdlin
2021-01-27 11:09 ` [PATCH v7 1/2] ARM: PLT: Move struct plt_entries definition to header Alexander A Sverdlin
2021-01-27 11:09   ` Alexander A Sverdlin
2021-01-27 20:25   ` Florian Fainelli
2021-01-27 20:25     ` Florian Fainelli
2021-01-27 11:09 ` [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support Alexander A Sverdlin
2021-01-27 11:09   ` Alexander A Sverdlin
2021-01-27 19:36   ` Florian Fainelli
2021-01-27 19:36     ` Florian Fainelli
2021-03-07 17:26   ` Qais Yousef
2021-03-07 17:26     ` Qais Yousef
2021-03-08  7:58     ` Alexander Sverdlin
2021-03-08  7:58       ` Alexander Sverdlin
2021-03-09 17:42       ` Qais Yousef
2021-03-09 17:42         ` Qais Yousef
2021-03-10  7:23         ` Alexander Sverdlin
2021-03-10  7:23           ` Alexander Sverdlin
2021-03-10 16:14           ` Florian Fainelli
2021-03-10 16:14             ` Florian Fainelli
2021-03-10 17:17             ` Alexander Sverdlin
2021-03-10 17:17               ` Alexander Sverdlin
2021-03-12 17:24               ` Qais Yousef
2021-03-12 17:24                 ` Qais Yousef
2021-03-12 18:35                 ` Florian Fainelli
2021-03-12 18:35                   ` Florian Fainelli
2021-03-14 22:02                   ` Qais Yousef
2021-03-14 22:02                     ` Qais Yousef
2021-03-21 19:06                     ` Qais Yousef
2021-03-21 19:06                       ` Qais Yousef
2021-03-22 15:01                       ` Steven Rostedt
2021-03-22 15:01                         ` Steven Rostedt
2021-03-22 16:32                         ` Qais Yousef
2021-03-22 16:32                           ` Qais Yousef
2021-03-22 17:02                           ` Alexander Sverdlin
2021-03-22 17:02                             ` Alexander Sverdlin
2021-03-23 22:22                             ` Qais Yousef
2021-03-23 22:22                               ` Qais Yousef
2021-03-24  3:37                               ` Florian Fainelli
2021-03-24  3:37                                 ` Florian Fainelli
2021-03-24 16:10                                 ` Qais Yousef [this message]
2021-03-24 16:10                                   ` Qais Yousef
2021-03-24  9:04                               ` Alexander Sverdlin
2021-03-24  9:04                                 ` Alexander Sverdlin
2021-03-24 15:57                                 ` Qais Yousef
2021-03-24 15:57                                   ` Qais Yousef
2021-03-24 16:33                                   ` Alexander Sverdlin
2021-03-24 16:33                                     ` Alexander Sverdlin
2021-03-24 16:46                                     ` Qais Yousef
2021-03-24 16:46                                       ` Qais Yousef
2021-03-15  9:19                   ` Alexander Sverdlin
2021-03-15  9:19                     ` Alexander Sverdlin
2021-02-03 18:23 ` [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE Florian Fainelli
2021-02-03 18:23   ` Florian Fainelli
2021-02-15 18:31   ` Ard Biesheuvel
2021-02-15 18:31     ` Ard Biesheuvel
2021-03-02  8:29     ` Linus Walleij
2021-03-02  8:29       ` Linus Walleij
2021-03-02 10:00       ` Alexander Sverdlin
2021-03-02 10:00         ` Alexander Sverdlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324161054.pg5272lh45n364ko@e107158-lin \
    --to=qais.yousef@arm.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=ardb@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.