From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: serial: amlogic, meson-uart: add amlogic, uart-fifosize property
Date: Wed, 24 Mar 2021 11:40:59 -0600 [thread overview]
Message-ID: <20210324174059.GA3308031@robh.at.kernel.org> (raw)
In-Reply-To: <CAFBinCA1WhtWLEfJ-QyBbZpsY75r=su6uzyWamY6nHOQ+HYvAw@mail.gmail.com>
On Tue, Mar 23, 2021 at 10:33:15PM +0100, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Mon, Mar 15, 2021 at 9:37 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >
> > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else"
> > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe
> do we still need wrapping of long lines in commit messages?
> if so I think the line above is too long
>
> > a different FIFO size from the other ports (64bytes).
> >
> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> one additional note below
>
> > ---
> > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > index 75ebc9952a99..e0a742112783 100644
> > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > @@ -55,6 +55,12 @@ properties:
> > - const: pclk
> > - const: baud
> >
> > +
> > + amlogic,uart-fifosize:
> > + description: The fifo size supported by the UART channel.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [64, 128]
> I personally think this is generic enough to be described as fifo-size
> (as it's done in Documentation/devicetree/bindings/serial/8250.yaml)
> let's wait and hear what Rob thinks
Yes.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: serial: amlogic, meson-uart: add amlogic, uart-fifosize property
Date: Wed, 24 Mar 2021 11:40:59 -0600 [thread overview]
Message-ID: <20210324174059.GA3308031@robh.at.kernel.org> (raw)
In-Reply-To: <CAFBinCA1WhtWLEfJ-QyBbZpsY75r=su6uzyWamY6nHOQ+HYvAw@mail.gmail.com>
On Tue, Mar 23, 2021 at 10:33:15PM +0100, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Mon, Mar 15, 2021 at 9:37 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >
> > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else"
> > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe
> do we still need wrapping of long lines in commit messages?
> if so I think the line above is too long
>
> > a different FIFO size from the other ports (64bytes).
> >
> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> one additional note below
>
> > ---
> > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > index 75ebc9952a99..e0a742112783 100644
> > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > @@ -55,6 +55,12 @@ properties:
> > - const: pclk
> > - const: baud
> >
> > +
> > + amlogic,uart-fifosize:
> > + description: The fifo size supported by the UART channel.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [64, 128]
> I personally think this is generic enough to be described as fifo-size
> (as it's done in Documentation/devicetree/bindings/serial/8250.yaml)
> let's wait and hear what Rob thinks
Yes.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: serial: amlogic, meson-uart: add amlogic, uart-fifosize property
Date: Wed, 24 Mar 2021 11:40:59 -0600 [thread overview]
Message-ID: <20210324174059.GA3308031@robh.at.kernel.org> (raw)
In-Reply-To: <CAFBinCA1WhtWLEfJ-QyBbZpsY75r=su6uzyWamY6nHOQ+HYvAw@mail.gmail.com>
On Tue, Mar 23, 2021 at 10:33:15PM +0100, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Mon, Mar 15, 2021 at 9:37 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >
> > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else"
> > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe
> do we still need wrapping of long lines in commit messages?
> if so I think the line above is too long
>
> > a different FIFO size from the other ports (64bytes).
> >
> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> one additional note below
>
> > ---
> > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > index 75ebc9952a99..e0a742112783 100644
> > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > @@ -55,6 +55,12 @@ properties:
> > - const: pclk
> > - const: baud
> >
> > +
> > + amlogic,uart-fifosize:
> > + description: The fifo size supported by the UART channel.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [64, 128]
> I personally think this is generic enough to be described as fifo-size
> (as it's done in Documentation/devicetree/bindings/serial/8250.yaml)
> let's wait and hear what Rob thinks
Yes.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-03-24 17:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 8:34 [PATCH 0/3] tty: serial: meson: add amlogic,uart-fifosize property Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
2021-03-15 8:34 ` [PATCH 1/3] dt-bindings: serial: amlogic,meson-uart: " Neil Armstrong
2021-03-15 8:34 ` [PATCH 1/3] dt-bindings: serial: amlogic, meson-uart: add amlogic, uart-fifosize property Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
2021-03-23 21:33 ` Martin Blumenstingl
2021-03-23 21:33 ` Martin Blumenstingl
2021-03-23 21:33 ` Martin Blumenstingl
2021-03-24 17:40 ` Rob Herring [this message]
2021-03-24 17:40 ` Rob Herring
2021-03-24 17:40 ` Rob Herring
2021-03-15 8:34 ` [PATCH 2/3] tty: serial: meson: retrieve port FIFO size from DT Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
2021-03-16 0:26 ` Kevin Hilman
2021-03-16 0:26 ` Kevin Hilman
2021-03-16 0:26 ` Kevin Hilman
2021-03-23 21:34 ` Martin Blumenstingl
2021-03-23 21:34 ` Martin Blumenstingl
2021-03-23 21:34 ` Martin Blumenstingl
2021-03-15 8:34 ` [PATCH 3/3] arm64: dts: meson: set 128bytes FIFO size on uart A Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
2021-03-15 8:34 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324174059.GA3308031@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.