From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, X86 ML <x86@kernel.org>,
Daniel Xu <dxu@dxuuu.xyz>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
kuba@kernel.org, mingo@redhat.com, ast@kernel.org,
tglx@linutronix.de, kernel-team@fb.com, yhs@fb.com,
linux-ia64@vger.kernel.org,
Abhishek Sagar <sagar.abhishek@gmail.com>
Subject: Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline
Date: Wed, 24 Mar 2021 20:26:13 -0400 [thread overview]
Message-ID: <20210324202613.7cad6f4f@oasis.local.home> (raw)
In-Reply-To: <20210325084741.74bdb2b1d2ed00fe68840cea@kernel.org>
On Thu, 25 Mar 2021 08:47:41 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > I think the REGS and REGS_PARTIAL cases can also be affected by function
> > graph tracing. So should they use the generic unwind_recover_ret_addr()
> > instead of unwind_recover_kretprobe()?
>
> Yes, but I'm not sure this parameter can be applied.
> For example, it passed "state->sp - sizeof(unsigned long)" as where the
> return address stored address. Is that same on ftrace graph too?
Stack traces on the return side of function graph tracer has never
worked. It's on my todo list, because that's one of the requirements to
get right if we every manage to combine kretprobe and function graph
tracers together.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, X86 ML <x86@kernel.org>,
Daniel Xu <dxu@dxuuu.xyz>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
kuba@kernel.org, mingo@redhat.com, ast@kernel.org,
tglx@linutronix.de, kernel-team@fb.com, yhs@fb.com,
linux-ia64@vger.kernel.org,
Abhishek Sagar <sagar.abhishek@gmail.com>
Subject: Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline
Date: Thu, 25 Mar 2021 00:26:13 +0000 [thread overview]
Message-ID: <20210324202613.7cad6f4f@oasis.local.home> (raw)
In-Reply-To: <20210325084741.74bdb2b1d2ed00fe68840cea@kernel.org>
On Thu, 25 Mar 2021 08:47:41 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > I think the REGS and REGS_PARTIAL cases can also be affected by function
> > graph tracing. So should they use the generic unwind_recover_ret_addr()
> > instead of unwind_recover_kretprobe()?
>
> Yes, but I'm not sure this parameter can be applied.
> For example, it passed "state->sp - sizeof(unsigned long)" as where the
> return address stored address. Is that same on ftrace graph too?
Stack traces on the return side of function graph tracer has never
worked. It's on my todo list, because that's one of the requirements to
get right if we every manage to combine kretprobe and function graph
tracers together.
-- Steve
next prev parent reply other threads:[~2021-03-25 0:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 6:39 [PATCH -tip v4 00/12] kprobes: Fix stacktrace with kretprobes on x86 Masami Hiramatsu
2021-03-22 6:39 ` Masami Hiramatsu
2021-03-22 6:39 ` [PATCH -tip v4 01/12] ia64: kprobes: Fix to pass correct trampoline address to the handler Masami Hiramatsu
2021-03-22 6:39 ` Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 02/12] kprobes: treewide: Replace arch_deref_entry_point() with dereference_function_descriptor() Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 02/12] kprobes: treewide: Replace arch_deref_entry_point() with dereference_function_ Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 03/12] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler() Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 03/12] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 04/12] kprobes: Add kretprobe_find_ret_addr() for searching return address Masami Hiramatsu
2021-03-22 6:40 ` Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 05/12] x86/kprobes: Add UNWIND_HINT_FUNC on kretprobe_trampoline code Masami Hiramatsu
2021-03-22 6:40 ` Masami Hiramatsu
2021-03-22 6:40 ` [PATCH -tip v4 06/12] ARC: Add instruction_pointer_set() API Masami Hiramatsu
2021-03-22 6:40 ` Masami Hiramatsu
2021-03-22 6:41 ` [PATCH -tip v4 07/12] ia64: " Masami Hiramatsu
2021-03-22 6:41 ` Masami Hiramatsu
2021-03-22 6:41 ` [PATCH -tip v4 08/12] arm: kprobes: Make a space for regs->ARM_pc at kretprobe_trampoline Masami Hiramatsu
2021-03-22 6:41 ` Masami Hiramatsu
2021-03-23 0:04 ` Masami Hiramatsu
2021-03-23 0:04 ` Masami Hiramatsu
2021-03-22 6:41 ` [PATCH -tip v4 09/12] kprobes: Setup instruction pointer in __kretprobe_trampoline_handler Masami Hiramatsu
2021-03-22 6:41 ` Masami Hiramatsu
2021-03-22 6:41 ` [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline Masami Hiramatsu
2021-03-22 6:41 ` Masami Hiramatsu
2021-03-23 22:30 ` Peter Zijlstra
2021-03-23 22:30 ` Peter Zijlstra
2021-03-24 1:40 ` Masami Hiramatsu
2021-03-24 1:40 ` Masami Hiramatsu
2021-03-24 16:01 ` Josh Poimboeuf
2021-03-24 16:01 ` Josh Poimboeuf
2021-03-24 23:47 ` Masami Hiramatsu
2021-03-24 23:47 ` Masami Hiramatsu
2021-03-25 0:26 ` Steven Rostedt [this message]
2021-03-25 0:26 ` Steven Rostedt
2021-03-25 3:25 ` Masami Hiramatsu
2021-03-25 3:25 ` Masami Hiramatsu
2021-03-25 18:05 ` Masami Hiramatsu
2021-03-25 18:05 ` Masami Hiramatsu
2021-03-26 12:03 ` Masami Hiramatsu
2021-03-26 12:03 ` Masami Hiramatsu
2021-03-26 14:20 ` Steven Rostedt
2021-03-26 14:20 ` Steven Rostedt
2021-03-30 4:58 ` Josh Poimboeuf
2021-03-30 4:58 ` Josh Poimboeuf
2021-03-22 6:41 ` [PATCH -tip v4 11/12] x86/unwind: Recover kretprobe trampoline entry Masami Hiramatsu
2021-03-22 6:41 ` Masami Hiramatsu
2021-03-22 6:42 ` [PATCH -tip v4 12/12] tracing: Show kretprobe unknown indicator only for kretprobe_trampoline Masami Hiramatsu
2021-03-22 6:42 ` Masami Hiramatsu
2021-03-22 15:11 ` Steven Rostedt
2021-03-22 15:11 ` Steven Rostedt
2021-03-22 23:56 ` Masami Hiramatsu
2021-03-22 23:56 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324202613.7cad6f4f@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=jpoimboe@redhat.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sagar.abhishek@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.