* [PATCH 1/2] drm/i915: add gem/gt TODO @ 2021-03-24 21:10 ` Daniel Vetter 0 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-24 21:10 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, Jason Ekstrand, Rodrigo Vivi, Dave Airlie We've discussed a bit how to get the gem/gt team better integrated and collaborate more with the wider community and agreed to the following: - all gem/gt patches are reviewed on dri-devel for now. That's overkill, but in the past there was definitely too little of that. - i915-gem folks are encouraged to cross review core patches from other teams - big features (especially uapi changes) need to be discussed in an rfc patch that documents the interface and big picture design, before we get lost in the details of the code - Also a rough TODO (can be refined as we go ofc) to get gem/gt back on track, like we've e.g. done with DAL/DC to get that in shape. v2: - add dma_fence annotations (Dave) - tasklet helpers (Jani on irc) There was also a discussion about moving these into gitlab issues, or gitlab issues as additional discussion place at least. For now it's just the TODO file Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Acked-by: Dave Airlie <airlied@redhat.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/TODO.txt | 41 +++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 drivers/gpu/drm/i915/TODO.txt diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt new file mode 100644 index 000000000000..81a82c9c203f --- /dev/null +++ b/drivers/gpu/drm/i915/TODO.txt @@ -0,0 +1,41 @@ +gem/gt TODO items +----------------- + +- For discrete memory manager, merge enough dg1 to be able to refactor it to + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has + improved a lot the past 2 years, there's no reason anymore not to use it. + +- Come up with a plan what to do with drm/scheduler and how to get there. + +- Roll out dma_fence critical section annotations. + +- There's a lot of complexity added past few years to make relocations faster. + That doesn't make sense given hw and gpu apis moved away from this model years + ago: + 1. Land a modern pre-bound uapi like VM_BIND + 2. Any complexity added in this area past few years which can't be justified + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on + the bo and vm, plus some lru locks is all that needed. No complex rcu, + refcounts, caching, ... on everything. + This is the matching task on the vm side compared to ttm/dma_resv on the + backing storage side. + +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. + How-to-dma_fence is core and drivers really shouldn't build their own world + here, treating everything else as a fixed platform. i915_sw_fence concepts + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or + removed if dri-devel consensus is that it's not a good idea. Once that's done + maybe even remove it if there's nothing left. + +Smaller things: +- i915_utils.h needs to be moved to the right places. + +- dma_fence_work should be in drivers/dma-buf + +- i915_mm.c should be moved to the right places. Some of the helpers also look a + bit fishy: + + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ + +- tasklet helpers in i915_gem.h also look a bit misplaced and should + probably be moved to tasklet headers. -- 2.31.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915: add gem/gt TODO @ 2021-03-24 21:10 ` Daniel Vetter 0 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-24 21:10 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, Dave Airlie We've discussed a bit how to get the gem/gt team better integrated and collaborate more with the wider community and agreed to the following: - all gem/gt patches are reviewed on dri-devel for now. That's overkill, but in the past there was definitely too little of that. - i915-gem folks are encouraged to cross review core patches from other teams - big features (especially uapi changes) need to be discussed in an rfc patch that documents the interface and big picture design, before we get lost in the details of the code - Also a rough TODO (can be refined as we go ofc) to get gem/gt back on track, like we've e.g. done with DAL/DC to get that in shape. v2: - add dma_fence annotations (Dave) - tasklet helpers (Jani on irc) There was also a discussion about moving these into gitlab issues, or gitlab issues as additional discussion place at least. For now it's just the TODO file Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Acked-by: Dave Airlie <airlied@redhat.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/TODO.txt | 41 +++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 drivers/gpu/drm/i915/TODO.txt diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt new file mode 100644 index 000000000000..81a82c9c203f --- /dev/null +++ b/drivers/gpu/drm/i915/TODO.txt @@ -0,0 +1,41 @@ +gem/gt TODO items +----------------- + +- For discrete memory manager, merge enough dg1 to be able to refactor it to + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has + improved a lot the past 2 years, there's no reason anymore not to use it. + +- Come up with a plan what to do with drm/scheduler and how to get there. + +- Roll out dma_fence critical section annotations. + +- There's a lot of complexity added past few years to make relocations faster. + That doesn't make sense given hw and gpu apis moved away from this model years + ago: + 1. Land a modern pre-bound uapi like VM_BIND + 2. Any complexity added in this area past few years which can't be justified + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on + the bo and vm, plus some lru locks is all that needed. No complex rcu, + refcounts, caching, ... on everything. + This is the matching task on the vm side compared to ttm/dma_resv on the + backing storage side. + +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. + How-to-dma_fence is core and drivers really shouldn't build their own world + here, treating everything else as a fixed platform. i915_sw_fence concepts + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or + removed if dri-devel consensus is that it's not a good idea. Once that's done + maybe even remove it if there's nothing left. + +Smaller things: +- i915_utils.h needs to be moved to the right places. + +- dma_fence_work should be in drivers/dma-buf + +- i915_mm.c should be moved to the right places. Some of the helpers also look a + bit fishy: + + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ + +- tasklet helpers in i915_gem.h also look a bit misplaced and should + probably be moved to tasklet headers. -- 2.31.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 2/2] drm/doc: Add RFC section 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter @ 2021-03-24 21:10 ` Daniel Vetter -1 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-24 21:10 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, Jason Ekstrand, Rodrigo Vivi, Dave Airlie Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) Cc: Simon Ser <contact@emersion.fr> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- Documentation/gpu/index.rst | 1 + Documentation/gpu/rfc.rst | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 Documentation/gpu/rfc.rst diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst index c9a51e3bfb5a..df58cb826d68 100644 --- a/Documentation/gpu/index.rst +++ b/Documentation/gpu/index.rst @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide vga-switcheroo vgaarbiter todo + rfc .. only:: subproject and html diff --git a/Documentation/gpu/rfc.rst b/Documentation/gpu/rfc.rst new file mode 100644 index 000000000000..a8621f7dab8b --- /dev/null +++ b/Documentation/gpu/rfc.rst @@ -0,0 +1,17 @@ +=============== +GPU RFC Section +=============== + +For complex work, especially new uapi, it is often good to nail the high level +design issues before getting lost in the code details. This section is meant to +host such documentation: + +* Each RFC should be a section in this file, explaining the goal and main design + considerations. Especially for uapi make sure you Cc: all relevant project + mailing lists and involved people outside of dri-devel. + +* For uapi structures add a file to this directory with and then pull the + kerneldoc in like with real uapi headers. + +* Once the code has landed move all the documentation to the right places in + the main core, helper or driver sections. -- 2.31.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section @ 2021-03-24 21:10 ` Daniel Vetter 0 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-24 21:10 UTC (permalink / raw) To: DRI Development Cc: Simon Ser, Daniel Vetter, Daniel Vetter, Intel Graphics Development, Dave Airlie Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) Cc: Simon Ser <contact@emersion.fr> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- Documentation/gpu/index.rst | 1 + Documentation/gpu/rfc.rst | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 Documentation/gpu/rfc.rst diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst index c9a51e3bfb5a..df58cb826d68 100644 --- a/Documentation/gpu/index.rst +++ b/Documentation/gpu/index.rst @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide vga-switcheroo vgaarbiter todo + rfc .. only:: subproject and html diff --git a/Documentation/gpu/rfc.rst b/Documentation/gpu/rfc.rst new file mode 100644 index 000000000000..a8621f7dab8b --- /dev/null +++ b/Documentation/gpu/rfc.rst @@ -0,0 +1,17 @@ +=============== +GPU RFC Section +=============== + +For complex work, especially new uapi, it is often good to nail the high level +design issues before getting lost in the code details. This section is meant to +host such documentation: + +* Each RFC should be a section in this file, explaining the goal and main design + considerations. Especially for uapi make sure you Cc: all relevant project + mailing lists and involved people outside of dri-devel. + +* For uapi structures add a file to this directory with and then pull the + kerneldoc in like with real uapi headers. + +* Once the code has landed move all the documentation to the right places in + the main core, helper or driver sections. -- 2.31.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 2/2] drm/doc: Add RFC section 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter @ 2021-03-25 2:37 ` Jason Ekstrand -1 siblings, 0 replies; 26+ messages in thread From: Jason Ekstrand @ 2021-03-25 2:37 UTC (permalink / raw) To: Daniel Vetter, DRI Development Cc: Daniel Vetter, Intel Graphics Development, Rodrigo Vivi, Dave Airlie [-- Attachment #1.1: Type: text/plain, Size: 2226 bytes --] Acked-by: Jason Ekstrand <jason@jlekstrand.net> On March 24, 2021 16:10:48 Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > v2: Add reminder to not forget userspace projects in the discussion > (Simon, Jason) > > Cc: Simon Ser <contact@emersion.fr> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > Cc: Dave Airlie <airlied@redhat.com> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Dave Airlie <airlied@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > Documentation/gpu/index.rst | 1 + > Documentation/gpu/rfc.rst | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 Documentation/gpu/rfc.rst > > diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst > index c9a51e3bfb5a..df58cb826d68 100644 > --- a/Documentation/gpu/index.rst > +++ b/Documentation/gpu/index.rst > @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide > vga-switcheroo > vgaarbiter > todo > + rfc > > .. only:: subproject and html > > diff --git a/Documentation/gpu/rfc.rst b/Documentation/gpu/rfc.rst > new file mode 100644 > index 000000000000..a8621f7dab8b > --- /dev/null > +++ b/Documentation/gpu/rfc.rst > @@ -0,0 +1,17 @@ > +=============== > +GPU RFC Section > +=============== > + > +For complex work, especially new uapi, it is often good to nail the high level > +design issues before getting lost in the code details. This section is > meant to > +host such documentation: > + > +* Each RFC should be a section in this file, explaining the goal and main > design > + considerations. Especially for uapi make sure you Cc: all relevant project > + mailing lists and involved people outside of dri-devel. > + > +* For uapi structures add a file to this directory with and then pull the > + kerneldoc in like with real uapi headers. > + > +* Once the code has landed move all the documentation to the right places in > + the main core, helper or driver sections. > -- > 2.31.0 [-- Attachment #1.2: Type: text/html, Size: 4116 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section @ 2021-03-25 2:37 ` Jason Ekstrand 0 siblings, 0 replies; 26+ messages in thread From: Jason Ekstrand @ 2021-03-25 2:37 UTC (permalink / raw) To: Daniel Vetter, DRI Development Cc: Daniel Vetter, Simon Ser, Intel Graphics Development, Dave Airlie [-- Attachment #1.1: Type: text/plain, Size: 2226 bytes --] Acked-by: Jason Ekstrand <jason@jlekstrand.net> On March 24, 2021 16:10:48 Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > v2: Add reminder to not forget userspace projects in the discussion > (Simon, Jason) > > Cc: Simon Ser <contact@emersion.fr> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > Cc: Dave Airlie <airlied@redhat.com> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Dave Airlie <airlied@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > Documentation/gpu/index.rst | 1 + > Documentation/gpu/rfc.rst | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 Documentation/gpu/rfc.rst > > diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst > index c9a51e3bfb5a..df58cb826d68 100644 > --- a/Documentation/gpu/index.rst > +++ b/Documentation/gpu/index.rst > @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide > vga-switcheroo > vgaarbiter > todo > + rfc > > .. only:: subproject and html > > diff --git a/Documentation/gpu/rfc.rst b/Documentation/gpu/rfc.rst > new file mode 100644 > index 000000000000..a8621f7dab8b > --- /dev/null > +++ b/Documentation/gpu/rfc.rst > @@ -0,0 +1,17 @@ > +=============== > +GPU RFC Section > +=============== > + > +For complex work, especially new uapi, it is often good to nail the high level > +design issues before getting lost in the code details. This section is > meant to > +host such documentation: > + > +* Each RFC should be a section in this file, explaining the goal and main > design > + considerations. Especially for uapi make sure you Cc: all relevant project > + mailing lists and involved people outside of dri-devel. > + > +* For uapi structures add a file to this directory with and then pull the > + kerneldoc in like with real uapi headers. > + > +* Once the code has landed move all the documentation to the right places in > + the main core, helper or driver sections. > -- > 2.31.0 [-- Attachment #1.2: Type: text/html, Size: 4116 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/2] drm/doc: Add RFC section 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter @ 2021-03-25 9:41 ` Simon Ser -1 siblings, 0 replies; 26+ messages in thread From: Simon Ser @ 2021-03-25 9:41 UTC (permalink / raw) To: Daniel Vetter Cc: Daniel Vetter, Intel Graphics Development, DRI Development, Jason Ekstrand, Rodrigo Vivi, Dave Airlie Acked-by: Simon Ser <contact@emersion.fr> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section @ 2021-03-25 9:41 ` Simon Ser 0 siblings, 0 replies; 26+ messages in thread From: Simon Ser @ 2021-03-25 9:41 UTC (permalink / raw) To: Daniel Vetter Cc: Daniel Vetter, Intel Graphics Development, DRI Development, Dave Airlie Acked-by: Simon Ser <contact@emersion.fr> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] drm/doc: Add RFC section 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter @ 2021-03-25 22:58 ` Daniel Vetter -1 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-25 22:58 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, Jason Ekstrand, Rodrigo Vivi, Dave Airlie Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) v3: Actually put this into a folder, so we have it all (.rst files and headers for kerneldoc) contained somewhere separate (Jason) Cc: Simon Ser <contact@emersion.fr> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Acked-by: Jason Ekstrand <jason@jlekstrand.net> Acked-by: Simon Ser <contact@emersion.fr> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- Documentation/gpu/index.rst | 1 + Documentation/gpu/rfc/index.rst | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 Documentation/gpu/rfc/index.rst diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst index c9a51e3bfb5a..ec4bc72438e4 100644 --- a/Documentation/gpu/index.rst +++ b/Documentation/gpu/index.rst @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide vga-switcheroo vgaarbiter todo + rfc/index .. only:: subproject and html diff --git a/Documentation/gpu/rfc/index.rst b/Documentation/gpu/rfc/index.rst new file mode 100644 index 000000000000..a8621f7dab8b --- /dev/null +++ b/Documentation/gpu/rfc/index.rst @@ -0,0 +1,17 @@ +=============== +GPU RFC Section +=============== + +For complex work, especially new uapi, it is often good to nail the high level +design issues before getting lost in the code details. This section is meant to +host such documentation: + +* Each RFC should be a section in this file, explaining the goal and main design + considerations. Especially for uapi make sure you Cc: all relevant project + mailing lists and involved people outside of dri-devel. + +* For uapi structures add a file to this directory with and then pull the + kerneldoc in like with real uapi headers. + +* Once the code has landed move all the documentation to the right places in + the main core, helper or driver sections. -- 2.31.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [Intel-gfx] [PATCH] drm/doc: Add RFC section @ 2021-03-25 22:58 ` Daniel Vetter 0 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-25 22:58 UTC (permalink / raw) To: DRI Development Cc: Simon Ser, Daniel Vetter, Daniel Vetter, Intel Graphics Development, Dave Airlie Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) v3: Actually put this into a folder, so we have it all (.rst files and headers for kerneldoc) contained somewhere separate (Jason) Cc: Simon Ser <contact@emersion.fr> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Acked-by: Jason Ekstrand <jason@jlekstrand.net> Acked-by: Simon Ser <contact@emersion.fr> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- Documentation/gpu/index.rst | 1 + Documentation/gpu/rfc/index.rst | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 Documentation/gpu/rfc/index.rst diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst index c9a51e3bfb5a..ec4bc72438e4 100644 --- a/Documentation/gpu/index.rst +++ b/Documentation/gpu/index.rst @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide vga-switcheroo vgaarbiter todo + rfc/index .. only:: subproject and html diff --git a/Documentation/gpu/rfc/index.rst b/Documentation/gpu/rfc/index.rst new file mode 100644 index 000000000000..a8621f7dab8b --- /dev/null +++ b/Documentation/gpu/rfc/index.rst @@ -0,0 +1,17 @@ +=============== +GPU RFC Section +=============== + +For complex work, especially new uapi, it is often good to nail the high level +design issues before getting lost in the code details. This section is meant to +host such documentation: + +* Each RFC should be a section in this file, explaining the goal and main design + considerations. Especially for uapi make sure you Cc: all relevant project + mailing lists and involved people outside of dri-devel. + +* For uapi structures add a file to this directory with and then pull the + kerneldoc in like with real uapi headers. + +* Once the code has landed move all the documentation to the right places in + the main core, helper or driver sections. -- 2.31.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH] drm/doc: Add RFC section 2021-03-25 22:58 ` [Intel-gfx] " Daniel Vetter @ 2021-03-26 8:25 ` Daniel Vetter -1 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-26 8:25 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, Jason Ekstrand, Rodrigo Vivi, Dave Airlie On Thu, Mar 25, 2021 at 11:58:59PM +0100, Daniel Vetter wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > v2: Add reminder to not forget userspace projects in the discussion > (Simon, Jason) > > v3: Actually put this into a folder, so we have it all (.rst files and > headers for kerneldoc) contained somewhere separate (Jason) > > Cc: Simon Ser <contact@emersion.fr> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > Cc: Dave Airlie <airlied@redhat.com> > Acked-by: Jason Ekstrand <jason@jlekstrand.net> > Acked-by: Simon Ser <contact@emersion.fr> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Dave Airlie <airlied@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Smashed both patches into my topic branch that I'll send to Dave later today. -Daniel > --- > Documentation/gpu/index.rst | 1 + > Documentation/gpu/rfc/index.rst | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 Documentation/gpu/rfc/index.rst > > diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst > index c9a51e3bfb5a..ec4bc72438e4 100644 > --- a/Documentation/gpu/index.rst > +++ b/Documentation/gpu/index.rst > @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide > vga-switcheroo > vgaarbiter > todo > + rfc/index > > .. only:: subproject and html > > diff --git a/Documentation/gpu/rfc/index.rst b/Documentation/gpu/rfc/index.rst > new file mode 100644 > index 000000000000..a8621f7dab8b > --- /dev/null > +++ b/Documentation/gpu/rfc/index.rst > @@ -0,0 +1,17 @@ > +=============== > +GPU RFC Section > +=============== > + > +For complex work, especially new uapi, it is often good to nail the high level > +design issues before getting lost in the code details. This section is meant to > +host such documentation: > + > +* Each RFC should be a section in this file, explaining the goal and main design > + considerations. Especially for uapi make sure you Cc: all relevant project > + mailing lists and involved people outside of dri-devel. > + > +* For uapi structures add a file to this directory with and then pull the > + kerneldoc in like with real uapi headers. > + > +* Once the code has landed move all the documentation to the right places in > + the main core, helper or driver sections. > -- > 2.31.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/doc: Add RFC section @ 2021-03-26 8:25 ` Daniel Vetter 0 siblings, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-26 8:25 UTC (permalink / raw) To: DRI Development Cc: Simon Ser, Daniel Vetter, Daniel Vetter, Intel Graphics Development, Dave Airlie On Thu, Mar 25, 2021 at 11:58:59PM +0100, Daniel Vetter wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > v2: Add reminder to not forget userspace projects in the discussion > (Simon, Jason) > > v3: Actually put this into a folder, so we have it all (.rst files and > headers for kerneldoc) contained somewhere separate (Jason) > > Cc: Simon Ser <contact@emersion.fr> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > Cc: Dave Airlie <airlied@redhat.com> > Acked-by: Jason Ekstrand <jason@jlekstrand.net> > Acked-by: Simon Ser <contact@emersion.fr> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Dave Airlie <airlied@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Smashed both patches into my topic branch that I'll send to Dave later today. -Daniel > --- > Documentation/gpu/index.rst | 1 + > Documentation/gpu/rfc/index.rst | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 Documentation/gpu/rfc/index.rst > > diff --git a/Documentation/gpu/index.rst b/Documentation/gpu/index.rst > index c9a51e3bfb5a..ec4bc72438e4 100644 > --- a/Documentation/gpu/index.rst > +++ b/Documentation/gpu/index.rst > @@ -16,6 +16,7 @@ Linux GPU Driver Developer's Guide > vga-switcheroo > vgaarbiter > todo > + rfc/index > > .. only:: subproject and html > > diff --git a/Documentation/gpu/rfc/index.rst b/Documentation/gpu/rfc/index.rst > new file mode 100644 > index 000000000000..a8621f7dab8b > --- /dev/null > +++ b/Documentation/gpu/rfc/index.rst > @@ -0,0 +1,17 @@ > +=============== > +GPU RFC Section > +=============== > + > +For complex work, especially new uapi, it is often good to nail the high level > +design issues before getting lost in the code details. This section is meant to > +host such documentation: > + > +* Each RFC should be a section in this file, explaining the goal and main design > + considerations. Especially for uapi make sure you Cc: all relevant project > + mailing lists and involved people outside of dri-devel. > + > +* For uapi structures add a file to this directory with and then pull the > + kerneldoc in like with real uapi headers. > + > +* Once the code has landed move all the documentation to the right places in > + the main core, helper or driver sections. > -- > 2.31.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: add gem/gt TODO 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter (?) (?) @ 2021-03-25 18:25 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-25 18:25 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : warning == Summary == $ dim checkpatch origin/drm-tip 591bc42605c7 drm/i915: add gem/gt TODO -:41: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 -:86: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>' total: 0 errors, 2 warnings, 0 checks, 41 lines checked c20d16dd7b3d drm/doc: Add RFC section -:37: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 -:42: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #42: FILE: Documentation/gpu/rfc.rst:1: +=============== -:58: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>' total: 0 errors, 3 warnings, 0 checks, 24 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: add gem/gt TODO 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter ` (2 preceding siblings ...) (?) @ 2021-03-25 18:29 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-25 18:29 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: add gem/gt TODO 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter ` (3 preceding siblings ...) (?) @ 2021-03-25 18:55 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-25 18:55 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 6490 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895 -> Patchwork_19850 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_19850: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_selftest@live@hangcheck: - {fi-hsw-gt1}: [PASS][1] -> [DMESG-WARN][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html Known issues ------------ Here are the changes found in Patchwork_19850 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fence@basic-busy@bcs0: - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +24 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html * igt@gem_huc_copy@huc-copy: - fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@i915_selftest@live@execlists: - fi-bsw-kefka: [PASS][5] -> [INCOMPLETE][6] ([i915#2782] / [i915#2940]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-bsw-kefka/igt@i915_selftest@live@execlists.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-bsw-kefka/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886] / [i915#2291]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@late_gt_pm: - fi-bsw-nick: [PASS][8] -> [DMESG-FAIL][9] ([i915#2927]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@runner@aborted: - fi-bsw-kefka: NOTRUN -> [FAIL][12] ([i915#1436]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-bsw-kefka/igt@runner@aborted.html - fi-bsw-nick: NOTRUN -> [FAIL][13] ([i915#1436]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-bsw-nick/igt@runner@aborted.html * igt@vgem_basic@setversion: - fi-tgl-y: [PASS][14] -> [DMESG-WARN][15] ([i915#402]) +2 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-tgl-y/igt@vgem_basic@setversion.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-tgl-y/igt@vgem_basic@setversion.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [DMESG-WARN][16] ([i915#2411] / [i915#402]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@i915_getparams_basic@basic-subslice-total: - fi-tgl-y: [DMESG-WARN][18] ([i915#402]) -> [PASS][19] +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#3180]: https://gitlab.freedesktop.org/drm/intel/issues/3180 [i915#3278]: https://gitlab.freedesktop.org/drm/intel/issues/3278 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Participating hosts (46 -> 42) ------------------------------ Additional (1): fi-kbl-soraka Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus fi-snb-2600 Build changes ------------- * Linux: CI_DRM_9895 -> Patchwork_19850 CI-20190529: 20190529 CI_DRM_9895: bb187b1b292c637c3ef195f46d6e5c74f60df8f4 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6046: e76039273b1524147c43dba061756f06003d56ae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19850: c20d16dd7b3d478d3a3a6472cfd23f4aac77c73b @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == c20d16dd7b3d drm/doc: Add RFC section 591bc42605c7 drm/i915: add gem/gt TODO == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/index.html [-- Attachment #1.2: Type: text/html, Size: 7617 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: add gem/gt TODO 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter ` (4 preceding siblings ...) (?) @ 2021-03-25 23:30 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-25 23:30 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30275 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895_full -> Patchwork_19850_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with Patchwork_19850_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19850_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_19850_full: ### IGT changes ### #### Warnings #### * igt@gem_exec_reloc@basic-many-active@vecs0: - shard-apl: [FAIL][1] ([i915#2389]) -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl2/igt@gem_exec_reloc@basic-many-active@vecs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl6/igt@gem_exec_reloc@basic-many-active@vecs0.html Known issues ------------ Here are the changes found in Patchwork_19850_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-snb5/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_eio@unwedge-stress: - shard-iclb: [PASS][4] -> [TIMEOUT][5] ([i915#2369] / [i915#2481] / [i915#3070]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb6/igt@gem_eio@unwedge-stress.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-deadline: - shard-kbl: [PASS][6] -> [FAIL][7] ([i915#2846]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl1/igt@gem_exec_fair@basic-deadline.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl4/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-iclb: NOTRUN -> [FAIL][10] ([i915#2842]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [PASS][11] -> [FAIL][12] ([i915#2842]) +2 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [PASS][13] -> [FAIL][14] ([i915#2849]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_fence@parallel@vecs0: - shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#118] / [i915#95]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk1/igt@gem_exec_fence@parallel@vecs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-glk3/igt@gem_exec_fence@parallel@vecs0.html * igt@gem_exec_params@no-bsd: - shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109283]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@gem_exec_params@no-bsd.html * igt@gem_exec_reloc@basic-parallel: - shard-kbl: NOTRUN -> [TIMEOUT][18] ([i915#3183]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@gem_exec_reloc@basic-parallel.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-snb: NOTRUN -> [FAIL][19] ([i915#2389]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-snb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html * igt@gem_mmap_gtt@cpuset-medium-copy-xy: - shard-iclb: [PASS][20] -> [FAIL][21] ([i915#2428]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb7/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb3/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html * igt@gem_mmap_gtt@medium-copy: - shard-skl: [PASS][22] -> [DMESG-WARN][23] ([i915#1982]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@gem_mmap_gtt@medium-copy.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@gem_mmap_gtt@medium-copy.html * igt@gem_pwrite@basic-exhaustion: - shard-skl: NOTRUN -> [WARN][24] ([i915#2658]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@gem_pwrite@basic-exhaustion.html * igt@gen7_exec_parse@basic-offset: - shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271]) +73 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl1/igt@gen7_exec_parse@basic-offset.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [PASS][26] -> [DMESG-WARN][27] ([i915#1436] / [i915#716]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk7/igt@gen9_exec_parse@allowed-single.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-glk5/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +305 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-snb5/igt@gen9_exec_parse@batch-invalid-length.html * igt@gen9_exec_parse@secure-batches: - shard-iclb: NOTRUN -> [SKIP][29] ([fdo#112306]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@gen9_exec_parse@secure-batches.html * igt@i915_pm_dc@dc6-dpms: - shard-skl: NOTRUN -> [FAIL][30] ([i915#454]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl6/igt@i915_pm_dc@dc6-dpms.html * igt@i915_selftest@mock@requests: - shard-skl: [PASS][31] -> [INCOMPLETE][32] ([i915#198]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl5/igt@i915_selftest@mock@requests.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl3/igt@i915_selftest@mock@requests.html * igt@kms_ccs@pipe-c-ccs-on-another-bo: - shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111304]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl6/igt@kms_ccs@pipe-c-ccs-on-another-bo.html * igt@kms_chamelium@dp-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +8 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl3/igt@kms_chamelium@dp-edid-change-during-suspend.html * igt@kms_chamelium@dp-hpd-storm: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109284] / [fdo#111827]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_chamelium@dp-hpd-storm.html * igt@kms_chamelium@hdmi-hpd-storm: - shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +9 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_chamelium@hdmi-hpd-storm.html * igt@kms_chamelium@hdmi-mode-timings: - shard-snb: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +20 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-snb7/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_color_chamelium@pipe-d-ctm-0-25: - shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +9 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@kms_color_chamelium@pipe-d-ctm-0-25.html * igt@kms_content_protection@legacy: - shard-kbl: NOTRUN -> [TIMEOUT][39] ([i915#1319]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_content_protection@legacy.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([i915#180]) +4 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen: - shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271]) +100 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl4/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html * igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278]) +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic: - shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109274] / [fdo#109278]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: NOTRUN -> [FAIL][45] ([i915#2346]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled: - shard-glk: [PASS][46] -> [FAIL][47] ([i915#52] / [i915#54]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-glk4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled: - shard-skl: NOTRUN -> [FAIL][48] ([i915#52] / [i915#54]) +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html * igt@kms_flip@2x-blocking-wf_vblank: - shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109274]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_flip@2x-blocking-wf_vblank.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-tglb: [PASS][50] -> [FAIL][51] ([i915#2598]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank@b-edp1: - shard-tglb: [PASS][52] -> [FAIL][53] ([i915#79]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: NOTRUN -> [DMESG-WARN][54] ([i915#180]) +2 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2672]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render: - shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109280]) +5 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu: - shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271]) +103 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: NOTRUN -> [FAIL][58] ([i915#1188]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_hdr@static-toggle-dpms: - shard-iclb: NOTRUN -> [SKIP][59] ([i915#1187]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_hdr@static-toggle-dpms.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#533]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d: - shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#533]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl7/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#533]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][63] ([fdo#108145] / [i915#265]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: NOTRUN -> [FAIL][64] ([fdo#108145] / [i915#265]) +2 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-kbl: NOTRUN -> [FAIL][65] ([fdo#108145] / [i915#265]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-kbl: NOTRUN -> [FAIL][66] ([i915#265]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][67] -> [FAIL][68] ([fdo#108145] / [i915#265]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_prime@basic-crc@first-to-second: - shard-iclb: NOTRUN -> [SKIP][69] ([i915#1836]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_prime@basic-crc@first-to-second.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4: - shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +2 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-3: - shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][73] -> [SKIP][74] ([fdo#109441]) +2 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-skl: [PASS][75] -> [INCOMPLETE][76] ([i915#198] / [i915#2828]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl8/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@kms_writeback@writeback-fb-id: - shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2437]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl6/igt@kms_writeback@writeback-fb-id.html * igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame: - shard-iclb: NOTRUN -> [SKIP][78] ([i915#2530]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html * igt@nouveau_crc@pipe-d-source-outp-inactive: - shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109278] / [i915#2530]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@nouveau_crc@pipe-d-source-outp-inactive.html * igt@prime_nv_api@i915_nv_import_vs_close: - shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109291]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@prime_nv_api@i915_nv_import_vs_close.html * igt@sysfs_clients@split-10: - shard-iclb: NOTRUN -> [SKIP][81] ([i915#2994]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@sysfs_clients@split-10.html * igt@sysfs_heartbeat_interval@mixed@vecs0: - shard-skl: [PASS][82] -> [FAIL][83] ([i915#1731]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl3/igt@sysfs_heartbeat_interval@mixed@vecs0.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl7/igt@sysfs_heartbeat_interval@mixed@vecs0.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-skl: [INCOMPLETE][84] ([i915#198]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@gem_ctx_isolation@preservation-s3@bcs0.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_eio@in-flight-10ms: - shard-skl: [TIMEOUT][86] ([i915#2502]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl8/igt@gem_eio@in-flight-10ms.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@gem_eio@in-flight-10ms.html * igt@gem_eio@in-flight-contexts-10ms: - shard-tglb: [TIMEOUT][88] ([i915#3063]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb8/igt@gem_eio@in-flight-contexts-10ms.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-tglb3/igt@gem_eio@in-flight-contexts-10ms.html * igt@gem_eio@in-flight-contexts-immediate: - shard-skl: [TIMEOUT][90] ([i915#3063]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl2/igt@gem_eio@in-flight-contexts-immediate.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl10/igt@gem_eio@in-flight-contexts-immediate.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][92] ([i915#2842]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][94] ([i915#2842]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs0.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-tglb: [FAIL][96] ([i915#2842]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-tglb8/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_exec_whisper@basic-queues-forked-all: - shard-iclb: [INCOMPLETE][98] -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb4/igt@gem_exec_whisper@basic-queues-forked-all.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@gem_exec_whisper@basic-queues-forked-all.html * igt@gem_mmap_gtt@cpuset-medium-copy-odd: - shard-iclb: [FAIL][100] ([i915#307]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][102] ([i915#1436] / [i915#716]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl4/igt@gen9_exec_parse@allowed-single.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@gen9_exec_parse@allowed-single.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - shard-skl: [DMESG-WARN][104] ([i915#1982]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][106] ([i915#79]) -> [PASS][107] [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [DMESG-WARN][108] ([i915#180]) -> [PASS][109] +3 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][110] ([fdo#108145] / [i915#265]) -> [PASS][111] [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][112] ([fdo#109441]) -> [PASS][113] +2 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][114] ([i915#1804] / [i915#2684]) -> [WARN][115] ([i915#2684]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][116] ([i915#2684]) -> [WARN][117] ([i915#2681] / [i915#2684]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][118] ([i915#1226]) -> [SKIP][119] ([fdo#109349]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][120] ([i915#658]) -> [SKIP][121] ([i915#2920]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb4/igt@kms_psr2_sf@cursor-plane-update-sf.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2: - shard-iclb: [SKIP][122] ([i915#2920]) -> [SKIP][123] ([i915#658]) +2 similar issues [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-iclb5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html * igt@runner@aborted: - shard-kbl: ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#602]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl4/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl2/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl7/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl4/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl3/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl3/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl7/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl4/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl6/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl4/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-kbl3/igt@runner@aborted.html - shard-apl: ([FAIL][142], [FAIL][143], [FAIL][144]) ([i915#180] / [i915#3002]) -> ([FAIL][145], [FAIL][146]) ([i915#3002]) [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl3/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl8/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl1/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl6/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/shard-apl7/igt@runner@aborted.html - shard-skl: ([FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#3002]) -> ([FAIL][152], [FAIL][153], [FAIL][154]) ([i915#2029] / [i915#3002]) [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl2/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl4/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl3/igt@runner@aborted.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@runner@aborted.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl3/igt@runner@aborted.html [152]: https://intel-gfx-ci.01.org/tree/drm-tip/ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19850/index.html [-- Attachment #1.2: Type: text/html, Size: 33755 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: add gem/gt TODO (rev2) 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter ` (5 preceding siblings ...) (?) @ 2021-03-26 3:08 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-26 3:08 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO (rev2) URL : https://patchwork.freedesktop.org/series/88413/ State : warning == Summary == $ dim checkpatch origin/drm-tip b464c5f5f3bc drm/i915: add gem/gt TODO -:41: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 -:86: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>' total: 0 errors, 2 warnings, 0 checks, 41 lines checked 388cc65f0378 drm/doc: Add RFC section -:40: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 -:45: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #45: FILE: Documentation/gpu/rfc/index.rst:1: +=============== -:61: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>' total: 0 errors, 3 warnings, 0 checks, 24 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: add gem/gt TODO (rev2) 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter ` (6 preceding siblings ...) (?) @ 2021-03-26 3:13 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-26 3:13 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO (rev2) URL : https://patchwork.freedesktop.org/series/88413/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: add gem/gt TODO (rev2) 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter ` (7 preceding siblings ...) (?) @ 2021-03-26 3:38 ` Patchwork -1 siblings, 0 replies; 26+ messages in thread From: Patchwork @ 2021-03-26 3:38 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 4510 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO (rev2) URL : https://patchwork.freedesktop.org/series/88413/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9899 -> Patchwork_19862 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_19862 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19862, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_19862: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@hangcheck: - fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9899/fi-byt-j1900/igt@i915_selftest@live@hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-byt-j1900/igt@i915_selftest@live@hangcheck.html Known issues ------------ Here are the changes found in Patchwork_19862 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [PASS][3] -> [FAIL][4] ([i915#1888]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9899/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html * igt@runner@aborted: - fi-bdw-5557u: NOTRUN -> [FAIL][5] ([i915#1602] / [i915#2029]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-bdw-5557u/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [FAIL][6] ([i915#1888]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9899/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [DMESG-WARN][8] ([i915#2411] / [i915#402]) -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9899/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@gem_flink_basic@bad-flink: - fi-tgl-y: [DMESG-WARN][10] ([i915#402]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9899/fi-tgl-y/igt@gem_flink_basic@bad-flink.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-tgl-y/igt@gem_flink_basic@bad-flink.html #### Warnings #### * igt@i915_module_load@reload: - fi-glk-dsi: [DMESG-WARN][12] ([i915#1982] / [i915#3143]) -> [DMESG-WARN][13] ([i915#3143]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9899/fi-glk-dsi/igt@i915_module_load@reload.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/fi-glk-dsi/igt@i915_module_load@reload.html [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#3143]: https://gitlab.freedesktop.org/drm/intel/issues/3143 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (47 -> 42) ------------------------------ Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-icl-y fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9899 -> Patchwork_19862 CI-20190529: 20190529 CI_DRM_9899: 3b48e00d3cf62357e91039d136810ddeaea09886 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6046: e76039273b1524147c43dba061756f06003d56ae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19862: 388cc65f0378c92eab22392fd2c246c7fb208c02 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 388cc65f0378 drm/doc: Add RFC section b464c5f5f3bc drm/i915: add gem/gt TODO == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19862/index.html [-- Attachment #1.2: Type: text/html, Size: 5489 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 1/2] drm/i915: add gem/gt TODO @ 2021-03-23 8:44 Daniel Vetter 2021-03-23 10:13 ` Jani Nikula 2021-03-23 13:17 ` Daniel Vetter 0 siblings, 2 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-23 8:44 UTC (permalink / raw) To: DRI Development, Intel Graphics Development Cc: Daniel Vetter, Daniel Vetter, Jason Ekstrand, Rodrigo Vivi, Dave Airlie We've discussed a bit how to get the gem/gt team better integrated and collaborate more with the wider community and agreed to the following: - all gem/gt patches are reviewed on dri-devel for now. That's overkill, but in the past there was definitely too little of that. - i915-gem folks are encouraged to cross review core patches from other teams - big features (especially uapi changes) need to be discussed in an rfc patch that documents the interface and big picture design, before we get lost in the details of the code - Also a rough TODO (can be refined as we go ofc) to get gem/gt back on track, like we've e.g. done with DAL/DC to get that in shape. Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> Cc: Dave Airlie <airlied@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 drivers/gpu/drm/i915/TODO.txt diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt new file mode 100644 index 000000000000..d2e5bbb6339d --- /dev/null +++ b/drivers/gpu/drm/i915/TODO.txt @@ -0,0 +1,36 @@ +gem/gt TODO items +----------------- + +- For discrete memory manager, merge enough dg1 to be able to refactor it to + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has + improved a lot the past 2 years, there's no reason anymore not to use it. + +- Come up with a plan what to do with drm/scheduler and how to get there. + +- There's a lot of complexity added past few years to make relocations faster. + That doesn't make sense given hw and gpu apis moved away from this model years + ago: + 1. Land a modern pre-bound uapi like VM_BIND + 2. Any complexity added in this area past few years which can't be justified + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on + the bo and vm, plus some lru locks is all that needed. No complex rcu, + refcounts, caching, ... on everything. + This is the matching task on the vm side compared to ttm/dma_resv on the + backing storage side. + +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. + How-to-dma_fence is core and drivers really shouldn't build their own world + here, treating everything else as a fixed platform. i915_sw_fence concepts + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or + removed if dri-devel consensus is that it's not a good idea. Once that's done + maybe even remove it if there's nothing left. + +Smaller things: +- i915_utils.h needs to be moved to the right places. + +- dma_fence_work should be in drivers/dma-buf + +- i915_mm.c should be moved to the right places. Some of the helpers also look a + bit fishy: + + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ -- 2.31.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/i915: add gem/gt TODO 2021-03-23 8:44 [PATCH 1/2] drm/i915: add gem/gt TODO Daniel Vetter @ 2021-03-23 10:13 ` Jani Nikula 2021-03-23 11:57 ` Daniel Vetter 2021-03-23 13:17 ` Daniel Vetter 1 sibling, 1 reply; 26+ messages in thread From: Jani Nikula @ 2021-03-23 10:13 UTC (permalink / raw) To: Daniel Vetter, DRI Development, Intel Graphics Development Cc: Daniel Vetter, Rodrigo Vivi, Jason Ekstrand, Dave Airlie, Daniel Vetter On Tue, 23 Mar 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > We've discussed a bit how to get the gem/gt team better integrated > and collaborate more with the wider community and agreed to the > following: > > - all gem/gt patches are reviewed on dri-devel for now. That's > overkill, but in the past there was definitely too little of that. > > - i915-gem folks are encouraged to cross review core patches from > other teams > > - big features (especially uapi changes) need to be discussed in an > rfc patch that documents the interface and big picture design, > before we get lost in the details of the code > > - Also a rough TODO (can be refined as we go ofc) to get gem/gt back > on track, like we've e.g. done with DAL/DC to get that in shape. I personally think there should be a lower bar for discussing and editing the TODO items than via patches on the mailing list. Granted, the TODO file enforces the discussion happens at a large enough audience, but for at least some of the items I'd suggest filing gitlab issues [1], with todo label, and tracking there. BR, Jani. [1] https://gitlab.freedesktop.org/drm/intel/-/issues > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > Cc: Dave Airlie <airlied@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 drivers/gpu/drm/i915/TODO.txt > > diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt > new file mode 100644 > index 000000000000..d2e5bbb6339d > --- /dev/null > +++ b/drivers/gpu/drm/i915/TODO.txt > @@ -0,0 +1,36 @@ > +gem/gt TODO items > +----------------- > + > +- For discrete memory manager, merge enough dg1 to be able to refactor it to > + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has > + improved a lot the past 2 years, there's no reason anymore not to use it. > + > +- Come up with a plan what to do with drm/scheduler and how to get there. > + > +- There's a lot of complexity added past few years to make relocations faster. > + That doesn't make sense given hw and gpu apis moved away from this model years > + ago: > + 1. Land a modern pre-bound uapi like VM_BIND > + 2. Any complexity added in this area past few years which can't be justified > + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on > + the bo and vm, plus some lru locks is all that needed. No complex rcu, > + refcounts, caching, ... on everything. > + This is the matching task on the vm side compared to ttm/dma_resv on the > + backing storage side. > + > +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. > + How-to-dma_fence is core and drivers really shouldn't build their own world > + here, treating everything else as a fixed platform. i915_sw_fence concepts > + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or > + removed if dri-devel consensus is that it's not a good idea. Once that's done > + maybe even remove it if there's nothing left. > + > +Smaller things: > +- i915_utils.h needs to be moved to the right places. > + > +- dma_fence_work should be in drivers/dma-buf > + > +- i915_mm.c should be moved to the right places. Some of the helpers also look a > + bit fishy: > + > + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/i915: add gem/gt TODO 2021-03-23 10:13 ` Jani Nikula @ 2021-03-23 11:57 ` Daniel Vetter 2021-03-23 12:34 ` Rodrigo Vivi 0 siblings, 1 reply; 26+ messages in thread From: Daniel Vetter @ 2021-03-23 11:57 UTC (permalink / raw) To: Jani Nikula Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, DRI Development, Jason Ekstrand, Rodrigo Vivi, Dave Airlie On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > On Tue, 23 Mar 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > We've discussed a bit how to get the gem/gt team better integrated > > and collaborate more with the wider community and agreed to the > > following: > > > > - all gem/gt patches are reviewed on dri-devel for now. That's > > overkill, but in the past there was definitely too little of that. > > > > - i915-gem folks are encouraged to cross review core patches from > > other teams > > > > - big features (especially uapi changes) need to be discussed in an > > rfc patch that documents the interface and big picture design, > > before we get lost in the details of the code > > > > - Also a rough TODO (can be refined as we go ofc) to get gem/gt back > > on track, like we've e.g. done with DAL/DC to get that in shape. > > I personally think there should be a lower bar for discussing and > editing the TODO items than via patches on the mailing list. Granted, > the TODO file enforces the discussion happens at a large enough > audience, but for at least some of the items I'd suggest filing gitlab > issues [1], with todo label, and tracking there. In general yes, and I'd go even further: it's up to each team/contributor how they track review feedback and further work, whether that's gitlab or some notes or just in their heads. This is a different situation here, and the "changes require big audience" is a feature, not a bug. But it is a very exceptional situation, I think this is only the 2nd time we're using a formal TODO for a gpu driver. If we ignore gma500 in staging, which for me only showed that the separate staging tree doesn't work so well for complex drivers like we have. -Daniel > > BR, > Jani. > > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues > > > > > > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > Cc: Dave Airlie <airlied@redhat.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > --- > > drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 drivers/gpu/drm/i915/TODO.txt > > > > diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt > > new file mode 100644 > > index 000000000000..d2e5bbb6339d > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/TODO.txt > > @@ -0,0 +1,36 @@ > > +gem/gt TODO items > > +----------------- > > + > > +- For discrete memory manager, merge enough dg1 to be able to refactor it to > > + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has > > + improved a lot the past 2 years, there's no reason anymore not to use it. > > + > > +- Come up with a plan what to do with drm/scheduler and how to get there. > > + > > +- There's a lot of complexity added past few years to make relocations faster. > > + That doesn't make sense given hw and gpu apis moved away from this model years > > + ago: > > + 1. Land a modern pre-bound uapi like VM_BIND > > + 2. Any complexity added in this area past few years which can't be justified > > + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on > > + the bo and vm, plus some lru locks is all that needed. No complex rcu, > > + refcounts, caching, ... on everything. > > + This is the matching task on the vm side compared to ttm/dma_resv on the > > + backing storage side. > > + > > +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. > > + How-to-dma_fence is core and drivers really shouldn't build their own world > > + here, treating everything else as a fixed platform. i915_sw_fence concepts > > + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or > > + removed if dri-devel consensus is that it's not a good idea. Once that's done > > + maybe even remove it if there's nothing left. > > + > > +Smaller things: > > +- i915_utils.h needs to be moved to the right places. > > + > > +- dma_fence_work should be in drivers/dma-buf > > + > > +- i915_mm.c should be moved to the right places. Some of the helpers also look a > > + bit fishy: > > + > > + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/i915: add gem/gt TODO 2021-03-23 11:57 ` Daniel Vetter @ 2021-03-23 12:34 ` Rodrigo Vivi 2021-03-23 13:18 ` Daniel Vetter 0 siblings, 1 reply; 26+ messages in thread From: Rodrigo Vivi @ 2021-03-23 12:34 UTC (permalink / raw) To: Daniel Vetter Cc: Daniel Vetter, Intel Graphics Development, DRI Development, Jason Ekstrand, Daniel Vetter, Dave Airlie On Tue, Mar 23, 2021 at 12:57:39PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > > On Tue, 23 Mar 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > We've discussed a bit how to get the gem/gt team better integrated > > > and collaborate more with the wider community and agreed to the > > > following: > > > > > > - all gem/gt patches are reviewed on dri-devel for now. That's > > > overkill, but in the past there was definitely too little of that. > > > > > > - i915-gem folks are encouraged to cross review core patches from > > > other teams > > > > > > - big features (especially uapi changes) need to be discussed in an > > > rfc patch that documents the interface and big picture design, > > > before we get lost in the details of the code > > > > > > - Also a rough TODO (can be refined as we go ofc) to get gem/gt back > > > on track, like we've e.g. done with DAL/DC to get that in shape. > > > > I personally think there should be a lower bar for discussing and > > editing the TODO items than via patches on the mailing list. Granted, > > the TODO file enforces the discussion happens at a large enough > > audience, but for at least some of the items I'd suggest filing gitlab > > issues [1], with todo label, and tracking there. I also don't like the todo list in files and I agree that gitlab issues section should be better... > In general yes, and I'd go even further: it's up to each team/contributor > how they track review feedback and further work, whether that's gitlab or > some notes or just in their heads. > > This is a different situation here, and the "changes require big audience" > is a feature, not a bug. But it is a very exceptional situation, I think > this is only the 2nd time we're using a formal TODO for a gpu driver. If > we ignore gma500 in staging, which for me only showed that the separate > staging tree doesn't work so well for complex drivers like we have. ... but I understand the motivation, so Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> However... what about: 1. moving the smaller items to gitlab at least? 2. having both, all the entries in the todo file have gitlab issue associated and the number-id is also here in the todo file? > -Daniel > > > > > BR, > > Jani. > > > > > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues > > > > > > > > > > > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > > Cc: Dave Airlie <airlied@redhat.com> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > --- > > > drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > create mode 100644 drivers/gpu/drm/i915/TODO.txt > > > > > > diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt > > > new file mode 100644 > > > index 000000000000..d2e5bbb6339d > > > --- /dev/null > > > +++ b/drivers/gpu/drm/i915/TODO.txt > > > @@ -0,0 +1,36 @@ > > > +gem/gt TODO items > > > +----------------- > > > + > > > +- For discrete memory manager, merge enough dg1 to be able to refactor it to > > > + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has > > > + improved a lot the past 2 years, there's no reason anymore not to use it. > > > + > > > +- Come up with a plan what to do with drm/scheduler and how to get there. > > > + > > > +- There's a lot of complexity added past few years to make relocations faster. > > > + That doesn't make sense given hw and gpu apis moved away from this model years > > > + ago: > > > + 1. Land a modern pre-bound uapi like VM_BIND > > > + 2. Any complexity added in this area past few years which can't be justified > > > + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on > > > + the bo and vm, plus some lru locks is all that needed. No complex rcu, > > > + refcounts, caching, ... on everything. > > > + This is the matching task on the vm side compared to ttm/dma_resv on the > > > + backing storage side. > > > + > > > +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. > > > + How-to-dma_fence is core and drivers really shouldn't build their own world > > > + here, treating everything else as a fixed platform. i915_sw_fence concepts > > > + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or > > > + removed if dri-devel consensus is that it's not a good idea. Once that's done > > > + maybe even remove it if there's nothing left. > > > + > > > +Smaller things: > > > +- i915_utils.h needs to be moved to the right places. > > > + > > > +- dma_fence_work should be in drivers/dma-buf > > > + > > > +- i915_mm.c should be moved to the right places. Some of the helpers also look a > > > + bit fishy: > > > + > > > + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ > > > > -- > > Jani Nikula, Intel Open Source Graphics Center > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/i915: add gem/gt TODO 2021-03-23 12:34 ` Rodrigo Vivi @ 2021-03-23 13:18 ` Daniel Vetter 2021-03-23 18:07 ` Jason Ekstrand 0 siblings, 1 reply; 26+ messages in thread From: Daniel Vetter @ 2021-03-23 13:18 UTC (permalink / raw) To: Rodrigo Vivi Cc: Jason Ekstrand, Daniel Vetter, Intel Graphics Development, DRI Development, Daniel Vetter, Dave Airlie On Tue, Mar 23, 2021 at 08:34:55AM -0400, Rodrigo Vivi wrote: > On Tue, Mar 23, 2021 at 12:57:39PM +0100, Daniel Vetter wrote: > > On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > > > On Tue, 23 Mar 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > > We've discussed a bit how to get the gem/gt team better integrated > > > > and collaborate more with the wider community and agreed to the > > > > following: > > > > > > > > - all gem/gt patches are reviewed on dri-devel for now. That's > > > > overkill, but in the past there was definitely too little of that. > > > > > > > > - i915-gem folks are encouraged to cross review core patches from > > > > other teams > > > > > > > > - big features (especially uapi changes) need to be discussed in an > > > > rfc patch that documents the interface and big picture design, > > > > before we get lost in the details of the code > > > > > > > > - Also a rough TODO (can be refined as we go ofc) to get gem/gt back > > > > on track, like we've e.g. done with DAL/DC to get that in shape. > > > > > > I personally think there should be a lower bar for discussing and > > > editing the TODO items than via patches on the mailing list. Granted, > > > the TODO file enforces the discussion happens at a large enough > > > audience, but for at least some of the items I'd suggest filing gitlab > > > issues [1], with todo label, and tracking there. > > I also don't like the todo list in files and I agree that gitlab issues > section should be better... > > > In general yes, and I'd go even further: it's up to each team/contributor > > how they track review feedback and further work, whether that's gitlab or > > some notes or just in their heads. > > > > This is a different situation here, and the "changes require big audience" > > is a feature, not a bug. But it is a very exceptional situation, I think > > this is only the 2nd time we're using a formal TODO for a gpu driver. If > > we ignore gma500 in staging, which for me only showed that the separate > > staging tree doesn't work so well for complex drivers like we have. > > ... but I understand the motivation, so > > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > However... what about: > > 1. moving the smaller items to gitlab at least? > 2. having both, all the entries in the todo file have gitlab issue > associated and the number-id is also here in the todo file? Yeah that sounds reasonable. tbh we haven't started any of the intel-internal planning on most of these (ttm and scheduler are started), so none of these tracking things exist yet at all ... -Daniel > > > -Daniel > > > > > > > > BR, > > > Jani. > > > > > > > > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues > > > > > > > > > > > > > > > > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > > > Cc: Dave Airlie <airlied@redhat.com> > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 36 insertions(+) > > > > create mode 100644 drivers/gpu/drm/i915/TODO.txt > > > > > > > > diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt > > > > new file mode 100644 > > > > index 000000000000..d2e5bbb6339d > > > > --- /dev/null > > > > +++ b/drivers/gpu/drm/i915/TODO.txt > > > > @@ -0,0 +1,36 @@ > > > > +gem/gt TODO items > > > > +----------------- > > > > + > > > > +- For discrete memory manager, merge enough dg1 to be able to refactor it to > > > > + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has > > > > + improved a lot the past 2 years, there's no reason anymore not to use it. > > > > + > > > > +- Come up with a plan what to do with drm/scheduler and how to get there. > > > > + > > > > +- There's a lot of complexity added past few years to make relocations faster. > > > > + That doesn't make sense given hw and gpu apis moved away from this model years > > > > + ago: > > > > + 1. Land a modern pre-bound uapi like VM_BIND > > > > + 2. Any complexity added in this area past few years which can't be justified > > > > + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on > > > > + the bo and vm, plus some lru locks is all that needed. No complex rcu, > > > > + refcounts, caching, ... on everything. > > > > + This is the matching task on the vm side compared to ttm/dma_resv on the > > > > + backing storage side. > > > > + > > > > +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. > > > > + How-to-dma_fence is core and drivers really shouldn't build their own world > > > > + here, treating everything else as a fixed platform. i915_sw_fence concepts > > > > + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or > > > > + removed if dri-devel consensus is that it's not a good idea. Once that's done > > > > + maybe even remove it if there's nothing left. > > > > + > > > > +Smaller things: > > > > +- i915_utils.h needs to be moved to the right places. > > > > + > > > > +- dma_fence_work should be in drivers/dma-buf > > > > + > > > > +- i915_mm.c should be moved to the right places. Some of the helpers also look a > > > > + bit fishy: > > > > + > > > > + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ > > > > > > -- > > > Jani Nikula, Intel Open Source Graphics Center > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/i915: add gem/gt TODO 2021-03-23 13:18 ` Daniel Vetter @ 2021-03-23 18:07 ` Jason Ekstrand 0 siblings, 0 replies; 26+ messages in thread From: Jason Ekstrand @ 2021-03-23 18:07 UTC (permalink / raw) To: Daniel Vetter Cc: Daniel Vetter, Daniel Vetter, Intel Graphics Development, DRI Development, Rodrigo Vivi, Dave Airlie On Tue, Mar 23, 2021 at 8:18 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Tue, Mar 23, 2021 at 08:34:55AM -0400, Rodrigo Vivi wrote: > > On Tue, Mar 23, 2021 at 12:57:39PM +0100, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 12:13:11PM +0200, Jani Nikula wrote: > > > > On Tue, 23 Mar 2021, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > > > We've discussed a bit how to get the gem/gt team better integrated > > > > > and collaborate more with the wider community and agreed to the > > > > > following: > > > > > > > > > > - all gem/gt patches are reviewed on dri-devel for now. That's > > > > > overkill, but in the past there was definitely too little of that. > > > > > > > > > > - i915-gem folks are encouraged to cross review core patches from > > > > > other teams > > > > > > > > > > - big features (especially uapi changes) need to be discussed in an > > > > > rfc patch that documents the interface and big picture design, > > > > > before we get lost in the details of the code > > > > > > > > > > - Also a rough TODO (can be refined as we go ofc) to get gem/gt back > > > > > on track, like we've e.g. done with DAL/DC to get that in shape. > > > > > > > > I personally think there should be a lower bar for discussing and > > > > editing the TODO items than via patches on the mailing list. Granted, > > > > the TODO file enforces the discussion happens at a large enough > > > > audience, but for at least some of the items I'd suggest filing gitlab > > > > issues [1], with todo label, and tracking there. > > > > I also don't like the todo list in files and I agree that gitlab issues > > section should be better... > > > > > In general yes, and I'd go even further: it's up to each team/contributor > > > how they track review feedback and further work, whether that's gitlab or > > > some notes or just in their heads. > > > > > > This is a different situation here, and the "changes require big audience" > > > is a feature, not a bug. But it is a very exceptional situation, I think > > > this is only the 2nd time we're using a formal TODO for a gpu driver. If > > > we ignore gma500 in staging, which for me only showed that the separate > > > staging tree doesn't work so well for complex drivers like we have. > > > > ... but I understand the motivation, so > > > > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > However... what about: > > > > 1. moving the smaller items to gitlab at least? > > 2. having both, all the entries in the todo file have gitlab issue > > associated and the number-id is also here in the todo file? > > Yeah that sounds reasonable. tbh we haven't started any of the > intel-internal planning on most of these (ttm and scheduler are started), > so none of these tracking things exist yet at all ... I'm a fan of this. GitLab issues provide a good place to organize the chatter on any particular ToDo item. I'd also rather see people chattering about this stuff on public GitLab than JIRA, when possible. The last patch in the series closing out a ToDo can be a patch to this file to remove the bullet point. --Jason > -Daniel > > > > > > -Daniel > > > > > > > > > > > BR, > > > > Jani. > > > > > > > > > > > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues > > > > > > > > > > > > > > > > > > > > > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > > > > Cc: Dave Airlie <airlied@redhat.com> > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > > > --- > > > > > drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 36 insertions(+) > > > > > create mode 100644 drivers/gpu/drm/i915/TODO.txt > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt > > > > > new file mode 100644 > > > > > index 000000000000..d2e5bbb6339d > > > > > --- /dev/null > > > > > +++ b/drivers/gpu/drm/i915/TODO.txt > > > > > @@ -0,0 +1,36 @@ > > > > > +gem/gt TODO items > > > > > +----------------- > > > > > + > > > > > +- For discrete memory manager, merge enough dg1 to be able to refactor it to > > > > > + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has > > > > > + improved a lot the past 2 years, there's no reason anymore not to use it. > > > > > + > > > > > +- Come up with a plan what to do with drm/scheduler and how to get there. > > > > > + > > > > > +- There's a lot of complexity added past few years to make relocations faster. > > > > > + That doesn't make sense given hw and gpu apis moved away from this model years > > > > > + ago: > > > > > + 1. Land a modern pre-bound uapi like VM_BIND > > > > > + 2. Any complexity added in this area past few years which can't be justified > > > > > + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on > > > > > + the bo and vm, plus some lru locks is all that needed. No complex rcu, > > > > > + refcounts, caching, ... on everything. > > > > > + This is the matching task on the vm side compared to ttm/dma_resv on the > > > > > + backing storage side. > > > > > + > > > > > +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. > > > > > + How-to-dma_fence is core and drivers really shouldn't build their own world > > > > > + here, treating everything else as a fixed platform. i915_sw_fence concepts > > > > > + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or > > > > > + removed if dri-devel consensus is that it's not a good idea. Once that's done > > > > > + maybe even remove it if there's nothing left. > > > > > + > > > > > +Smaller things: > > > > > +- i915_utils.h needs to be moved to the right places. > > > > > + > > > > > +- dma_fence_work should be in drivers/dma-buf > > > > > + > > > > > +- i915_mm.c should be moved to the right places. Some of the helpers also look a > > > > > + bit fishy: > > > > > + > > > > > + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ > > > > > > > > -- > > > > Jani Nikula, Intel Open Source Graphics Center > > > > > > -- > > > Daniel Vetter > > > Software Engineer, Intel Corporation > > > http://blog.ffwll.ch > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/i915: add gem/gt TODO 2021-03-23 8:44 [PATCH 1/2] drm/i915: add gem/gt TODO Daniel Vetter 2021-03-23 10:13 ` Jani Nikula @ 2021-03-23 13:17 ` Daniel Vetter 1 sibling, 0 replies; 26+ messages in thread From: Daniel Vetter @ 2021-03-23 13:17 UTC (permalink / raw) To: DRI Development, Intel Graphics Development Cc: Daniel Vetter, Daniel Vetter, Jason Ekstrand, Rodrigo Vivi, Dave Airlie On Tue, Mar 23, 2021 at 09:44:52AM +0100, Daniel Vetter wrote: > We've discussed a bit how to get the gem/gt team better integrated > and collaborate more with the wider community and agreed to the > following: > > - all gem/gt patches are reviewed on dri-devel for now. That's > overkill, but in the past there was definitely too little of that. > > - i915-gem folks are encouraged to cross review core patches from > other teams > > - big features (especially uapi changes) need to be discussed in an > rfc patch that documents the interface and big picture design, > before we get lost in the details of the code > > - Also a rough TODO (can be refined as we go ofc) to get gem/gt back > on track, like we've e.g. done with DAL/DC to get that in shape. > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> > Cc: Dave Airlie <airlied@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > drivers/gpu/drm/i915/TODO.txt | 36 +++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 drivers/gpu/drm/i915/TODO.txt > > diff --git a/drivers/gpu/drm/i915/TODO.txt b/drivers/gpu/drm/i915/TODO.txt > new file mode 100644 > index 000000000000..d2e5bbb6339d > --- /dev/null > +++ b/drivers/gpu/drm/i915/TODO.txt > @@ -0,0 +1,36 @@ > +gem/gt TODO items > +----------------- > + > +- For discrete memory manager, merge enough dg1 to be able to refactor it to > + TTM. Then land pci ids (just in case that turns up an uapi problem). TTM has > + improved a lot the past 2 years, there's no reason anymore not to use it. > + > +- Come up with a plan what to do with drm/scheduler and how to get there. > + > +- There's a lot of complexity added past few years to make relocations faster. > + That doesn't make sense given hw and gpu apis moved away from this model years > + ago: > + 1. Land a modern pre-bound uapi like VM_BIND > + 2. Any complexity added in this area past few years which can't be justified > + with VM_BIND using userspace should be removed. Looking at amdgpu dma_resv on > + the bo and vm, plus some lru locks is all that needed. No complex rcu, > + refcounts, caching, ... on everything. > + This is the matching task on the vm side compared to ttm/dma_resv on the > + backing storage side. > + > +- i915_sw_fence seems to be the main structure for the i915-gem dma_fence model. > + How-to-dma_fence is core and drivers really shouldn't build their own world > + here, treating everything else as a fixed platform. i915_sw_fence concepts > + should be moved to dma_fence, drm/scheduler or atomic commit helpers. Or > + removed if dri-devel consensus is that it's not a good idea. Once that's done > + maybe even remove it if there's nothing left. > + > +Smaller things: > +- i915_utils.h needs to be moved to the right places. > + > +- dma_fence_work should be in drivers/dma-buf > + > +- i915_mm.c should be moved to the right places. Some of the helpers also look a > + bit fishy: > + > + https://lore.kernel.org/linux-mm/20210301083320.943079-1-hch@lst.de/ Jani just pointed me at another small helper that we should look at: - tasklet helpers in i915_gem.h also look a bit misplaced and should probably be moved to tasklet headers. Spotted through https://lore.kernel.org/lkml/20210323092221.awq7g5b2muzypjw3@flow/ I'll add that one in v2. There is also the i915 ww locking context helpers from Maarten in there, but right now those truly are i915 specific. Plus as part of the ttm conversion they're already on the list of things we have to move. So I think redundant to add the entire file. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2021-03-26 8:25 UTC | newest] Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-24 21:10 [PATCH 1/2] drm/i915: add gem/gt TODO Daniel Vetter 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter 2021-03-24 21:10 ` [PATCH 2/2] drm/doc: Add RFC section Daniel Vetter 2021-03-24 21:10 ` [Intel-gfx] " Daniel Vetter 2021-03-25 2:37 ` Jason Ekstrand 2021-03-25 2:37 ` [Intel-gfx] " Jason Ekstrand 2021-03-25 9:41 ` Simon Ser 2021-03-25 9:41 ` [Intel-gfx] " Simon Ser 2021-03-25 22:58 ` [PATCH] " Daniel Vetter 2021-03-25 22:58 ` [Intel-gfx] " Daniel Vetter 2021-03-26 8:25 ` Daniel Vetter 2021-03-26 8:25 ` [Intel-gfx] " Daniel Vetter 2021-03-25 18:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: add gem/gt TODO Patchwork 2021-03-25 18:29 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2021-03-25 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-03-25 23:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-03-26 3:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: add gem/gt TODO (rev2) Patchwork 2021-03-26 3:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2021-03-26 3:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-03-23 8:44 [PATCH 1/2] drm/i915: add gem/gt TODO Daniel Vetter 2021-03-23 10:13 ` Jani Nikula 2021-03-23 11:57 ` Daniel Vetter 2021-03-23 12:34 ` Rodrigo Vivi 2021-03-23 13:18 ` Daniel Vetter 2021-03-23 18:07 ` Jason Ekstrand 2021-03-23 13:17 ` Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.