* [PATCH net] amd-xgbe: Update DMA coherency values
@ 2021-03-25 3:09 Shyam Sundar S K
2021-03-25 13:51 ` Tom Lendacky
2021-03-26 0:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Shyam Sundar S K @ 2021-03-25 3:09 UTC (permalink / raw)
To: Tom Lendacky, David S . Miller, Jakub Kicinski, netdev; +Cc: Shyam Sundar S K
Based on the IOMMU configuration, the current cache control settings can
result in possible coherency issues. The hardware team has recommended
new settings for the PCI device path to eliminate the issue.
Fixes: 6f595959c095 ("amd-xgbe: Adjust register settings to improve performance")
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
Please queue this patch up for stable, 4.14 and higher.
drivers/net/ethernet/amd/xgbe/xgbe.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/amd/xgbe/xgbe.h
index ba8321ec1ee7..3305979a9f7c 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe.h
+++ b/drivers/net/ethernet/amd/xgbe/xgbe.h
@@ -180,9 +180,9 @@
#define XGBE_DMA_SYS_AWCR 0x30303030
/* DMA cache settings - PCI device */
-#define XGBE_DMA_PCI_ARCR 0x00000003
-#define XGBE_DMA_PCI_AWCR 0x13131313
-#define XGBE_DMA_PCI_AWARCR 0x00000313
+#define XGBE_DMA_PCI_ARCR 0x000f0f0f
+#define XGBE_DMA_PCI_AWCR 0x0f0f0f0f
+#define XGBE_DMA_PCI_AWARCR 0x00000f0f
/* DMA channel interrupt modes */
#define XGBE_IRQ_MODE_EDGE 0
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] amd-xgbe: Update DMA coherency values
2021-03-25 3:09 [PATCH net] amd-xgbe: Update DMA coherency values Shyam Sundar S K
@ 2021-03-25 13:51 ` Tom Lendacky
2021-03-26 0:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Tom Lendacky @ 2021-03-25 13:51 UTC (permalink / raw)
To: Shyam Sundar S K, David S . Miller, Jakub Kicinski, netdev
On 3/24/21 10:09 PM, Shyam Sundar S K wrote:
> Based on the IOMMU configuration, the current cache control settings can
> result in possible coherency issues. The hardware team has recommended
> new settings for the PCI device path to eliminate the issue.
>
> Fixes: 6f595959c095 ("amd-xgbe: Adjust register settings to improve performance")
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>
> Please queue this patch up for stable, 4.14 and higher.
>
> drivers/net/ethernet/amd/xgbe/xgbe.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/amd/xgbe/xgbe.h
> index ba8321ec1ee7..3305979a9f7c 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe.h
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h
> @@ -180,9 +180,9 @@
> #define XGBE_DMA_SYS_AWCR 0x30303030
>
> /* DMA cache settings - PCI device */
> -#define XGBE_DMA_PCI_ARCR 0x00000003
> -#define XGBE_DMA_PCI_AWCR 0x13131313
> -#define XGBE_DMA_PCI_AWARCR 0x00000313
> +#define XGBE_DMA_PCI_ARCR 0x000f0f0f
> +#define XGBE_DMA_PCI_AWCR 0x0f0f0f0f
> +#define XGBE_DMA_PCI_AWARCR 0x00000f0f
>
> /* DMA channel interrupt modes */
> #define XGBE_IRQ_MODE_EDGE 0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] amd-xgbe: Update DMA coherency values
2021-03-25 3:09 [PATCH net] amd-xgbe: Update DMA coherency values Shyam Sundar S K
2021-03-25 13:51 ` Tom Lendacky
@ 2021-03-26 0:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-26 0:30 UTC (permalink / raw)
To: Shyam Sundar S K; +Cc: thomas.lendacky, davem, kuba, netdev
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 25 Mar 2021 08:39:12 +0530 you wrote:
> Based on the IOMMU configuration, the current cache control settings can
> result in possible coherency issues. The hardware team has recommended
> new settings for the PCI device path to eliminate the issue.
>
> Fixes: 6f595959c095 ("amd-xgbe: Adjust register settings to improve performance")
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>
> [...]
Here is the summary with links:
- [net] amd-xgbe: Update DMA coherency values
https://git.kernel.org/netdev/net/c/d75135082698
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 3:09 [PATCH net] amd-xgbe: Update DMA coherency values Shyam Sundar S K
2021-03-25 13:51 ` Tom Lendacky
2021-03-26 0:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.