[PATCH] arch: mips: fix unmet dependency for MTD_COMPLEX_MAPPINGS

[PATCH] arch: mips: fix unmet dependency for MTD_COMPLEX_MAPPINGS

[Julian Braha]

When CAVIUM_OCTEON_SOC is enabled, and MTD is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
  Depends on [n]: MTD [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - CAVIUM_OCTEON_SOC [=y] && <choice>

This is because CAVIUM_OCTEON_SOC selects MTD_COMPLEX_MAPPINGS,
without selecting or depending on MTD, despite MTD_COMPLEX_MAPPINGS
depending on MTD.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index d89efba3d8a4..39b1c8030842 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -998,6 +998,7 @@ config CAVIUM_OCTEON_SOC
 	select NR_CPUS_DEFAULT_64
 	select MIPS_NR_CPU_NR_MAP_1024
 	select BUILTIN_DTB
+	select MTD
 	select MTD_COMPLEX_MAPPINGS
 	select SWIOTLB
 	select SYS_SUPPORTS_RELOCATABLE
-- 
2.25.1

Re: [PATCH] arch: mips: fix unmet dependency for MTD_COMPLEX_MAPPINGS

[Thomas Bogendoerfer]

On Fri, Mar 26, 2021 at 01:34:56AM -0400, Julian Braha wrote:
> When CAVIUM_OCTEON_SOC is enabled, and MTD is disabled,
> Kbuild gives the following warning:
> 
> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
>   Depends on [n]: MTD [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - CAVIUM_OCTEON_SOC [=y] && <choice>
> 
> This is because CAVIUM_OCTEON_SOC selects MTD_COMPLEX_MAPPINGS,
> without selecting or depending on MTD, despite MTD_COMPLEX_MAPPINGS
> depending on MTD.
> 
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  arch/mips/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]