All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] syscalls/clock_adjtime: fix some mistakes for commit 135affca95dca84bc9ce6b1e2238e6db6e6b0f56
@ 2021-03-26  8:05 Xie Ziyao
  2021-03-26  9:43 ` Li Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Xie Ziyao @ 2021-03-26  8:05 UTC (permalink / raw)
  To: ltp

- change TTERRNO to TERRNO after the safe_macros interface is not used;
- delete the unnecessary tst_res(TFAIL | TTERRNO, ...), which has been
  determined in the previous logic.

Signed-off-by: Xie Ziyao <xieziyao@huawei.com>
---
 testcases/kernel/syscalls/clock_adjtime/clock_adjtime01.c | 7 +------
 testcases/kernel/syscalls/clock_adjtime/clock_adjtime02.c | 2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/testcases/kernel/syscalls/clock_adjtime/clock_adjtime01.c b/testcases/kernel/syscalls/clock_adjtime/clock_adjtime01.c
index 061b2bb22..aff374a2c 100644
--- a/testcases/kernel/syscalls/clock_adjtime/clock_adjtime01.c
+++ b/testcases/kernel/syscalls/clock_adjtime/clock_adjtime01.c
@@ -174,11 +174,6 @@ static void verify_clock_adjtime(unsigned int i)
 			tc[i].modes);
 	}

-	if (TST_RET < 0) {
-		tst_res(TFAIL | TTERRNO, "clock_adjtime(): mode=%x, returned "
-				"error", tc[i].modes);
-	}
-
 	tst_res(TPASS, "clock_adjtime(): success (mode=%x)", tc[i].modes);
 }

@@ -201,7 +196,7 @@ static void setup(void)

 	if (rval != TIME_OK && rval != TIME_ERROR) {
 		timex_show("SAVE_STATUS", &saved);
-		tst_brk(TBROK | TTERRNO, "clock has on-going leap changes, "
+		tst_brk(TBROK | TERRNO, "clock has on-going leap changes, "
 				"returned: %i", rval);
 	}

diff --git a/testcases/kernel/syscalls/clock_adjtime/clock_adjtime02.c b/testcases/kernel/syscalls/clock_adjtime/clock_adjtime02.c
index 8ef4dadb6..2df9099d5 100644
--- a/testcases/kernel/syscalls/clock_adjtime/clock_adjtime02.c
+++ b/testcases/kernel/syscalls/clock_adjtime/clock_adjtime02.c
@@ -209,7 +209,7 @@ static void setup(void)

 	if (rval != TIME_OK && rval != TIME_ERROR) {
 		timex_show("SAVE_STATUS", &saved);
-		tst_brk(TBROK | TTERRNO, "clock has on-going leap changes, "
+		tst_brk(TBROK | TERRNO, "clock has on-going leap changes, "
 				"returned: %i", rval);
 	}

--
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [LTP] [PATCH] syscalls/clock_adjtime: fix some mistakes for commit 135affca95dca84bc9ce6b1e2238e6db6e6b0f56
  2021-03-26  8:05 [LTP] [PATCH] syscalls/clock_adjtime: fix some mistakes for commit 135affca95dca84bc9ce6b1e2238e6db6e6b0f56 Xie Ziyao
@ 2021-03-26  9:43 ` Li Wang
  2021-03-27  1:31   ` [LTP] 答复: " xieziyao
  0 siblings, 1 reply; 3+ messages in thread
From: Li Wang @ 2021-03-26  9:43 UTC (permalink / raw)
  To: ltp

Hi Ziyao,

On Fri, Mar 26, 2021 at 4:06 PM Xie Ziyao <xieziyao@huawei.com> wrote:

> - change TTERRNO to TERRNO after the safe_macros interface is not used;
> - delete the unnecessary tst_res(TFAIL | TTERRNO, ...), which has been
>   determined in the previous logic.
>
> Signed-off-by: Xie Ziyao <xieziyao@huawei.com>
>

As a convention, we add "Fixes: xxxxxxxxxx" here to track the commit id.

Anyway, I help to modified some format issues and pushed it, thanks!


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210326/3d7388e1/attachment.htm>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [LTP] 答复:  [PATCH] syscalls/clock_adjtime: fix some mistakes for commit 135affca95dca84bc9ce6b1e2238e6db6e6b0f56
  2021-03-26  9:43 ` Li Wang
@ 2021-03-27  1:31   ` xieziyao
  0 siblings, 0 replies; 3+ messages in thread
From: xieziyao @ 2021-03-27  1:31 UTC (permalink / raw)
  To: ltp

I'll pay attention to this next time, thanks a lot. :)


--
Regards,
Xie Ziyao

???: Li Wang [mailto:liwang@redhat.com]
????: 2021?3?26? 17:43
???: xieziyao <xieziyao@huawei.com>
??: LTP List <ltp@lists.linux.it>
??: Re: [LTP] [PATCH] syscalls/clock_adjtime: fix some mistakes for commit 135affca95dca84bc9ce6b1e2238e6db6e6b0f56

Hi Ziyao,

On Fri, Mar 26, 2021 at 4:06 PM Xie Ziyao <xieziyao@huawei.com<mailto:xieziyao@huawei.com>> wrote:
- change TTERRNO to TERRNO after the safe_macros interface is not used;
- delete the unnecessary tst_res(TFAIL | TTERRNO, ...), which has been
  determined in the previous logic.

Signed-off-by: Xie Ziyao <xieziyao@huawei.com<mailto:xieziyao@huawei.com>>

As a convention, we add "Fixes: xxxxxxxxxx" here to track the commit id.

Anyway, I help to modified some format issues and pushed it, thanks!


--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210327/3bc2c33a/attachment.htm>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-27  1:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26  8:05 [LTP] [PATCH] syscalls/clock_adjtime: fix some mistakes for commit 135affca95dca84bc9ce6b1e2238e6db6e6b0f56 Xie Ziyao
2021-03-26  9:43 ` Li Wang
2021-03-27  1:31   ` [LTP] 答复: " xieziyao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.