From: kernel test robot <lkp@intel.com>
To: Yangbo Lu <yangbo.lu@nxp.com>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, Yangbo Lu <yangbo.lu@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Richard Cochran <richardcochran@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH 2/2] enetc: support PTP Sync packet one-step timestamping
Date: Fri, 26 Mar 2021 20:07:27 +0800 [thread overview]
Message-ID: <202103261925.rDPx2m5X-lkp@intel.com> (raw)
In-Reply-To: <20210326083554.28985-3-yangbo.lu@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3394 bytes --]
Hi Yangbo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210325]
[cannot apply to ipvs/master linus/master sparc-next/master v5.12-rc4 v5.12-rc3 v5.12-rc2 v5.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955
base: b4f20b70784aabf97e1727561e775500f6e294c7
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ee04f0512d195ae9492fffbd4598c659bbda85d8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955
git checkout ee04f0512d195ae9492fffbd4598c659bbda85d8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/freescale/enetc/enetc.c:263:13: warning: no previous prototype for 'enetc_start_xmit' [-Wmissing-prototypes]
263 | netdev_tx_t enetc_start_xmit(struct sk_buff *skb, struct net_device *ndev)
| ^~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
vim +/enetc_start_xmit +263 drivers/net/ethernet/freescale/enetc/enetc.c
262
> 263 netdev_tx_t enetc_start_xmit(struct sk_buff *skb, struct net_device *ndev)
264 {
265 struct enetc_ndev_priv *priv = netdev_priv(ndev);
266 struct enetc_bdr *tx_ring;
267 int count;
268
269 tx_ring = priv->tx_ring[skb->queue_mapping];
270
271 if (unlikely(skb_shinfo(skb)->nr_frags > ENETC_MAX_SKB_FRAGS))
272 if (unlikely(skb_linearize(skb)))
273 goto drop_packet_err;
274
275 count = skb_shinfo(skb)->nr_frags + 1; /* fragments + head */
276 if (enetc_bd_unused(tx_ring) < ENETC_TXBDS_NEEDED(count)) {
277 netif_stop_subqueue(ndev, tx_ring->index);
278 return NETDEV_TX_BUSY;
279 }
280
281 enetc_lock_mdio();
282 count = enetc_map_tx_buffs(tx_ring, skb);
283 enetc_unlock_mdio();
284
285 if (unlikely(!count))
286 goto drop_packet_err;
287
288 if (enetc_bd_unused(tx_ring) < ENETC_TXBDS_MAX_NEEDED)
289 netif_stop_subqueue(ndev, tx_ring->index);
290
291 return NETDEV_TX_OK;
292
293 drop_packet_err:
294 dev_kfree_skb_any(skb);
295 return NETDEV_TX_OK;
296 }
297
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64095 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/2] enetc: support PTP Sync packet one-step timestamping
Date: Fri, 26 Mar 2021 20:07:27 +0800 [thread overview]
Message-ID: <202103261925.rDPx2m5X-lkp@intel.com> (raw)
In-Reply-To: <20210326083554.28985-3-yangbo.lu@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3478 bytes --]
Hi Yangbo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210325]
[cannot apply to ipvs/master linus/master sparc-next/master v5.12-rc4 v5.12-rc3 v5.12-rc2 v5.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955
base: b4f20b70784aabf97e1727561e775500f6e294c7
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ee04f0512d195ae9492fffbd4598c659bbda85d8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955
git checkout ee04f0512d195ae9492fffbd4598c659bbda85d8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/freescale/enetc/enetc.c:263:13: warning: no previous prototype for 'enetc_start_xmit' [-Wmissing-prototypes]
263 | netdev_tx_t enetc_start_xmit(struct sk_buff *skb, struct net_device *ndev)
| ^~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
vim +/enetc_start_xmit +263 drivers/net/ethernet/freescale/enetc/enetc.c
262
> 263 netdev_tx_t enetc_start_xmit(struct sk_buff *skb, struct net_device *ndev)
264 {
265 struct enetc_ndev_priv *priv = netdev_priv(ndev);
266 struct enetc_bdr *tx_ring;
267 int count;
268
269 tx_ring = priv->tx_ring[skb->queue_mapping];
270
271 if (unlikely(skb_shinfo(skb)->nr_frags > ENETC_MAX_SKB_FRAGS))
272 if (unlikely(skb_linearize(skb)))
273 goto drop_packet_err;
274
275 count = skb_shinfo(skb)->nr_frags + 1; /* fragments + head */
276 if (enetc_bd_unused(tx_ring) < ENETC_TXBDS_NEEDED(count)) {
277 netif_stop_subqueue(ndev, tx_ring->index);
278 return NETDEV_TX_BUSY;
279 }
280
281 enetc_lock_mdio();
282 count = enetc_map_tx_buffs(tx_ring, skb);
283 enetc_unlock_mdio();
284
285 if (unlikely(!count))
286 goto drop_packet_err;
287
288 if (enetc_bd_unused(tx_ring) < ENETC_TXBDS_MAX_NEEDED)
289 netif_stop_subqueue(ndev, tx_ring->index);
290
291 return NETDEV_TX_OK;
292
293 drop_packet_err:
294 dev_kfree_skb_any(skb);
295 return NETDEV_TX_OK;
296 }
297
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 64095 bytes --]
next prev parent reply other threads:[~2021-03-26 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 8:35 [PATCH 0/2] enetc: support PTP Sync packet one-step timestamping Yangbo Lu
2021-03-26 8:35 ` [PATCH 1/2] enetc: mark TX timestamp type per skb Yangbo Lu
2021-03-26 8:35 ` [PATCH 2/2] enetc: support PTP Sync packet one-step timestamping Yangbo Lu
2021-03-26 12:07 ` kernel test robot [this message]
2021-03-26 12:07 ` kernel test robot
2021-03-28 7:51 ` Claudiu Manoil
2021-04-08 11:23 ` Y.b. Lu
2021-03-26 19:21 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103261925.rDPx2m5X-lkp@intel.com \
--to=lkp@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.