* [PATCH] sched,psi: fix typo in comment
@ 2021-03-27 12:46 Xie XiuQi
2021-03-29 7:35 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Xie XiuQi @ 2021-03-27 12:46 UTC (permalink / raw)
To: mingo, peterz; +Cc: linux-kernel
s/exceution/execution/
s/possibe/possible/
s/manupulations/manipulations/
Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
---
kernel/sched/psi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 967732c0766c..7c800be47c6f 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -59,7 +59,7 @@
* states, we would have to conclude a CPU SOME pressure number of
* 100%, since *somebody* is waiting on a runqueue at all
* times. However, that is clearly not the amount of contention the
- * workload is experiencing: only one out of 256 possible exceution
+ * workload is experiencing: only one out of 256 possible execution
* threads will be contended at any given time, or about 0.4%.
*
* Conversely, consider a scenario of 4 tasks and 4 CPUs where at any
@@ -73,7 +73,7 @@
* we have to base our calculation on the number of non-idle tasks in
* conjunction with the number of available CPUs, which is the number
* of potential execution threads. SOME becomes then the proportion of
- * delayed tasks to possibe threads, and FULL is the share of possible
+ * delayed tasks to possible threads, and FULL is the share of possible
* threads that are unproductive due to delays:
*
* threads = min(nr_nonidle_tasks, nr_cpus)
@@ -441,7 +441,8 @@ static void psi_avgs_work(struct work_struct *work)
mutex_unlock(&group->avgs_lock);
}
-/* Trigger tracking window manupulations */
+/* Trigger tracking window manipulations */
+
static void window_reset(struct psi_window *win, u64 now, u64 value,
u64 prev_growth)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched,psi: fix typo in comment
2021-03-27 12:46 [PATCH] sched,psi: fix typo in comment Xie XiuQi
@ 2021-03-29 7:35 ` Peter Zijlstra
2021-03-29 14:45 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2021-03-29 7:35 UTC (permalink / raw)
To: Xie XiuQi; +Cc: mingo, linux-kernel, joe
On Sat, Mar 27, 2021 at 08:46:10PM +0800, Xie XiuQi wrote:
> s/exceution/execution/
> s/possibe/possible/
> s/manupulations/manipulations/
>
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Xie, if you'd have bothered to check the development tree of the code
you're patching, you'd have found it's long since fixed.
Can we please get a MAINTAINERS entry that indicates the willingness to
suffer nonsense like this? Then checkpatch will tell people to bugger
off and I can stop blacklisting people on this.
I'm getting sick and tired of people wasting bandwidth with this
nonsense.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched,psi: fix typo in comment
2021-03-29 7:35 ` Peter Zijlstra
@ 2021-03-29 14:45 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2021-03-29 14:45 UTC (permalink / raw)
To: Peter Zijlstra, Xie XiuQi; +Cc: mingo, linux-kernel
On Mon, 2021-03-29 at 09:35 +0200, Peter Zijlstra wrote:
> On Sat, Mar 27, 2021 at 08:46:10PM +0800, Xie XiuQi wrote:
> > s/exceution/execution/
> > s/possibe/possible/
> > s/manupulations/manipulations/
> >
> > Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
>
> Xie, if you'd have bothered to check the development tree of the code
> you're patching, you'd have found it's long since fixed.
March 18, 2021 doesn't seem a long time ago to me.
commit 3b03706fa621ce31a3e9ef6307020fde4e6aae16
Author: Ingo Molnar <mingo@kernel.org>
Date: Thu Mar 18 13:38:50 2021 +0100
sched: Fix various typos
> I'm getting sick and tired of people wasting bandwidth with this
> nonsense.
This seems more like a large overreaction IMO.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-29 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27 12:46 [PATCH] sched,psi: fix typo in comment Xie XiuQi
2021-03-29 7:35 ` Peter Zijlstra
2021-03-29 14:45 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.