All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dm: test: Always include command.h for print_ut
@ 2021-03-26  2:02 Sean Anderson
  2021-03-26  6:08 ` Simon Glass
  2021-03-29  0:29 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Sean Anderson @ 2021-03-26  2:02 UTC (permalink / raw)
  To: u-boot

We need this header for U_BOOT_CMD, which is always present even without
EFI.

Fixes: 82c468a049 ("dm: test: Update Makefile conditions")

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

Changes in v2:
- Remove ifdef

 test/print_ut.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/print_ut.c b/test/print_ut.c
index a456a449ef..5b0a46de9c 100644
--- a/test/print_ut.c
+++ b/test/print_ut.c
@@ -6,10 +6,8 @@
 #define DEBUG
 
 #include <common.h>
-#if CONFIG_IS_ENABLED(EFI_LOADER) && !defined(API_BUILD)
 #include <command.h>
 #include <efi_api.h>
-#endif
 #include <display_options.h>
 #include <log.h>
 #include <version.h>
-- 
2.31.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2] dm: test: Always include command.h for print_ut
  2021-03-26  2:02 [PATCH v2] dm: test: Always include command.h for print_ut Sean Anderson
@ 2021-03-26  6:08 ` Simon Glass
  2021-03-29  0:29 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-03-26  6:08 UTC (permalink / raw)
  To: u-boot

On Fri, 26 Mar 2021 at 15:02, Sean Anderson <seanga2@gmail.com> wrote:
>
> We need this header for U_BOOT_CMD, which is always present even without
> EFI.
>
> Fixes: 82c468a049 ("dm: test: Update Makefile conditions")
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>
> Changes in v2:
> - Remove ifdef
>
>  test/print_ut.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] dm: test: Always include command.h for print_ut
  2021-03-26  2:02 [PATCH v2] dm: test: Always include command.h for print_ut Sean Anderson
  2021-03-26  6:08 ` Simon Glass
@ 2021-03-29  0:29 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-03-29  0:29 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 25, 2021 at 10:02:28PM -0400, Sean Anderson wrote:

> We need this header for U_BOOT_CMD, which is always present even without
> EFI.
> 
> Fixes: 82c468a049 ("dm: test: Update Makefile conditions")
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210328/601d2598/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-29  0:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26  2:02 [PATCH v2] dm: test: Always include command.h for print_ut Sean Anderson
2021-03-26  6:08 ` Simon Glass
2021-03-29  0:29 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.