* [PATCH -next 1/2] drivers: most: use DEFINE_SPINLOCK() for spinlock
@ 2021-03-29 9:40 Shixin Liu
2021-03-29 9:40 ` [PATCH -next 2/2] drivers: most: use LIST_HEAD() for list_head Shixin Liu
0 siblings, 1 reply; 2+ messages in thread
From: Shixin Liu @ 2021-03-29 9:40 UTC (permalink / raw)
To: Christian Gromm, Greg Kroah-Hartman; +Cc: linux-kernel, Shixin Liu
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Signed-off-by: Shixin Liu <liushixin2@huawei.com>
---
drivers/most/most_cdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/most/most_cdev.c b/drivers/most/most_cdev.c
index 044880760b58..8b69cf3ca60b 100644
--- a/drivers/most/most_cdev.c
+++ b/drivers/most/most_cdev.c
@@ -45,7 +45,7 @@ struct comp_channel {
#define to_channel(d) container_of(d, struct comp_channel, cdev)
static struct list_head channel_list;
-static spinlock_t ch_list_lock;
+static DEFINE_SPINLOCK(ch_list_lock);
static inline bool ch_has_mbo(struct comp_channel *c)
{
@@ -495,7 +495,6 @@ static int __init mod_init(void)
return PTR_ERR(comp.class);
INIT_LIST_HEAD(&channel_list);
- spin_lock_init(&ch_list_lock);
ida_init(&comp.minor_id);
err = alloc_chrdev_region(&comp.devno, 0, CHRDEV_REGION_SIZE, "cdev");
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next 2/2] drivers: most: use LIST_HEAD() for list_head
2021-03-29 9:40 [PATCH -next 1/2] drivers: most: use DEFINE_SPINLOCK() for spinlock Shixin Liu
@ 2021-03-29 9:40 ` Shixin Liu
0 siblings, 0 replies; 2+ messages in thread
From: Shixin Liu @ 2021-03-29 9:40 UTC (permalink / raw)
To: Christian Gromm, Greg Kroah-Hartman; +Cc: linux-kernel, Shixin Liu
There's no need to declare a list and then init it manually,
just use the LIST_HEAD() macro.
Signed-off-by: Shixin Liu <liushixin2@huawei.com>
---
drivers/most/most_cdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/most/most_cdev.c b/drivers/most/most_cdev.c
index 8b69cf3ca60b..8908b9363a96 100644
--- a/drivers/most/most_cdev.c
+++ b/drivers/most/most_cdev.c
@@ -44,7 +44,7 @@ struct comp_channel {
};
#define to_channel(d) container_of(d, struct comp_channel, cdev)
-static struct list_head channel_list;
+static LIST_HEAD(channel_list);
static DEFINE_SPINLOCK(ch_list_lock);
static inline bool ch_has_mbo(struct comp_channel *c)
@@ -494,7 +494,6 @@ static int __init mod_init(void)
if (IS_ERR(comp.class))
return PTR_ERR(comp.class);
- INIT_LIST_HEAD(&channel_list);
ida_init(&comp.minor_id);
err = alloc_chrdev_region(&comp.devno, 0, CHRDEV_REGION_SIZE, "cdev");
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 9:40 [PATCH -next 1/2] drivers: most: use DEFINE_SPINLOCK() for spinlock Shixin Liu
2021-03-29 9:40 ` [PATCH -next 2/2] drivers: most: use LIST_HEAD() for list_head Shixin Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.