* [PATCH v2 bpf-next] tools/resolve_btfids: Fix warnings
@ 2021-03-29 16:45 Stanislav Fomichev
2021-03-29 17:23 ` Song Liu
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Fomichev @ 2021-03-29 16:45 UTC (permalink / raw)
To: netdev, bpf; +Cc: ast, daniel, Stanislav Fomichev
* make eprintf static, used only in main.c
* initialize ret in eprintf
* remove unused *tmp
* remove unused 'int err = -1'
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
tools/bpf/resolve_btfids/main.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index 80d966cfcaa1..be74406626b7 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -115,10 +115,10 @@ struct object {
static int verbose;
-int eprintf(int level, int var, const char *fmt, ...)
+static int eprintf(int level, int var, const char *fmt, ...)
{
va_list args;
- int ret;
+ int ret = 0;
if (var >= level) {
va_start(args, fmt);
@@ -403,10 +403,9 @@ static int symbols_collect(struct object *obj)
* __BTF_ID__* over .BTF_ids section.
*/
for (i = 0; !err && i < n; i++) {
- char *tmp, *prefix;
+ char *prefix;
struct btf_id *id;
GElf_Sym sym;
- int err = -1;
if (!gelf_getsym(obj->efile.symbols, i, &sym))
return -1;
--
2.31.0.291.g576ba9dcdaf-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 bpf-next] tools/resolve_btfids: Fix warnings
2021-03-29 16:45 [PATCH v2 bpf-next] tools/resolve_btfids: Fix warnings Stanislav Fomichev
@ 2021-03-29 17:23 ` Song Liu
2021-03-29 17:26 ` Stanislav Fomichev
0 siblings, 1 reply; 3+ messages in thread
From: Song Liu @ 2021-03-29 17:23 UTC (permalink / raw)
To: Stanislav Fomichev; +Cc: Networking, bpf, Alexei Starovoitov, Daniel Borkmann
On Mon, Mar 29, 2021 at 9:46 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> * make eprintf static, used only in main.c
> * initialize ret in eprintf
> * remove unused *tmp
> * remove unused 'int err = -1'
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
> tools/bpf/resolve_btfids/main.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
> index 80d966cfcaa1..be74406626b7 100644
> --- a/tools/bpf/resolve_btfids/main.c
> +++ b/tools/bpf/resolve_btfids/main.c
> @@ -115,10 +115,10 @@ struct object {
>
> static int verbose;
>
> -int eprintf(int level, int var, const char *fmt, ...)
> +static int eprintf(int level, int var, const char *fmt, ...)
> {
> va_list args;
> - int ret;
> + int ret = 0;
>
> if (var >= level) {
> va_start(args, fmt);
> @@ -403,10 +403,9 @@ static int symbols_collect(struct object *obj)
> * __BTF_ID__* over .BTF_ids section.
> */
> for (i = 0; !err && i < n; i++) {
^^^^ This err is also not used.
> - char *tmp, *prefix;
> + char *prefix;
> struct btf_id *id;
> GElf_Sym sym;
> - int err = -1;
>
> if (!gelf_getsym(obj->efile.symbols, i, &sym))
> return -1;
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 bpf-next] tools/resolve_btfids: Fix warnings
2021-03-29 17:23 ` Song Liu
@ 2021-03-29 17:26 ` Stanislav Fomichev
0 siblings, 0 replies; 3+ messages in thread
From: Stanislav Fomichev @ 2021-03-29 17:26 UTC (permalink / raw)
To: Song Liu; +Cc: Networking, bpf, Alexei Starovoitov, Daniel Borkmann
On Mon, Mar 29, 2021 at 10:23 AM Song Liu <song@kernel.org> wrote:
>
> On Mon, Mar 29, 2021 at 9:46 AM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > * make eprintf static, used only in main.c
> > * initialize ret in eprintf
> > * remove unused *tmp
> > * remove unused 'int err = -1'
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > ---
> > tools/bpf/resolve_btfids/main.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
> > index 80d966cfcaa1..be74406626b7 100644
> > --- a/tools/bpf/resolve_btfids/main.c
> > +++ b/tools/bpf/resolve_btfids/main.c
> > @@ -115,10 +115,10 @@ struct object {
> >
> > static int verbose;
> >
> > -int eprintf(int level, int var, const char *fmt, ...)
> > +static int eprintf(int level, int var, const char *fmt, ...)
> > {
> > va_list args;
> > - int ret;
> > + int ret = 0;
> >
> > if (var >= level) {
> > va_start(args, fmt);
> > @@ -403,10 +403,9 @@ static int symbols_collect(struct object *obj)
> > * __BTF_ID__* over .BTF_ids section.
> > */
> > for (i = 0; !err && i < n; i++) {
> ^^^^ This err is also not used.
Yeah, good point, let's remove that one as well. Thanks!
> > - char *tmp, *prefix;
> > + char *prefix;
> > struct btf_id *id;
> > GElf_Sym sym;
> > - int err = -1;
> >
> > if (!gelf_getsym(obj->efile.symbols, i, &sym))
> > return -1;
> > --
> > 2.31.0.291.g576ba9dcdaf-goog
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-29 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 16:45 [PATCH v2 bpf-next] tools/resolve_btfids: Fix warnings Stanislav Fomichev
2021-03-29 17:23 ` Song Liu
2021-03-29 17:26 ` Stanislav Fomichev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.