All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: renesas: r8a779a0: Add ISPCS clocks
@ 2021-03-29 22:32 Niklas Söderlund
  2021-04-23  9:35 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2021-03-29 22:32 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-clk; +Cc: linux-renesas-soc, Niklas Söderlund

Add support for the ISPCS clocks on V3U.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a779a0-cpg-mssr.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
index 867c565cb58ff5b5..acaf5a93f1d3ed45 100644
--- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
@@ -180,6 +180,10 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
 	DEF_MOD("i2c4",		522,	R8A779A0_CLK_S1D4),
 	DEF_MOD("i2c5",		523,	R8A779A0_CLK_S1D4),
 	DEF_MOD("i2c6",		524,	R8A779A0_CLK_S1D4),
+	DEF_MOD("ispcs0",	612,	R8A779A0_CLK_S1D1),
+	DEF_MOD("ispcs1",	613,	R8A779A0_CLK_S1D1),
+	DEF_MOD("ispcs2",	614,	R8A779A0_CLK_S1D1),
+	DEF_MOD("ispcs3",	615,	R8A779A0_CLK_S1D1),
 	DEF_MOD("msi0",		618,	R8A779A0_CLK_MSO),
 	DEF_MOD("msi1",		619,	R8A779A0_CLK_MSO),
 	DEF_MOD("msi2",		620,	R8A779A0_CLK_MSO),
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: renesas: r8a779a0: Add ISPCS clocks
  2021-03-29 22:32 [PATCH] clk: renesas: r8a779a0: Add ISPCS clocks Niklas Söderlund
@ 2021-04-23  9:35 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-04-23  9:35 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: linux-clk, Linux-Renesas

Hi Niklas,

On Tue, Mar 30, 2021 at 12:33 AM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Add support for the ISPCS clocks on V3U.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> @@ -180,6 +180,10 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
>         DEF_MOD("i2c4",         522,    R8A779A0_CLK_S1D4),
>         DEF_MOD("i2c5",         523,    R8A779A0_CLK_S1D4),
>         DEF_MOD("i2c6",         524,    R8A779A0_CLK_S1D4),
> +       DEF_MOD("ispcs0",       612,    R8A779A0_CLK_S1D1),
> +       DEF_MOD("ispcs1",       613,    R8A779A0_CLK_S1D1),
> +       DEF_MOD("ispcs2",       614,    R8A779A0_CLK_S1D1),
> +       DEF_MOD("ispcs3",       615,    R8A779A0_CLK_S1D1),

Unfortunately the parent clock is not explicitly documented in the
hardware manual.  But S1D1 does match max. 479 Mpixel/s.

>         DEF_MOD("msi0",         618,    R8A779A0_CLK_MSO),
>         DEF_MOD("msi1",         619,    R8A779A0_CLK_MSO),
>         DEF_MOD("msi2",         620,    R8A779A0_CLK_MSO),

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-clk-for-v5.14.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-23  9:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 22:32 [PATCH] clk: renesas: r8a779a0: Add ISPCS clocks Niklas Söderlund
2021-04-23  9:35 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.