All of lore.kernel.org
 help / color / mirror / Atom feed
* [tip:irq/core 2/2] kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'
@ 2021-03-29 23:12 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-03-29 23:12 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3213 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
CC: x86(a)kernel.org
TO: Bartosz Golaszewski <bgolaszewski@baylibre.com>
CC: Thomas Gleixner <tglx@linutronix.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head:   e6d46eded43dacf6370a7ae70f927ef4692cfcab
commit: e6d46eded43dacf6370a7ae70f927ef4692cfcab [2/2] genirq/irq_sim: Shrink devm_irq_domain_create_sim()
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: x86_64-randconfig-m001-20210328 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'

vim +/ERR_PTR +246 kernel/irq/irq_sim.c

44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  221  
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  222  /**
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  223   * devm_irq_domain_create_sim - Create a new interrupt simulator for
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  224   *                              a managed device.
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  225   *
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  226   * @dev:        Device to initialize the simulator object for.
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  227   * @fnode:      struct fwnode_handle to be associated with this domain.
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  228   * @num_irqs:   Number of interrupts to allocate
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  229   *
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  230   * On success: return a new irq_domain object.
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  231   * On failure: a negative errno wrapped with ERR_PTR().
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  232   */
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  233  struct irq_domain *devm_irq_domain_create_sim(struct device *dev,
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  234  					      struct fwnode_handle *fwnode,
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  235  					      unsigned int num_irqs)
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  236  {
e6d46eded43dac Bartosz Golaszewski 2021-03-01  237  	struct irq_domain *domain;
e6d46eded43dac Bartosz Golaszewski 2021-03-01  238  	int ret;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  239  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  240  	domain = irq_domain_create_sim(fwnode, num_irqs);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  241  	if (IS_ERR(domain))
e6d46eded43dac Bartosz Golaszewski 2021-03-01  242  		return domain;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  243  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  244  	ret = devm_add_action_or_reset(dev, devm_irq_domain_remove_sim, domain);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  245  	if (!ret)
e6d46eded43dac Bartosz Golaszewski 2021-03-01 @246  		return ERR_PTR(ret);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32539 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:irq/core 2/2] kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'
@ 2021-03-30  9:58 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-03-30  9:58 UTC (permalink / raw)
  To: kbuild, Bartosz Golaszewski
  Cc: lkp, kbuild-all, linux-kernel, x86, Thomas Gleixner

[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head:   e6d46eded43dacf6370a7ae70f927ef4692cfcab
commit: e6d46eded43dacf6370a7ae70f927ef4692cfcab [2/2] genirq/irq_sim: Shrink devm_irq_domain_create_sim()
config: x86_64-randconfig-m001-20210328 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'

vim +/ERR_PTR +246 kernel/irq/irq_sim.c

337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  233  struct irq_domain *devm_irq_domain_create_sim(struct device *dev,
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  234  					      struct fwnode_handle *fwnode,
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  235  					      unsigned int num_irqs)
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  236  {
e6d46eded43dac Bartosz Golaszewski 2021-03-01  237  	struct irq_domain *domain;
e6d46eded43dac Bartosz Golaszewski 2021-03-01  238  	int ret;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  239  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  240  	domain = irq_domain_create_sim(fwnode, num_irqs);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  241  	if (IS_ERR(domain))
e6d46eded43dac Bartosz Golaszewski 2021-03-01  242  		return domain;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  243  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  244  	ret = devm_add_action_or_reset(dev, devm_irq_domain_remove_sim, domain);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  245  	if (!ret)
                                                             ^^^
This is probably reversed.  It should be "if (ret)"

e6d46eded43dac Bartosz Golaszewski 2021-03-01 @246  		return ERR_PTR(ret);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32539 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:irq/core 2/2] kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'
@ 2021-03-30  9:58 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-03-30  9:58 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head:   e6d46eded43dacf6370a7ae70f927ef4692cfcab
commit: e6d46eded43dacf6370a7ae70f927ef4692cfcab [2/2] genirq/irq_sim: Shrink devm_irq_domain_create_sim()
config: x86_64-randconfig-m001-20210328 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'

vim +/ERR_PTR +246 kernel/irq/irq_sim.c

337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  233  struct irq_domain *devm_irq_domain_create_sim(struct device *dev,
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  234  					      struct fwnode_handle *fwnode,
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  235  					      unsigned int num_irqs)
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  236  {
e6d46eded43dac Bartosz Golaszewski 2021-03-01  237  	struct irq_domain *domain;
e6d46eded43dac Bartosz Golaszewski 2021-03-01  238  	int ret;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  239  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  240  	domain = irq_domain_create_sim(fwnode, num_irqs);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  241  	if (IS_ERR(domain))
e6d46eded43dac Bartosz Golaszewski 2021-03-01  242  		return domain;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  243  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  244  	ret = devm_add_action_or_reset(dev, devm_irq_domain_remove_sim, domain);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  245  	if (!ret)
                                                             ^^^
This is probably reversed.  It should be "if (ret)"

e6d46eded43dac Bartosz Golaszewski 2021-03-01 @246  		return ERR_PTR(ret);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32539 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:irq/core 2/2] kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'
@ 2021-03-30  9:58 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-03-30  9:58 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head:   e6d46eded43dacf6370a7ae70f927ef4692cfcab
commit: e6d46eded43dacf6370a7ae70f927ef4692cfcab [2/2] genirq/irq_sim: Shrink devm_irq_domain_create_sim()
config: x86_64-randconfig-m001-20210328 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR'

vim +/ERR_PTR +246 kernel/irq/irq_sim.c

337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  233  struct irq_domain *devm_irq_domain_create_sim(struct device *dev,
337cbeb2c13eb4 Bartosz Golaszewski 2020-05-14  234  					      struct fwnode_handle *fwnode,
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  235  					      unsigned int num_irqs)
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  236  {
e6d46eded43dac Bartosz Golaszewski 2021-03-01  237  	struct irq_domain *domain;
e6d46eded43dac Bartosz Golaszewski 2021-03-01  238  	int ret;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  239  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  240  	domain = irq_domain_create_sim(fwnode, num_irqs);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  241  	if (IS_ERR(domain))
e6d46eded43dac Bartosz Golaszewski 2021-03-01  242  		return domain;
44e72c7ebf2940 Bartosz Golaszewski 2017-08-14  243  
e6d46eded43dac Bartosz Golaszewski 2021-03-01  244  	ret = devm_add_action_or_reset(dev, devm_irq_domain_remove_sim, domain);
e6d46eded43dac Bartosz Golaszewski 2021-03-01  245  	if (!ret)
                                                             ^^^
This is probably reversed.  It should be "if (ret)"

e6d46eded43dac Bartosz Golaszewski 2021-03-01 @246  		return ERR_PTR(ret);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32539 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-30 10:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 23:12 [tip:irq/core 2/2] kernel/irq/irq_sim.c:246 devm_irq_domain_create_sim() warn: passing zero to 'ERR_PTR' kernel test robot
2021-03-30  9:58 Dan Carpenter
2021-03-30  9:58 ` Dan Carpenter
2021-03-30  9:58 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.