All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] files: move example files away from /etc
@ 2021-03-30 14:46 Jan Engelhardt
  2021-04-03 18:03 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2021-03-30 14:46 UTC (permalink / raw)
  To: netfilter-devel

As per file-hierarchy(5), /etc is for "system-specific configuration", not
"vendor-supplied default configuration files".

Moreover, the comments in all-in-one.nft say it is an example, and so,
not a vendor config either.

Move it out of /etc.

Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
For nftables.git.

 files/nftables/Makefile.am | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git files/nftables/Makefile.am files/nftables/Makefile.am
index fc8b94ea..ee88dd89 100644
--- files/nftables/Makefile.am
+++ files/nftables/Makefile.am
@@ -1,5 +1,4 @@
-pkgsysconfdir = ${sysconfdir}/nftables
-dist_pkgsysconf_DATA =	all-in-one.nft		\
+dist_pkgdata_DATA =	all-in-one.nft		\
 			arp-filter.nft		\
 			bridge-filter.nft	\
 			inet-filter.nft		\
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] files: move example files away from /etc
  2021-03-30 14:46 [PATCH] files: move example files away from /etc Jan Engelhardt
@ 2021-04-03 18:03 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2021-04-03 18:03 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: netfilter-devel

On Tue, Mar 30, 2021 at 04:46:53PM +0200, Jan Engelhardt wrote:
> As per file-hierarchy(5), /etc is for "system-specific configuration", not
> "vendor-supplied default configuration files".
> 
> Moreover, the comments in all-in-one.nft say it is an example, and so,
> not a vendor config either.
> 
> Move it out of /etc.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-03 18:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 14:46 [PATCH] files: move example files away from /etc Jan Engelhardt
2021-04-03 18:03 ` Pablo Neira Ayuso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.