From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>, Andreas Gruenbacher <agruenba@redhat.com>, cluster-devel@redhat.com Subject: [PATCH 12/31] fs: gfs2: ops_fstype: Fix a little doc-rot Date: Tue, 30 Mar 2021 17:44:39 +0100 [thread overview] Message-ID: <20210330164458.1625478-13-lee.jones@linaro.org> (raw) In-Reply-To: <20210330164458.1625478-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): fs/gfs2/ops_fstype.c:162: warning: Excess function parameter 'sb' description in 'gfs2_check_sb' fs/gfs2/ops_fstype.c:242: warning: Function parameter or member 'silent' not described in 'gfs2_read_super' fs/gfs2/ops_fstype.c:242: warning: Excess function parameter 'error' description in 'gfs2_read_super' fs/gfs2/ops_fstype.c:993: warning: Excess function parameter 'args' description in 'gfs2_lm_mount' fs/gfs2/ops_fstype.c:1102: warning: Function parameter or member 'fc' not described in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'args' description in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'silent' description in 'gfs2_fill_super' Cc: Bob Peterson <rpeterso@redhat.com> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones <lee.jones@linaro.org> --- fs/gfs2/ops_fstype.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index aa4136055a83c..b6c7a95dabf90 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -150,7 +150,6 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) /** * gfs2_check_sb - Check superblock * @sdp: the filesystem - * @sb: The superblock * @silent: Don't print a message if the check fails * * Checks the version code of the FS is one that we understand how to @@ -223,7 +222,7 @@ static void gfs2_sb_in(struct gfs2_sbd *sdp, const void *buf) * gfs2_read_super - Read the gfs2 super block from disk * @sdp: The GFS2 super block * @sector: The location of the super block - * @error: The error code to return + * @silent: Don't print a message if the check fails * * This uses the bio functions to read the super block from disk * because we want to be 100% sure that we never read cached data. @@ -983,7 +982,6 @@ static const struct lm_lockops nolock_ops = { /** * gfs2_lm_mount - mount a locking protocol * @sdp: the filesystem - * @args: mount arguments * @silent: if 1, don't complain if the FS isn't a GFS2 fs * * Returns: errno @@ -1093,8 +1091,7 @@ void gfs2_online_uevent(struct gfs2_sbd *sdp) /** * gfs2_fill_super - Read in superblock * @sb: The VFS superblock - * @args: Mount options - * @silent: Don't complain if it's not a GFS2 filesystem + * @fc: Mount options and flags * * Returns: -errno */ -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: cluster-devel.redhat.com Subject: [Cluster-devel] [PATCH 12/31] fs: gfs2: ops_fstype: Fix a little doc-rot Date: Tue, 30 Mar 2021 17:44:39 +0100 [thread overview] Message-ID: <20210330164458.1625478-13-lee.jones@linaro.org> (raw) In-Reply-To: <20210330164458.1625478-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): fs/gfs2/ops_fstype.c:162: warning: Excess function parameter 'sb' description in 'gfs2_check_sb' fs/gfs2/ops_fstype.c:242: warning: Function parameter or member 'silent' not described in 'gfs2_read_super' fs/gfs2/ops_fstype.c:242: warning: Excess function parameter 'error' description in 'gfs2_read_super' fs/gfs2/ops_fstype.c:993: warning: Excess function parameter 'args' description in 'gfs2_lm_mount' fs/gfs2/ops_fstype.c:1102: warning: Function parameter or member 'fc' not described in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'args' description in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'silent' description in 'gfs2_fill_super' Cc: Bob Peterson <rpeterso@redhat.com> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: cluster-devel at redhat.com Signed-off-by: Lee Jones <lee.jones@linaro.org> --- fs/gfs2/ops_fstype.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index aa4136055a83c..b6c7a95dabf90 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -150,7 +150,6 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) /** * gfs2_check_sb - Check superblock * @sdp: the filesystem - * @sb: The superblock * @silent: Don't print a message if the check fails * * Checks the version code of the FS is one that we understand how to @@ -223,7 +222,7 @@ static void gfs2_sb_in(struct gfs2_sbd *sdp, const void *buf) * gfs2_read_super - Read the gfs2 super block from disk * @sdp: The GFS2 super block * @sector: The location of the super block - * @error: The error code to return + * @silent: Don't print a message if the check fails * * This uses the bio functions to read the super block from disk * because we want to be 100% sure that we never read cached data. @@ -983,7 +982,6 @@ static const struct lm_lockops nolock_ops = { /** * gfs2_lm_mount - mount a locking protocol * @sdp: the filesystem - * @args: mount arguments * @silent: if 1, don't complain if the FS isn't a GFS2 fs * * Returns: errno @@ -1093,8 +1091,7 @@ void gfs2_online_uevent(struct gfs2_sbd *sdp) /** * gfs2_fill_super - Read in superblock * @sb: The VFS superblock - * @args: Mount options - * @silent: Don't complain if it's not a GFS2 filesystem + * @fc: Mount options and flags * * Returns: -errno */ -- 2.27.0
next prev parent reply other threads:[~2021-03-30 16:47 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-30 16:44 [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 01/31] fs: gfs2: dir: Finish off mostly complete headers demote others Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 02/31] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 03/31] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 04/31] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 05/31] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 06/31] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 07/31] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 08/31] fs: gfs2: aops: Fix a little potential doc-rot Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 09/31] fs: gfs2: meta_io: Add missing description for 'rahead' param Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 10/31] fs: gfs2: inode: Fix worthy function headers demote others Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 11/31] fs: gfs2: file: Strip out superfluous param description and demote kernel-doc abuse Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` Lee Jones [this message] 2021-03-30 16:44 ` [Cluster-devel] [PATCH 12/31] fs: gfs2: ops_fstype: Fix a little doc-rot Lee Jones 2021-03-30 16:44 ` [PATCH 13/31] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 14/31] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 15/31] fs: gfs2: recovery: Provide missing param descriptions and remove one other Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 16/31] fs: gfs2: super: Fix kernel-doc issues where feasible demote " Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 17/31] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 18/31] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header Lee Jones 2021-03-30 16:44 ` [Cluster-devel] " Lee Jones 2021-03-30 16:44 ` [PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc Lee Jones 2021-03-30 16:44 ` [PATCH 20/31] fs: ecryptfs: debug: Demote a couple of kernel-doc abuses Lee Jones 2021-03-30 16:44 ` [PATCH 21/31] fs: ecryptfs: dentry: File headers are not good candidates for kernel-doc Lee Jones 2021-03-30 16:44 ` [PATCH 22/31] fs: ecryptfs: kthread: Demote file header and provide description for 'cred' Lee Jones 2021-03-30 16:44 ` [PATCH 23/31] fs: ecryptfs: file: Demote kernel-doc abuses Lee Jones 2021-03-30 16:44 ` [PATCH 24/31] fs: ecryptfs: super: Fix formatting, naming and " Lee Jones 2021-03-30 16:44 ` [PATCH 25/31] fs: ecryptfs: messaging: Add missing param descriptions and demote abuses Lee Jones 2021-03-30 16:44 ` [PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers Lee Jones 2021-04-18 17:19 ` Tyler Hicks 2021-03-30 16:44 ` [PATCH 27/31] fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates Lee Jones 2021-03-30 16:44 ` [PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses Lee Jones 2021-04-18 17:17 ` Tyler Hicks 2021-03-30 16:44 ` [PATCH 29/31] fs: ecryptfs: mmap: Help out one function header and demote other abuses Lee Jones 2021-03-30 16:44 ` [PATCH 30/31] fs: ecryptfs: inode: Help out nearly-there header and demote non-conformant ones Lee Jones 2021-03-30 16:44 ` [PATCH 31/31] fs: ecryptfs: keystore: Fix some kernel-doc issues and demote non-conformant headers Lee Jones 2021-04-19 5:09 ` [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS Tyler Hicks 2021-04-19 5:09 ` [Cluster-devel] " Tyler Hicks 2021-04-19 7:26 ` Lee Jones 2021-04-19 7:26 ` [Cluster-devel] " Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210330164458.1625478-13-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=agruenba@redhat.com \ --cc=cluster-devel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rpeterso@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.