From: Pratyush Yadav <p.yadav@ti.com> To: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <dmaengine@vger.kernel.org> Cc: Pratyush Yadav <p.yadav@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Date: Tue, 30 Mar 2021 23:03:38 +0530 [thread overview] Message-ID: <20210330173348.30135-7-p.yadav@ti.com> (raw) In-Reply-To: <20210330173348.30135-1-p.yadav@ti.com> This resets the stream state machines and FIFOs, giving them a clean slate. On J721E if the streams are not reset before starting the capture, the captured frame gets wrapped around vertically on every run after the first. Signed-off-by: Pratyush Yadav <p.yadav@ti.com> --- drivers/media/platform/cadence/cdns-csi2rx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index 31bd80e3f780..b03d2d2e6762 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -39,6 +39,7 @@ #define CSI2RX_STREAM_BASE(n) (((n) + 1) * 0x100) #define CSI2RX_STREAM_CTRL_REG(n) (CSI2RX_STREAM_BASE(n) + 0x000) +#define CSI2RX_STREAM_CTRL_SOFT_RST BIT(4) #define CSI2RX_STREAM_CTRL_START BIT(0) #define CSI2RX_STREAM_DATA_CFG_REG(n) (CSI2RX_STREAM_BASE(n) + 0x008) @@ -150,12 +151,22 @@ struct csi2rx_priv *v4l2_subdev_to_csi2rx(struct v4l2_subdev *subdev) static void csi2rx_reset(struct csi2rx_priv *csi2rx) { + int i; + writel(CSI2RX_SOFT_RESET_PROTOCOL | CSI2RX_SOFT_RESET_FRONT, csi2rx->base + CSI2RX_SOFT_RESET_REG); udelay(10); writel(0, csi2rx->base + CSI2RX_SOFT_RESET_REG); + + /* Reset individual streams. */ + for (i = 0; i < csi2rx->max_streams; i++) { + writel(CSI2RX_STREAM_CTRL_SOFT_RST, + csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + usleep_range(10, 20); + writel(0, csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + } } static int csi2rx_configure_external_dphy(struct csi2rx_priv *csi2rx) -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com> To: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <dmaengine@vger.kernel.org> Cc: Pratyush Yadav <p.yadav@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Date: Tue, 30 Mar 2021 23:03:38 +0530 [thread overview] Message-ID: <20210330173348.30135-7-p.yadav@ti.com> (raw) In-Reply-To: <20210330173348.30135-1-p.yadav@ti.com> This resets the stream state machines and FIFOs, giving them a clean slate. On J721E if the streams are not reset before starting the capture, the captured frame gets wrapped around vertically on every run after the first. Signed-off-by: Pratyush Yadav <p.yadav@ti.com> --- drivers/media/platform/cadence/cdns-csi2rx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index 31bd80e3f780..b03d2d2e6762 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -39,6 +39,7 @@ #define CSI2RX_STREAM_BASE(n) (((n) + 1) * 0x100) #define CSI2RX_STREAM_CTRL_REG(n) (CSI2RX_STREAM_BASE(n) + 0x000) +#define CSI2RX_STREAM_CTRL_SOFT_RST BIT(4) #define CSI2RX_STREAM_CTRL_START BIT(0) #define CSI2RX_STREAM_DATA_CFG_REG(n) (CSI2RX_STREAM_BASE(n) + 0x008) @@ -150,12 +151,22 @@ struct csi2rx_priv *v4l2_subdev_to_csi2rx(struct v4l2_subdev *subdev) static void csi2rx_reset(struct csi2rx_priv *csi2rx) { + int i; + writel(CSI2RX_SOFT_RESET_PROTOCOL | CSI2RX_SOFT_RESET_FRONT, csi2rx->base + CSI2RX_SOFT_RESET_REG); udelay(10); writel(0, csi2rx->base + CSI2RX_SOFT_RESET_REG); + + /* Reset individual streams. */ + for (i = 0; i < csi2rx->max_streams; i++) { + writel(CSI2RX_STREAM_CTRL_SOFT_RST, + csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + usleep_range(10, 20); + writel(0, csi2rx->base + CSI2RX_STREAM_CTRL_REG(i)); + } } static int csi2rx_configure_external_dphy(struct csi2rx_priv *csi2rx) -- 2.30.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-03-30 17:35 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-30 17:33 [PATCH 00/16] CSI2RX support on J721E Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 01/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 02/16] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 03/16] phy: cdns-dphy: Allow setting mode Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:38 ` Laurent Pinchart 2021-04-02 10:38 ` Laurent Pinchart 2021-04-06 18:22 ` Pratyush Yadav 2021-04-06 18:22 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 04/16] phy: cdns-dphy: Add Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 05/16] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 9:24 ` Chunfeng Yun 2021-03-31 9:24 ` Chunfeng Yun 2021-04-06 18:54 ` Pratyush Yadav 2021-04-06 18:54 ` Pratyush Yadav 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:22 ` Tomi Valkeinen 2021-04-08 8:22 ` Tomi Valkeinen 2021-03-30 17:33 ` Pratyush Yadav [this message] 2021-03-30 17:33 ` [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav 2021-03-30 17:33 ` [PATCH 07/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 08/16] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:55 ` Laurent Pinchart 2021-04-02 10:55 ` Laurent Pinchart 2021-04-06 17:53 ` Pratyush Yadav 2021-04-06 17:53 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:47 ` Laurent Pinchart 2021-04-02 10:47 ` Laurent Pinchart 2021-04-06 15:11 ` Pratyush Yadav 2021-04-06 15:11 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 19:13 ` Péter Ujfalusi 2021-04-06 19:13 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 13:40 ` Rob Herring 2021-03-31 13:40 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-03-30 17:33 ` [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:50 ` Laurent Pinchart 2021-03-31 15:50 ` Laurent Pinchart 2021-04-06 15:05 ` Pratyush Yadav 2021-04-06 15:05 ` Pratyush Yadav 2021-04-04 13:38 ` Péter Ujfalusi 2021-04-04 13:38 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:23 ` Laurent Pinchart 2021-04-02 10:23 ` Laurent Pinchart 2021-04-06 18:51 ` Pratyush Yadav 2021-04-06 18:51 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:31 ` Laurent Pinchart 2021-04-02 10:31 ` Laurent Pinchart 2021-04-06 18:48 ` Pratyush Yadav 2021-04-06 18:48 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: add power-domains property Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns, dphy: " Pratyush Yadav 2021-04-02 10:35 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: " Laurent Pinchart 2021-04-02 10:35 ` Laurent Pinchart 2021-04-06 18:23 ` Pratyush Yadav 2021-04-06 18:23 ` Pratyush Yadav 2021-03-31 9:33 ` [PATCH 00/16] CSI2RX support on J721E Vinod Koul 2021-03-31 9:33 ` Vinod Koul 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:51 ` Pratyush Yadav 2021-03-31 13:51 ` Pratyush Yadav 2021-04-02 10:57 ` Laurent Pinchart 2021-04-02 10:57 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210330173348.30135-7-p.yadav@ti.com \ --to=p.yadav@ti.com \ --cc=acourbot@chromium.org \ --cc=bparrot@ti.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=helen.koike@collabora.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kishon@ti.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=m.tretter@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=peter.chen@nxp.com \ --cc=peter.ujfalusi@gmail.com \ --cc=robh+dt@kernel.org \ --cc=stanimir.varbanov@linaro.org \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.