From: Mark Brown <broonie@kernel.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: Enabling pmbus power control
Date: Tue, 30 Mar 2021 18:42:21 +0100 [thread overview]
Message-ID: <20210330174221.GJ4976@sirena.org.uk> (raw)
In-Reply-To: <YGNdoYq5lyERVGLO@hatter.bewilderbeest.net>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Tue, Mar 30, 2021 at 12:19:29PM -0500, Zev Weiss wrote:
> On Tue, Mar 30, 2021 at 06:22:54AM CDT, Mark Brown wrote:
> > On Tue, Mar 30, 2021 at 03:34:16AM -0700, Guenter Roeck wrote:
> > > (and I don't know if the userspace consumer code is appropriate - you
> > > might want to check with the regulator maintainer on that).
> > It's not, you should never see this in a production system.
> Sorry, can you clarify what exactly "this" refers to here?
The userspace consumer.
> > I can't really tell what the issue is here without more context, the
> > global name list should not be relevant for much in a system that's well
> > configured so it sounds like it's user error.
> My initial attempt I guess followed the existing ltc2978 code a little too
> closely and I ended up with all my lm25066 regulators registered under the
> same (static) name, so when I went to attach the reg-userspace-consumer
> instances to them by way of that name I got this:
I don't know what you're trying to do or why, nor how you're going about
achieving it so I can't really comment. Like I say anything that's
instantiating a userspace consumer in upstream code is broken, it's
there for test during development of regulator drivers. Whatever device
is supplied by the regulator should have a driver which should control
the regulator at runtime if that is needed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: Enabling pmbus power control
Date: Tue, 30 Mar 2021 18:42:21 +0100 [thread overview]
Message-ID: <20210330174221.GJ4976@sirena.org.uk> (raw)
In-Reply-To: <YGNdoYq5lyERVGLO@hatter.bewilderbeest.net>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Tue, Mar 30, 2021 at 12:19:29PM -0500, Zev Weiss wrote:
> On Tue, Mar 30, 2021 at 06:22:54AM CDT, Mark Brown wrote:
> > On Tue, Mar 30, 2021 at 03:34:16AM -0700, Guenter Roeck wrote:
> > > (and I don't know if the userspace consumer code is appropriate - you
> > > might want to check with the regulator maintainer on that).
> > It's not, you should never see this in a production system.
> Sorry, can you clarify what exactly "this" refers to here?
The userspace consumer.
> > I can't really tell what the issue is here without more context, the
> > global name list should not be relevant for much in a system that's well
> > configured so it sounds like it's user error.
> My initial attempt I guess followed the existing ltc2978 code a little too
> closely and I ended up with all my lm25066 regulators registered under the
> same (static) name, so when I went to attach the reg-userspace-consumer
> instances to them by way of that name I got this:
I don't know what you're trying to do or why, nor how you're going about
achieving it so I can't really comment. Like I say anything that's
instantiating a userspace consumer in upstream code is broken, it's
there for test during development of regulator drivers. Whatever device
is supplied by the regulator should have a driver which should control
the regulator at runtime if that is needed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-30 17:43 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 8:17 Enabling pmbus power control Zev Weiss
2021-03-30 8:17 ` Zev Weiss
2021-03-30 10:34 ` Guenter Roeck
2021-03-30 10:34 ` Guenter Roeck
2021-03-30 11:22 ` Mark Brown
2021-03-30 11:22 ` Mark Brown
2021-03-30 17:19 ` Zev Weiss
2021-03-30 17:19 ` Zev Weiss
2021-03-30 17:42 ` Mark Brown [this message]
2021-03-30 17:42 ` Mark Brown
2021-03-30 17:56 ` Zev Weiss
2021-03-30 17:56 ` Zev Weiss
2021-03-30 18:02 ` Mark Brown
2021-03-30 18:02 ` Mark Brown
2021-03-30 19:38 ` Guenter Roeck
2021-03-30 19:38 ` Guenter Roeck
2021-04-20 1:29 ` Zev Weiss
2021-04-20 1:29 ` Zev Weiss
2021-04-20 3:36 ` Guenter Roeck
2021-04-20 3:36 ` Guenter Roeck
2021-04-20 5:50 ` Zev Weiss
2021-04-20 5:50 ` Zev Weiss
2021-04-20 6:00 ` Guenter Roeck
2021-04-20 6:00 ` Guenter Roeck
2021-04-20 7:06 ` Zev Weiss
2021-04-20 7:06 ` Zev Weiss
2021-04-20 10:52 ` Guenter Roeck
2021-04-20 10:52 ` Guenter Roeck
2021-04-20 15:19 ` Zev Weiss
2021-04-20 15:19 ` Zev Weiss
2021-04-20 16:13 ` Mark Brown
2021-04-20 16:13 ` Mark Brown
2021-04-20 16:40 ` Zev Weiss
2021-04-20 16:40 ` Zev Weiss
2021-04-20 17:15 ` Mark Brown
2021-04-20 17:15 ` Mark Brown
2021-04-20 18:54 ` Zev Weiss
2021-04-20 18:54 ` Zev Weiss
2021-04-21 11:05 ` Mark Brown
2021-04-21 11:05 ` Mark Brown
2021-04-21 18:29 ` Zev Weiss
2021-04-21 18:29 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330174221.GJ4976@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@aj.id.au \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.