From: Jakub Kicinski <kuba@kernel.org>
To: Ong Boon Leong <boon.leong.ong@intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] net: stmmac: Add support for XDP_TX action
Date: Tue, 30 Mar 2021 19:48:39 -0700 [thread overview]
Message-ID: <20210330194839.0b8596f2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210330024949.14010-6-boon.leong.ong@intel.com>
On Tue, 30 Mar 2021 10:49:48 +0800 Ong Boon Leong wrote:
> + __netif_tx_lock(nq, cpu);
> + res = stmmac_xdp_xmit_xdpf(priv, queue, xdpf);
> + if (res == STMMAC_XDP_TX) {
> + stmmac_flush_tx_descriptors(priv, queue);
> + stmmac_tx_timer_arm(priv, queue);
> + }
> + __netif_tx_unlock(nq);
You may want to update nq->trans_start, see commit ec107e775d843
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ong Boon Leong <boon.leong.ong@intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] net: stmmac: Add support for XDP_TX action
Date: Tue, 30 Mar 2021 19:48:39 -0700 [thread overview]
Message-ID: <20210330194839.0b8596f2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210330024949.14010-6-boon.leong.ong@intel.com>
On Tue, 30 Mar 2021 10:49:48 +0800 Ong Boon Leong wrote:
> + __netif_tx_lock(nq, cpu);
> + res = stmmac_xdp_xmit_xdpf(priv, queue, xdpf);
> + if (res == STMMAC_XDP_TX) {
> + stmmac_flush_tx_descriptors(priv, queue);
> + stmmac_tx_timer_arm(priv, queue);
> + }
> + __netif_tx_unlock(nq);
You may want to update nq->trans_start, see commit ec107e775d843
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-31 2:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 2:49 [PATCH net-next v2 0/6] stmmac: Add XDP support Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-30 2:49 ` [PATCH net-next v2 1/6] net: stmmac: set IRQ affinity hint for multi MSI vectors Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-30 2:49 ` [PATCH net-next v2 2/6] net: stmmac: make SPH enable/disable to be configurable Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-30 2:49 ` [PATCH net-next v2 3/6] net: stmmac: arrange Tx tail pointer update to stmmac_flush_tx_descriptors Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-30 2:49 ` [PATCH net-next v2 4/6] net: stmmac: Add initial XDP support Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-31 2:42 ` Jakub Kicinski
2021-03-31 2:42 ` Jakub Kicinski
2021-03-30 2:49 ` [PATCH net-next v2 5/6] net: stmmac: Add support for XDP_TX action Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-31 2:48 ` Jakub Kicinski [this message]
2021-03-31 2:48 ` Jakub Kicinski
2021-03-30 2:49 ` [PATCH net-next v2 6/6] net: stmmac: Add support for XDP_REDIRECT action Ong Boon Leong
2021-03-30 2:49 ` Ong Boon Leong
2021-03-30 13:04 ` [PATCH net-next v2 0/6] stmmac: Add XDP support Jesper Dangaard Brouer
2021-03-30 13:04 ` Jesper Dangaard Brouer
2021-03-30 14:04 ` Ong, Boon Leong
2021-03-30 14:04 ` Ong, Boon Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330194839.0b8596f2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.