All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] efi_loader: Uart device path missing break
@ 2021-03-31  6:41 Heinrich Schuchardt
  2021-03-31  6:41 ` Heinrich Schuchardt
  0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2021-03-31  6:41 UTC (permalink / raw)
  To: u-boot

In the devicepath node to text conversion for Uart nodes a break statement
is missing.

Indicated by Coverity Scan CID 330038
Fixes: 62df6e9c9994 ("efi_loader: Uart device path")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/efi_loader/efi_device_path_to_text.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c
index 43554cd771..675e80bcb8 100644
--- a/lib/efi_loader/efi_device_path_to_text.c
+++ b/lib/efi_loader/efi_device_path_to_text.c
@@ -126,8 +126,10 @@ static char *dp_msging(char *s, struct efi_device_path *dp)
 		switch (uart->stop_bits) {
 		case 2:
 			s += sprintf(s, "1.5)");
+			break;
 		default:
 			s += sprintf(s, "%d)", uart->stop_bits);
+			break;
 		}
 		break;
 	}
--
2.30.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 1/1] efi_loader: Uart device path missing break
  2021-03-31  6:41 [PATCH 1/1] efi_loader: Uart device path missing break Heinrich Schuchardt
@ 2021-03-31  6:41 ` Heinrich Schuchardt
  0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2021-03-31  6:41 UTC (permalink / raw)
  To: u-boot

In the devicepath node to text conversion for Uart nodes a break statement
is missing.

Indicated by Coverity Scan CID 330038
Fixes: 62df6e9c9994 ("efi_loader: Uart device path")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/efi_loader/efi_device_path_to_text.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c
index 43554cd771..675e80bcb8 100644
--- a/lib/efi_loader/efi_device_path_to_text.c
+++ b/lib/efi_loader/efi_device_path_to_text.c
@@ -126,8 +126,10 @@ static char *dp_msging(char *s, struct efi_device_path *dp)
 		switch (uart->stop_bits) {
 		case 2:
 			s += sprintf(s, "1.5)");
+			break;
 		default:
 			s += sprintf(s, "%d)", uart->stop_bits);
+			break;
 		}
 		break;
 	}
--
2.30.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-31  6:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31  6:41 [PATCH 1/1] efi_loader: Uart device path missing break Heinrich Schuchardt
2021-03-31  6:41 ` Heinrich Schuchardt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.