From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, kernel@pengutronix.de,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v4 6/6] spi: davinci: Simplify using devm_clk_get_enabled()
Date: Wed, 31 Mar 2021 13:02:12 +0100 [thread overview]
Message-ID: <20210331120212.GB4758@sirena.org.uk> (raw)
In-Reply-To: <20210330181755.204339-7-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
On Tue, Mar 30, 2021 at 08:17:55PM +0200, Uwe Kleine-König wrote:
> devm_clk_get_enabled() returns the clk already (prepared and) enabled
> and the automatically called cleanup cares for disabling (and
> unpreparing). So simplify .probe() and .remove() accordingly.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2021-03-31 12:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 18:17 [PATCH v4 0/6] clk: provide new devm helpers for prepared and enabled clocks Uwe Kleine-König
2021-03-30 18:17 ` Uwe Kleine-König
2021-03-30 18:17 ` [PATCH v4 1/6] clk: generalize devm_clk_get() a bit Uwe Kleine-König
2021-03-30 18:17 ` Uwe Kleine-König
2021-03-30 18:17 ` [PATCH v4 2/6] clk: Provide new devm_clk_helpers for prepared and enabled clocks Uwe Kleine-König
2021-03-30 18:17 ` Uwe Kleine-König
2021-03-30 18:17 ` [PATCH v4 3/6] pwm: atmel: Simplify using devm_clk_get_prepared() Uwe Kleine-König
2021-03-30 18:17 ` Uwe Kleine-König
2021-04-06 12:45 ` Nicolas Ferre
2021-04-06 12:45 ` Nicolas Ferre
2021-03-30 18:17 ` [PATCH v4 4/6] rtc: at91sma9: Simplify using devm_clk_get_enabled() Uwe Kleine-König
2021-03-30 18:17 ` Uwe Kleine-König
2021-04-06 12:55 ` Nicolas Ferre
2021-04-06 12:55 ` Nicolas Ferre
2021-03-30 18:17 ` [PATCH v4 5/6] i2c: imx: Simplify using devm_clk_get_enableded() Uwe Kleine-König
2021-03-30 18:17 ` Uwe Kleine-König
2021-04-06 6:43 ` Uwe Kleine-König
2021-04-06 6:43 ` Uwe Kleine-König
2021-04-06 6:46 ` [PATCH v4.1 " Uwe Kleine-König
2021-04-06 6:46 ` Uwe Kleine-König
2021-04-06 7:12 ` Oleksij Rempel
2021-04-06 7:12 ` Oleksij Rempel
2021-04-06 20:29 ` Wolfram Sang
2021-04-06 20:29 ` Wolfram Sang
2021-03-30 18:17 ` [PATCH v4 6/6] spi: davinci: Simplify using devm_clk_get_enabled() Uwe Kleine-König
2021-03-31 12:02 ` Mark Brown [this message]
2021-04-06 6:57 ` Uwe Kleine-König
2021-04-07 7:00 ` Geert Uytterhoeven
2021-04-07 7:24 ` Uwe Kleine-König
2021-04-07 11:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331120212.GB4758@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.