Re: [PATCH v4 6/6] spi: davinci: Simplify using devm_clk_get_enabled() - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, kernel@pengutronix.de,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v4 6/6] spi: davinci: Simplify using devm_clk_get_enabled()
Date: Tue, 6 Apr 2021 08:57:27 +0200	[thread overview]
Message-ID: <20210406065727.i7wbve2ihdblq24p@pengutronix.de> (raw)
In-Reply-To: <20210331120212.GB4758@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hello Mark,

On Wed, Mar 31, 2021 at 01:02:12PM +0100, Mark Brown wrote:
> On Tue, Mar 30, 2021 at 08:17:55PM +0200, Uwe Kleine-König wrote:
> > devm_clk_get_enabled() returns the clk already (prepared and) enabled
> > and the automatically called cleanup cares for disabling (and
> > unpreparing). So simplify .probe() and .remove() accordingly.
> 
> Acked-by: Mark Brown <broonie@kernel.org>

Thanks. I wonder what you think about this series. Is it more "Well, ok,
if you must, the change you did to this spi driver looks correct." or
"This is a good simplification and a similar change for nearly all other
spi drivers that make use of a clk is possible, too. Dear clk
maintainers, please go forward and apply this useful series."?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]