* [PATCH] staging: emxx_udc: Ending line with argument
@ 2021-04-01 19:54 Beatriz Martins de Carvalho
2021-04-01 21:16 ` Julia Lawall
0 siblings, 1 reply; 7+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-01 19:54 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel; +Cc: outreachy-kernel
Cleans up check of "Lines should not end with a '('"
with argument present in next line in file emxx_udc.c
Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 741147a4f0fe..20f53cf6e20f 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
i_word_length = length / sizeof(u32);
if (i_word_length > 0) {
for (i = 0; i < i_word_length; i++) {
- _nbu2ss_writel(
- &preg->EP_REGS[ep->epnum - 1].EP_WRITE,
- p_buf_32->dw);
+ _nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+ p_buf_32->dw);
p_buf_32++;
}
@@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep)
return;
if (ep->epnum > 0) {
- length = _nbu2ss_readl(
- &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
+ length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
length &= EPN_LDATA;
if (length < ep->ep.maxpacket)
@@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc,
for (limit_cnt = 0
; limit_cnt < IN_DATA_EMPTY_COUNT
; limit_cnt++) {
- regdata = _nbu2ss_readl(
- &preg->EP_REGS[ep->epnum - 1].EP_STATUS);
+ regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
if ((regdata & EPN_IN_DATA) == 0)
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument 2021-04-01 19:54 [PATCH] staging: emxx_udc: Ending line with argument Beatriz Martins de Carvalho @ 2021-04-01 21:16 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2021-04-01 21:16 UTC (permalink / raw) To: Beatriz Martins de Carvalho Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: > Cleans up check of "Lines should not end with a '('" > with argument present in next line in file emxx_udc.c The coding style documentation encourages remaining within 80 characters. I'm not sure that the ( warning is worth increading the excess beyond 80 characters (or introducing it in the last case). julia > > Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> > --- > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 741147a4f0fe..20f53cf6e20f 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, > i_word_length = length / sizeof(u32); > if (i_word_length > 0) { > for (i = 0; i < i_word_length; i++) { > - _nbu2ss_writel( > - &preg->EP_REGS[ep->epnum - 1].EP_WRITE, > - p_buf_32->dw); > + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1].EP_WRITE, > + p_buf_32->dw); > > p_buf_32++; > } > @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep) > return; > > if (ep->epnum > 0) { > - length = _nbu2ss_readl( > - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > > length &= EPN_LDATA; > if (length < ep->ep.maxpacket) > @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc, > for (limit_cnt = 0 > ; limit_cnt < IN_DATA_EMPTY_COUNT > ; limit_cnt++) { > - regdata = _nbu2ss_readl( > - &preg->EP_REGS[ep->epnum - 1].EP_STATUS); > + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS); > > if ((regdata & EPN_IN_DATA) == 0) > break; > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument @ 2021-04-01 21:16 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2021-04-01 21:16 UTC (permalink / raw) To: Beatriz Martins de Carvalho Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: > Cleans up check of "Lines should not end with a '('" > with argument present in next line in file emxx_udc.c The coding style documentation encourages remaining within 80 characters. I'm not sure that the ( warning is worth increading the excess beyond 80 characters (or introducing it in the last case). julia > > Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> > --- > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 741147a4f0fe..20f53cf6e20f 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, > i_word_length = length / sizeof(u32); > if (i_word_length > 0) { > for (i = 0; i < i_word_length; i++) { > - _nbu2ss_writel( > - &preg->EP_REGS[ep->epnum - 1].EP_WRITE, > - p_buf_32->dw); > + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1].EP_WRITE, > + p_buf_32->dw); > > p_buf_32++; > } > @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep) > return; > > if (ep->epnum > 0) { > - length = _nbu2ss_readl( > - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > > length &= EPN_LDATA; > if (length < ep->ep.maxpacket) > @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc, > for (limit_cnt = 0 > ; limit_cnt < IN_DATA_EMPTY_COUNT > ; limit_cnt++) { > - regdata = _nbu2ss_readl( > - &preg->EP_REGS[ep->epnum - 1].EP_STATUS); > + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS); > > if ((regdata & EPN_IN_DATA) == 0) > break; > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument 2021-04-01 21:16 ` Julia Lawall (?) @ 2021-04-05 14:07 ` Beatriz Martins de Carvalho 2021-04-05 15:09 ` Julia Lawall -1 siblings, 1 reply; 7+ messages in thread From: Beatriz Martins de Carvalho @ 2021-04-05 14:07 UTC (permalink / raw) To: Julia Lawall; +Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel Em 01/04/21 22:16, Julia Lawall escreveu: > > On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: > >> Cleans up check of "Lines should not end with a '('" >> with argument present in next line in file emxx_udc.c > The coding style documentation encourages remaining within 80 characters. > I'm not sure that the ( warning is worth increading the excess beyond 80 > characters (or introducing it in the last case). > > julia Thanks, prof Julia, how the checkpath now warning only if line length of 100 characters, I used it for reference. I will take the suggestions of checkpatch with more attention. Beatriz >> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> >> --- >> drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c >> index 741147a4f0fe..20f53cf6e20f 100644 >> --- a/drivers/staging/emxx_udc/emxx_udc.c >> +++ b/drivers/staging/emxx_udc/emxx_udc.c >> @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, >> i_word_length = length / sizeof(u32); >> if (i_word_length > 0) { >> for (i = 0; i < i_word_length; i++) { >> - _nbu2ss_writel( >> - &preg->EP_REGS[ep->epnum - 1].EP_WRITE, >> - p_buf_32->dw); >> + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1].EP_WRITE, >> + p_buf_32->dw); >> >> p_buf_32++; >> } >> @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep) >> return; >> >> if (ep->epnum > 0) { >> - length = _nbu2ss_readl( >> - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); >> + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); >> >> length &= EPN_LDATA; >> if (length < ep->ep.maxpacket) >> @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc, >> for (limit_cnt = 0 >> ; limit_cnt < IN_DATA_EMPTY_COUNT >> ; limit_cnt++) { >> - regdata = _nbu2ss_readl( >> - &preg->EP_REGS[ep->epnum - 1].EP_STATUS); >> + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS); >> >> if ((regdata & EPN_IN_DATA) == 0) >> break; >> -- >> 2.25.1 >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument 2021-04-05 14:07 ` Beatriz Martins de Carvalho @ 2021-04-05 15:09 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2021-04-05 15:09 UTC (permalink / raw) To: Beatriz Martins de Carvalho Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote: > > Em 01/04/21 22:16, Julia Lawall escreveu: > > > > On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: > > > > > Cleans up check of "Lines should not end with a '('" > > > with argument present in next line in file emxx_udc.c > > The coding style documentation encourages remaining within 80 characters. > > I'm not sure that the ( warning is worth increading the excess beyond 80 > > characters (or introducing it in the last case). > > > > julia > Thanks, prof Julia, how the checkpath now warning only if line length of 100 > characters, I used it for reference. I think it was changed so that people would leave as is code that was really more readable at 85 or 90 characters. But the documentation still encourages 80 characters. julia > > I will take the suggestions of checkpatch with more attention. > > Beatriz > > > > Signed-off-by: Beatriz Martins de Carvalho > > > <martinsdecarvalhobeatriz@gmail.com> > > > --- > > > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > > > b/drivers/staging/emxx_udc/emxx_udc.c > > > index 741147a4f0fe..20f53cf6e20f 100644 > > > --- a/drivers/staging/emxx_udc/emxx_udc.c > > > +++ b/drivers/staging/emxx_udc/emxx_udc.c > > > @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc > > > *udc, struct nbu2ss_ep *ep, > > > i_word_length = length / sizeof(u32); > > > if (i_word_length > 0) { > > > for (i = 0; i < i_word_length; i++) { > > > - _nbu2ss_writel( > > > - &preg->EP_REGS[ep->epnum - > > > 1].EP_WRITE, > > > - p_buf_32->dw); > > > + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - > > > 1].EP_WRITE, > > > + p_buf_32->dw); > > > > > > p_buf_32++; > > > } > > > @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct > > > nbu2ss_ep *ep) > > > return; > > > > > > if (ep->epnum > 0) { > > > - length = _nbu2ss_readl( > > > - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > > > + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - > > > 1].EP_LEN_DCNT); > > > > > > length &= EPN_LDATA; > > > if (length < ep->ep.maxpacket) > > > @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc > > > *udc, > > > for (limit_cnt = 0 > > > ; limit_cnt < IN_DATA_EMPTY_COUNT > > > ; limit_cnt++) { > > > - regdata = _nbu2ss_readl( > > > - &preg->EP_REGS[ep->epnum - 1].EP_STATUS); > > > + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - > > > 1].EP_STATUS); > > > > > > if ((regdata & EPN_IN_DATA) == 0) > > > break; > > > -- > > > 2.25.1 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an > > > email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. > > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/82580331-13dc-ed79-72e7-3984fd2f75f9%40gmail.com. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument @ 2021-04-05 15:09 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2021-04-05 15:09 UTC (permalink / raw) To: Beatriz Martins de Carvalho Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote: > > Em 01/04/21 22:16, Julia Lawall escreveu: > > > > On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: > > > > > Cleans up check of "Lines should not end with a '('" > > > with argument present in next line in file emxx_udc.c > > The coding style documentation encourages remaining within 80 characters. > > I'm not sure that the ( warning is worth increading the excess beyond 80 > > characters (or introducing it in the last case). > > > > julia > Thanks, prof Julia, how the checkpath now warning only if line length of 100 > characters, I used it for reference. I think it was changed so that people would leave as is code that was really more readable at 85 or 90 characters. But the documentation still encourages 80 characters. julia > > I will take the suggestions of checkpatch with more attention. > > Beatriz > > > > Signed-off-by: Beatriz Martins de Carvalho > > > <martinsdecarvalhobeatriz@gmail.com> > > > --- > > > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > > > b/drivers/staging/emxx_udc/emxx_udc.c > > > index 741147a4f0fe..20f53cf6e20f 100644 > > > --- a/drivers/staging/emxx_udc/emxx_udc.c > > > +++ b/drivers/staging/emxx_udc/emxx_udc.c > > > @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc > > > *udc, struct nbu2ss_ep *ep, > > > i_word_length = length / sizeof(u32); > > > if (i_word_length > 0) { > > > for (i = 0; i < i_word_length; i++) { > > > - _nbu2ss_writel( > > > - &preg->EP_REGS[ep->epnum - > > > 1].EP_WRITE, > > > - p_buf_32->dw); > > > + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - > > > 1].EP_WRITE, > > > + p_buf_32->dw); > > > > > > p_buf_32++; > > > } > > > @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct > > > nbu2ss_ep *ep) > > > return; > > > > > > if (ep->epnum > 0) { > > > - length = _nbu2ss_readl( > > > - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); > > > + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - > > > 1].EP_LEN_DCNT); > > > > > > length &= EPN_LDATA; > > > if (length < ep->ep.maxpacket) > > > @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc > > > *udc, > > > for (limit_cnt = 0 > > > ; limit_cnt < IN_DATA_EMPTY_COUNT > > > ; limit_cnt++) { > > > - regdata = _nbu2ss_readl( > > > - &preg->EP_REGS[ep->epnum - 1].EP_STATUS); > > > + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - > > > 1].EP_STATUS); > > > > > > if ((regdata & EPN_IN_DATA) == 0) > > > break; > > > -- > > > 2.25.1 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an > > > email to outreachy-kernel+unsubscribe@googlegroups.com. > > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. > > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/82580331-13dc-ed79-72e7-3984fd2f75f9%40gmail.com. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Ending line with argument 2021-04-05 15:09 ` Julia Lawall (?) @ 2021-04-07 10:12 ` Beatriz Martins de Carvalho -1 siblings, 0 replies; 7+ messages in thread From: Beatriz Martins de Carvalho @ 2021-04-07 10:12 UTC (permalink / raw) To: Julia Lawall; +Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel [-- Attachment #1: Type: text/plain, Size: 3809 bytes --] Em 05/04/21 16:09, Julia Lawall escreveu: > > > On Mon, 5 Apr 2021, Beatriz Martins de Carvalho wrote: > >> >> Em 01/04/21 22:16, Julia Lawall escreveu: >>> >>> On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote: >>> >>>> Cleans up check of "Lines should not end with a '('" with >>>> argument present in next line in file emxx_udc.c >>> The coding style documentation encourages remaining within 80 >>> characters. I'm not sure that the ( warning is worth increading >>> the excess beyond 80 characters (or introducing it in the last >>> case). >>> >>> julia >> Thanks, prof Julia, how the checkpath now warning only if line >> length of 100 characters, I used it for reference. > > I think it was changed so that people would leave as is code that > was really more readable at 85 or 90 characters. But the > documentation still encourages 80 characters. > > julia Prof Julia, I didn't fix up my patch based on your comments, because to do this was to revert all my patch or will break a code line if I remaining within 80 characters. How the code line still stays between 85 or 90 I assumed that was ok stay in this format. What should I do with the patch? One thing I will do, it improves the subject, but about the code style? > >> >> I will take the suggestions of checkpatch with more attention. >> >> Beatriz >> >>>> Signed-off-by: Beatriz Martins de Carvalho >>>> <martinsdecarvalhobeatriz@gmail.com> --- >>>> drivers/staging/emxx_udc/emxx_udc.c | 11 ++++------- 1 file >>>> changed, 4 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/drivers/staging/emxx_udc/emxx_udc.c >>>> b/drivers/staging/emxx_udc/emxx_udc.c index >>>> 741147a4f0fe..20f53cf6e20f 100644 --- >>>> a/drivers/staging/emxx_udc/emxx_udc.c +++ >>>> b/drivers/staging/emxx_udc/emxx_udc.c @@ -1073,9 +1073,8 @@ >>>> static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct >>>> nbu2ss_ep *ep, i_word_length = length / sizeof(u32); if >>>> (i_word_length > 0) { for (i = 0; i < i_word_length; i++) { - >>>> _nbu2ss_writel( - &preg->EP_REGS[ep->epnum - 1].EP_WRITE, - >>>> p_buf_32->dw); + _nbu2ss_writel(&preg->EP_REGS[ep->epnum - >>>> 1].EP_WRITE, + p_buf_32->dw); >>>> >>>> p_buf_32++; } @@ -1225,8 +1224,7 @@ static void >>>> _nbu2ss_restert_transfer(struct nbu2ss_ep *ep) return; >>>> >>>> if (ep->epnum > 0) { - length = _nbu2ss_readl( - >>>> &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT); + >>>> length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - >>>> 1].EP_LEN_DCNT); >>>> >>>> length &= EPN_LDATA; if (length < ep->ep.maxpacket) @@ -1462,8 >>>> +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc >>>> *udc, for (limit_cnt = 0 ; limit_cnt < IN_DATA_EMPTY_COUNT ; >>>> limit_cnt++) { - regdata = _nbu2ss_readl( - >>>> &preg->EP_REGS[ep->epnum - 1].EP_STATUS); + regdata = >>>> _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS); >>>> >>>> if ((regdata & EPN_IN_DATA) == 0) break; -- 2.25.1 >>>> >>>> -- You received this message because you are subscribed to the >>>> Google Groups "outreachy-kernel" group. To unsubscribe from >>>> this group and stop receiving emails from it, send an email to >>>> outreachy-kernel+unsubscribe@googlegroups.com. To view this >>>> discussion on the web visit >>>> https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com. >>>> >> >> >>>> -- >> You received this message because you are subscribed to the Google >> Groups "outreachy-kernel" group. To unsubscribe from this group and >> stop receiving emails from it, send an email to >> outreachy-kernel+unsubscribe@googlegroups.com. To view this >> discussion on the web visit >> https://groups.google.com/d/msgid/outreachy-kernel/82580331-13dc-ed79-72e7-3984fd2f75f9%40gmail.com. >> [-- Attachment #2: Type: text/html, Size: 5700 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-07 10:12 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-01 19:54 [PATCH] staging: emxx_udc: Ending line with argument Beatriz Martins de Carvalho 2021-04-01 21:16 ` [Outreachy kernel] " Julia Lawall 2021-04-01 21:16 ` Julia Lawall 2021-04-05 14:07 ` Beatriz Martins de Carvalho 2021-04-05 15:09 ` Julia Lawall 2021-04-05 15:09 ` Julia Lawall 2021-04-07 10:12 ` Beatriz Martins de Carvalho
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.