All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel <alsa-devel@alsa-project.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 2/2] ASoC: dt-bindings: renesas, rsnd: Clear warning 'ports' does not match any of the regexes
Date: Thu, 1 Apr 2021 15:20:56 -0500	[thread overview]
Message-ID: <20210401202056.GA947212@robh.at.kernel.org> (raw)
In-Reply-To: <20210331091616.2306-3-thunder.leizhen@huawei.com>

On Wed, Mar 31, 2021 at 05:16:16PM +0800, Zhen Lei wrote:
> Currently, if there are more than two ports, or if there is only one port
> but other properties(such as "#address-cells") is required, these ports
> are placed under the "ports" node. So add the schema of property "ports".

A given binding should just use 'ports' or 'port' depending on it's 
need. Supporting both forms is needless complexity.

> Otherwise, warnings similar to the following will be reported:
> arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dt.yaml: \
> sound@ec500000: 'ports' does not match any of the regexes: \
> '^rcar_sound,ctu$', '^rcar_sound,dai$', '^rcar_sound,dvc$', ...
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 384191ee497f534..a42992fa687d3f3 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -115,6 +115,11 @@ properties:
>      $ref: audio-graph-port.yaml#
>      unevaluatedProperties: false
>  
> +  ports:

       $ref: /schemas/graph.yaml#/properties/ports

> +    patternProperties:
> +      '^port@[0-9]':
> +        $ref: "#/properties/port"

Then this should be: $ref: audio-graph-port.yaml#

Also, what each port is should be defined, but that's a separate 
problem.

> +
>  # use patternProperties to avoid naming "xxx,yyy" issue
>  patternProperties:
>    "^rcar_sound,dvc$":
> -- 
> 1.8.3
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	alsa-devel <alsa-devel@alsa-project.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 2/2] ASoC: dt-bindings: renesas, rsnd: Clear warning 'ports' does not match any of the regexes
Date: Thu, 1 Apr 2021 15:20:56 -0500	[thread overview]
Message-ID: <20210401202056.GA947212@robh.at.kernel.org> (raw)
In-Reply-To: <20210331091616.2306-3-thunder.leizhen@huawei.com>

On Wed, Mar 31, 2021 at 05:16:16PM +0800, Zhen Lei wrote:
> Currently, if there are more than two ports, or if there is only one port
> but other properties(such as "#address-cells") is required, these ports
> are placed under the "ports" node. So add the schema of property "ports".

A given binding should just use 'ports' or 'port' depending on it's 
need. Supporting both forms is needless complexity.

> Otherwise, warnings similar to the following will be reported:
> arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dt.yaml: \
> sound@ec500000: 'ports' does not match any of the regexes: \
> '^rcar_sound,ctu$', '^rcar_sound,dai$', '^rcar_sound,dvc$', ...
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 384191ee497f534..a42992fa687d3f3 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -115,6 +115,11 @@ properties:
>      $ref: audio-graph-port.yaml#
>      unevaluatedProperties: false
>  
> +  ports:

       $ref: /schemas/graph.yaml#/properties/ports

> +    patternProperties:
> +      '^port@[0-9]':
> +        $ref: "#/properties/port"

Then this should be: $ref: audio-graph-port.yaml#

Also, what each port is should be defined, but that's a separate 
problem.

> +
>  # use patternProperties to avoid naming "xxx,yyy" issue
>  patternProperties:
>    "^rcar_sound,dvc$":
> -- 
> 1.8.3
> 
> 

  reply	other threads:[~2021-04-01 20:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  9:16 [PATCH v2 0/2] clean up dt_binding_check and dtbs_check warnings of renesas,rsnd.yaml Zhen Lei
2021-03-31  9:16 ` [PATCH v2 0/2] clean up dt_binding_check and dtbs_check warnings of renesas, rsnd.yaml Zhen Lei
2021-03-31  9:16 ` [PATCH v2 1/2] ASoC: dt-bindings: renesas, rsnd: Clear warning 'dais' is a required property Zhen Lei
2021-03-31  9:16   ` Zhen Lei
2021-03-31  9:16 ` [PATCH v2 2/2] ASoC: dt-bindings: renesas, rsnd: Clear warning 'ports' does not match any of the regexes Zhen Lei
2021-03-31  9:16   ` Zhen Lei
2021-04-01 20:20   ` Rob Herring [this message]
2021-04-01 20:20     ` Rob Herring
2021-04-07  2:04     ` Leizhen (ThunderTown)
2021-04-07  2:04       ` Leizhen (ThunderTown)
2021-04-08 12:28       ` Leizhen (ThunderTown)
2021-04-08 12:28         ` Leizhen (ThunderTown)
2021-04-08 20:42         ` Rob Herring
2021-04-08 20:42           ` Rob Herring
2021-04-12  6:45           ` Leizhen (ThunderTown)
2021-04-12  6:45             ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210401202056.GA947212@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.