[xlnx:xlnx_rebase_v5.4 217/1701] drivers/media/i2c/adv7511-v4l2.c:427:2: error: void function 'adv7511_set_rgb_quantization_mode' should not return a value

* [xlnx:xlnx_rebase_v5.4 217/1701] drivers/media/i2c/adv7511-v4l2.c:427:2: error: void function 'adv7511_set_rgb_quantization_mode' should not return a value
@ 2021-04-01 19:16 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-01 19:16 UTC (permalink / raw)
  To: Radhey Shyam Pandey
  Cc: kbuild-all, clang-built-linux, linux-arm-kernel, Michal Simek,
	Davor Joja

[-- Attachment #1: Type: text/plain, Size: 3325 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head:   8540825db3d5519ef205a710515b7819b95eeb4f
commit: 9836a252284b997aacd6b86766514a0bb84b4f43 [217/1701] drivers: media: Customized adv7511 for Xylon LogiCVC (deprecated)
config: x86_64-randconfig-a004-20210401 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/Xilinx/linux-xlnx/commit/9836a252284b997aacd6b86766514a0bb84b4f43
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx xlnx_rebase_v5.4
        git checkout 9836a252284b997aacd6b86766514a0bb84b4f43
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/media/i2c/adv7511-v4l2.c:427:2: error: void function 'adv7511_set_rgb_quantization_mode' should not return a value [-Wreturn-type]
           return 0;
           ^      ~
>> drivers/media/i2c/adv7511-v4l2.c:2251:21: warning: no previous prototype for function 'adv7511_subdev' [-Wmissing-prototypes]
   struct v4l2_subdev *adv7511_subdev(struct v4l2_subdev *sd)
                       ^
   drivers/media/i2c/adv7511-v4l2.c:2251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct v4l2_subdev *adv7511_subdev(struct v4l2_subdev *sd)
   ^
   static 
   1 warning and 1 error generated.

vim +/adv7511_set_rgb_quantization_mode +427 drivers/media/i2c/adv7511-v4l2.c

   421	
   422	static void adv7511_set_rgb_quantization_mode(struct v4l2_subdev *sd, struct v4l2_ctrl *ctrl)
   423	{
   424		struct adv7511_state *state = get_adv7511_state(sd);
   425	
   426	#ifdef XYLON_LOGICVC_INTG
 > 427		return 0;
   428	#endif
   429	
   430		/* Only makes sense for RGB formats */
   431		if (state->fmt_code != MEDIA_BUS_FMT_RGB888_1X24) {
   432			/* so just keep quantization */
   433			adv7511_csc_rgb_full2limit(sd, false);
   434			return;
   435		}
   436	
   437		switch (ctrl->val) {
   438		case V4L2_DV_RGB_RANGE_AUTO:
   439			/* automatic */
   440			if (state->dv_timings.bt.flags & V4L2_DV_FL_IS_CE_VIDEO) {
   441				/* CE format, RGB limited range (16-235) */
   442				adv7511_csc_rgb_full2limit(sd, true);
   443			} else {
   444				/* not CE format, RGB full range (0-255) */
   445				adv7511_csc_rgb_full2limit(sd, false);
   446			}
   447			break;
   448		case V4L2_DV_RGB_RANGE_LIMITED:
   449			/* RGB limited range (16-235) */
   450			adv7511_csc_rgb_full2limit(sd, true);
   451			break;
   452		case V4L2_DV_RGB_RANGE_FULL:
   453			/* RGB full range (0-255) */
   454			adv7511_csc_rgb_full2limit(sd, false);
   455			break;
   456		}
   457	}
   458	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29120 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread