All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@nxp.com>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	lgirdwood@gmail.com, broonie@kernel.org, arnd@arndb.de,
	peng.fan@nxp.com, Anson.Huang@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] Add imx8m power domain driver
Date: Fri, 2 Apr 2021 20:42:28 +0300	[thread overview]
Message-ID: <20210402174228.wjl6paul5hxu7dnx@fsr-ub1664-175> (raw)
In-Reply-To: <20210402164506.520121-1-adrien.grassein@gmail.com>

On 21-04-02 18:45:04, Adrien Grassein wrote:
> Hi,
> 
> this patch et aims to add the support of the i.MX 8 Power Domain driver.
> Some devices (like usbotg2) can't work without this patch as their
> attached power domain are down.
> 
> The original drivr was taken from le imx kernel and aapted to fit with
> the actual mainline (minor fixes).
> 
> Thanks,
> 

Big NACK for the whole series.

This approach has already been rejected upstream.

Plus, you changed the original author, this work was originally done by Jacky Bai.

> Adrien Grassein (2):
>   dt-bindings: power: Add documentation for imx8m power domain driver
>   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> 
>  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
>  MAINTAINERS                                   |  10 +
>  drivers/soc/imx/Kconfig                       |   7 +
>  drivers/soc/imx/Makefile                      |   1 +
>  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
>  include/dt-bindings/power/imx8mm-power.h      |  21 ++
>  include/dt-bindings/power/imx8mn-power.h      |  15 ++
>  include/dt-bindings/power/imx8mp-power.h      |  28 +++
>  include/soc/imx/imx_sip.h                     |  12 +
>  9 files changed, 416 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
>  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
>  create mode 100644 include/dt-bindings/power/imx8mm-power.h
>  create mode 100644 include/dt-bindings/power/imx8mn-power.h
>  create mode 100644 include/dt-bindings/power/imx8mp-power.h
>  create mode 100644 include/soc/imx/imx_sip.h
> 
> -- 
> 2.25.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	lgirdwood@gmail.com, broonie@kernel.org, arnd@arndb.de,
	peng.fan@nxp.com, Anson.Huang@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] Add imx8m power domain driver
Date: Fri, 2 Apr 2021 20:42:28 +0300	[thread overview]
Message-ID: <20210402174228.wjl6paul5hxu7dnx@fsr-ub1664-175> (raw)
In-Reply-To: <20210402164506.520121-1-adrien.grassein@gmail.com>

On 21-04-02 18:45:04, Adrien Grassein wrote:
> Hi,
> 
> this patch et aims to add the support of the i.MX 8 Power Domain driver.
> Some devices (like usbotg2) can't work without this patch as their
> attached power domain are down.
> 
> The original drivr was taken from le imx kernel and aapted to fit with
> the actual mainline (minor fixes).
> 
> Thanks,
> 

Big NACK for the whole series.

This approach has already been rejected upstream.

Plus, you changed the original author, this work was originally done by Jacky Bai.

> Adrien Grassein (2):
>   dt-bindings: power: Add documentation for imx8m power domain driver
>   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> 
>  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
>  MAINTAINERS                                   |  10 +
>  drivers/soc/imx/Kconfig                       |   7 +
>  drivers/soc/imx/Makefile                      |   1 +
>  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
>  include/dt-bindings/power/imx8mm-power.h      |  21 ++
>  include/dt-bindings/power/imx8mn-power.h      |  15 ++
>  include/dt-bindings/power/imx8mp-power.h      |  28 +++
>  include/soc/imx/imx_sip.h                     |  12 +
>  9 files changed, 416 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
>  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
>  create mode 100644 include/dt-bindings/power/imx8mm-power.h
>  create mode 100644 include/dt-bindings/power/imx8mn-power.h
>  create mode 100644 include/dt-bindings/power/imx8mp-power.h
>  create mode 100644 include/soc/imx/imx_sip.h
> 
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-04-02 17:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02 16:45 [PATCH v1 0/2] Add imx8m power domain driver Adrien Grassein
2021-04-02 16:45 ` Adrien Grassein
2021-04-02 16:45 ` [PATCH v1 1/2] dt-bindings: power: Add documentation for " Adrien Grassein
2021-04-02 16:45   ` Adrien Grassein
2021-04-02 16:45 ` [PATCH v1 2/2] soc: imx: add Power Domain driver for i.MX8M(M|N|P) Adrien Grassein
2021-04-02 16:45   ` Adrien Grassein
2021-04-02 21:26   ` kernel test robot
2021-04-02 17:42 ` Abel Vesa [this message]
2021-04-02 17:42   ` [PATCH v1 0/2] Add imx8m power domain driver Abel Vesa
2021-04-02 17:48   ` Adrien Grassein
2021-04-02 17:48     ` Adrien Grassein
2021-04-02 17:58     ` Abel Vesa
2021-04-02 17:58       ` Abel Vesa
2021-04-02 18:11       ` Adrien Grassein
2021-04-02 18:11         ` Adrien Grassein
2021-04-02 22:09         ` Adam Ford
2021-04-02 22:09           ` Adam Ford
2021-04-02 22:26           ` Adrien Grassein
2021-04-02 22:26             ` Adrien Grassein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210402174228.wjl6paul5hxu7dnx@fsr-ub1664-175 \
    --to=abel.vesa@nxp.com \
    --cc=Anson.Huang@nxp.com \
    --cc=adrien.grassein@gmail.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.