* [jimc:lkp-test/drm-dd 2/3] arch/parisc/include/asm/jump_label.h:18:4: error: expected ':' before '__stringify'
@ 2021-04-02 14:47 kernel test robot
2021-04-07 2:45 ` jim.cromie
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-04-02 14:47 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4368 bytes --]
tree: https://github.com/jimc/linux.git lkp-test/drm-dd
head: 631cbfbef77d556648bcef9f7d77beef4d2c8574
commit: f3e32c5e7ddb7d259eccbfe8cdf635a198df7a71 [2/3] drm: RFC switch drm.debug to use dynamic debug
config: parisc-randconfig-r025-20210402 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jimc/linux/commit/f3e32c5e7ddb7d259eccbfe8cdf635a198df7a71
git remote add jimc https://github.com/jimc/linux.git
git fetch --no-tags jimc lkp-test/drm-dd
git checkout f3e32c5e7ddb7d259eccbfe8cdf635a198df7a71
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/compiler_types.h:85,
from <command-line>:
arch/parisc/include/asm/jump_label.h: In function 'arch_static_branch':
>> arch/parisc/include/asm/jump_label.h:18:4: error: expected ':' before '__stringify'
18 | __stringify(ASM_ULONG_INSN) " %c0 - .\n\t"
| ^~~~~~~~~~~
include/linux/compiler-gcc.h:91:47: note: in definition of macro 'asm_volatile_goto'
91 | #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while (0)
| ^
In file included from include/linux/jump_label.h:117,
from include/linux/dynamic_debug.h:6,
from drivers/gpu/drm/drm_print.c:31:
arch/parisc/include/asm/jump_label.h:23:1: warning: label 'l_yes' defined but not used [-Wunused-label]
23 | l_yes:
| ^~~~~
In file included from include/linux/compiler_types.h:85,
from <command-line>:
arch/parisc/include/asm/jump_label.h: In function 'arch_static_branch_jump':
arch/parisc/include/asm/jump_label.h:33:4: error: expected ':' before '__stringify'
33 | __stringify(ASM_ULONG_INSN) " %c0 - .\n\t"
| ^~~~~~~~~~~
include/linux/compiler-gcc.h:91:47: note: in definition of macro 'asm_volatile_goto'
91 | #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while (0)
| ^
In file included from include/linux/jump_label.h:117,
from include/linux/dynamic_debug.h:6,
from drivers/gpu/drm/drm_print.c:31:
arch/parisc/include/asm/jump_label.h:38:1: warning: label 'l_yes' defined but not used [-Wunused-label]
38 | l_yes:
| ^~~~~
vim +18 arch/parisc/include/asm/jump_label.h
62217beb394e65 Helge Deller 2019-05-03 11
62217beb394e65 Helge Deller 2019-05-03 12 static __always_inline bool arch_static_branch(struct static_key *key, bool branch)
62217beb394e65 Helge Deller 2019-05-03 13 {
62217beb394e65 Helge Deller 2019-05-03 14 asm_volatile_goto("1:\n\t"
62217beb394e65 Helge Deller 2019-05-03 15 "nop\n\t"
62217beb394e65 Helge Deller 2019-05-03 16 ".pushsection __jump_table, \"aw\"\n\t"
62217beb394e65 Helge Deller 2019-05-03 17 ".word 1b - ., %l[l_yes] - .\n\t"
62217beb394e65 Helge Deller 2019-05-03 @18 __stringify(ASM_ULONG_INSN) " %c0 - .\n\t"
62217beb394e65 Helge Deller 2019-05-03 19 ".popsection\n\t"
62217beb394e65 Helge Deller 2019-05-03 20 : : "i" (&((char *)key)[branch]) : : l_yes);
62217beb394e65 Helge Deller 2019-05-03 21
62217beb394e65 Helge Deller 2019-05-03 22 return false;
62217beb394e65 Helge Deller 2019-05-03 23 l_yes:
62217beb394e65 Helge Deller 2019-05-03 24 return true;
62217beb394e65 Helge Deller 2019-05-03 25 }
62217beb394e65 Helge Deller 2019-05-03 26
:::::: The code at line 18 was first introduced by commit
:::::: 62217beb394e654bbd2bb87c533dadd2d8bf62c6 parisc: Add static branch and JUMP_LABEL feature
:::::: TO: Helge Deller <deller@gmx.de>
:::::: CC: Helge Deller <deller@gmx.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35164 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [jimc:lkp-test/drm-dd 2/3] arch/parisc/include/asm/jump_label.h:18:4: error: expected ':' before '__stringify'
2021-04-02 14:47 [jimc:lkp-test/drm-dd 2/3] arch/parisc/include/asm/jump_label.h:18:4: error: expected ':' before '__stringify' kernel test robot
@ 2021-04-07 2:45 ` jim.cromie
0 siblings, 0 replies; 2+ messages in thread
From: jim.cromie @ 2021-04-07 2:45 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]
On Fri, Apr 2, 2021 at 8:48 AM kernel test robot <lkp@intel.com> wrote:
> tree: https://github.com/jimc/linux.git lkp-test/drm-dd
> head: 631cbfbef77d556648bcef9f7d77beef4d2c8574
> commit: f3e32c5e7ddb7d259eccbfe8cdf635a198df7a71 [2/3] drm: RFC switch
> drm.debug to use dynamic debug
> config: parisc-randconfig-r025-20210402 (attached as .config)
> compiler: hppa-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
> https://github.com/jimc/linux/commit/f3e32c5e7ddb7d259eccbfe8cdf635a198df7a71
> git remote add jimc https://github.com/jimc/linux.git
> git fetch --no-tags jimc lkp-test/drm-dd
> git checkout f3e32c5e7ddb7d259eccbfe8cdf635a198df7a71
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> ARCH=parisc
>
>
I have reproduced this.
So I compared the before/after on intermediate files
sdiff -lw300 drivers/gpu/drm/drm_print.i \
../../../wk-test/builds/parisc-1/drivers/gpu/drm/drm_print.i |
less +/static_branch
and the obvious thing is the header include is much earlier in the broken
version.
so I moved the include down and out to drm_print.h
this fixed the immediate problem, so I'm rerolling
for another run through lkp-test
If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 2690 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-07 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 14:47 [jimc:lkp-test/drm-dd 2/3] arch/parisc/include/asm/jump_label.h:18:4: error: expected ':' before '__stringify' kernel test robot
2021-04-07 2:45 ` jim.cromie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.