[meta-virtualization][PATCH 1/2] packagegroup-kubernets: add seccomp to REQUIRED_DISTRO_FEATURES

[meta-virtualization][PATCH 1/2] packagegroup-kubernets: add seccomp to REQUIRED_DISTRO_FEATURES

[Martin Jansa]

* fixes world build:
ERROR: Nothing RPROVIDES 'k3s-server' (but meta-virtualization/recipes-core/packagegroups/packagegroup-kubernetes.bb RDEPENDS on or otherwise requires it)
k3s RPROVIDES k3s-server but was skipped: missing required distro feature 'seccomp' (not in DISTRO_FEATURES)
NOTE: Runtime target 'k3s-server' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['k3s-server']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'packagegroup-kubernetes', 'k3s-server']

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-core/packagegroups/packagegroup-kubernetes.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/recipes-core/packagegroups/packagegroup-kubernetes.bb b/recipes-core/packagegroups/packagegroup-kubernetes.bb
index ec528e0..237e72e 100644
--- a/recipes-core/packagegroups/packagegroup-kubernetes.bb
+++ b/recipes-core/packagegroups/packagegroup-kubernetes.bb
@@ -4,6 +4,10 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
 
 inherit packagegroup
 
+# k3s has this restriction
+inherit features_check
+REQUIRED_DISTRO_FEATURES ?= "seccomp"
+
 PACKAGES = "\
     packagegroup-kubernetes-base \
     packagegroup-k8s-host \
-- 
2.30.2

[meta-virtualization][PATCH 2/2] packagegroup-container: skip without meta-security because of podman

[Martin Jansa]

* copy the skip from podman recipe, because this packagegroup
  depends on podman

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-core/packagegroups/packagegroup-container.bb | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/recipes-core/packagegroups/packagegroup-container.bb b/recipes-core/packagegroups/packagegroup-container.bb
index d425ac5..b3b0d4c 100644
--- a/recipes-core/packagegroups/packagegroup-container.bb
+++ b/recipes-core/packagegroups/packagegroup-container.bb
@@ -44,3 +44,12 @@ RDEPENDS_packagegroup-containerd = " \
     virtual/containerd \
 "
 
+python __anonymous() {
+    msg = ""
+    # ERROR: Nothing PROVIDES 'libseccomp' (but meta-virtualization/recipes-containers/podman/ DEPENDS on or otherwise requires it).
+    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
+    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'podman', 'libseccomp']
+    if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
+        msg += "Make sure meta-security should be present as it provides 'libseccomp'"
+        raise bb.parse.SkipRecipe(msg)
+}
-- 
2.30.2

Re: [meta-virtualization][PATCH 2/2] packagegroup-container: skip without meta-security because of podman

[akuster]

On 4/2/21 12:02 AM, Martin Jansa wrote:
> * copy the skip from podman recipe, because this packagegroup
>   depends on podman
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  recipes-core/packagegroups/packagegroup-container.bb | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/recipes-core/packagegroups/packagegroup-container.bb b/recipes-core/packagegroups/packagegroup-container.bb
> index d425ac5..b3b0d4c 100644
> --- a/recipes-core/packagegroups/packagegroup-container.bb
> +++ b/recipes-core/packagegroups/packagegroup-container.bb
> @@ -44,3 +44,12 @@ RDEPENDS_packagegroup-containerd = " \
>      virtual/containerd \
>  "
>  
> +python __anonymous() {
> +    msg = ""
> +    # ERROR: Nothing PROVIDES 'libseccomp' (but meta-virtualization/recipes-containers/podman/ DEPENDS on or otherwise requires it).
> +    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> +    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'podman', 'libseccomp']
> +    if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
> +        msg += "Make sure meta-security should be present as it provides 'libseccomp'"
> +        raise bb.parse.SkipRecipe(msg)
> +}

That reminds me that the libsecomp pkg should move to meta-oe so this
other layers don't have to do these kinds of things.

-armin
>
> 
>

Re: [meta-virtualization][PATCH 2/2] packagegroup-container: skip without meta-security because of podman

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

On Fri, Apr 02, 2021 at 11:32:14AM -0700, akuster808 wrote:
> 
> 
> On 4/2/21 12:02 AM, Martin Jansa wrote:
> > * copy the skip from podman recipe, because this packagegroup
> >   depends on podman
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  recipes-core/packagegroups/packagegroup-container.bb | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/recipes-core/packagegroups/packagegroup-container.bb b/recipes-core/packagegroups/packagegroup-container.bb
> > index d425ac5..b3b0d4c 100644
> > --- a/recipes-core/packagegroups/packagegroup-container.bb
> > +++ b/recipes-core/packagegroups/packagegroup-container.bb
> > @@ -44,3 +44,12 @@ RDEPENDS_packagegroup-containerd = " \
> >      virtual/containerd \
> >  "
> >
> > +python __anonymous() {
> > +    msg = ""
> > +    # ERROR: Nothing PROVIDES 'libseccomp' (but meta-virtualization/recipes-containers/podman/ DEPENDS on or otherwise requires it).
> > +    # ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > +    # Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'podman', 'libseccomp']
> > +    if 'security' not in d.getVar('BBFILE_COLLECTIONS').split():
> > +        msg += "Make sure meta-security should be present as it provides 'libseccomp'"
> > +        raise bb.parse.SkipRecipe(msg)
> > +}
> 
> That reminds me that the libsecomp pkg should move to meta-oe so this
> other layers don't have to do these kinds of things.

there are also nagios recipes depending on meta-webserver which is
listed in LAYERRECOMMENDS_virtualization-layer but it would be better to
skip them like this when meta-webserver isn't included as well.

> 
> -armin
> >
> > 
> >
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-virtualization][PATCH 1/2] packagegroup-kubernets: add seccomp to REQUIRED_DISTRO_FEATURES

[Bruce Ashfield]

Thanks Martin,

This is now merged.

Bruce

In message: [meta-virtualization][PATCH 1/2] packagegroup-kubernets: add seccomp to REQUIRED_DISTRO_FEATURES
on 02/04/2021 Martin Jansa wrote:

> * fixes world build:
> ERROR: Nothing RPROVIDES 'k3s-server' (but meta-virtualization/recipes-core/packagegroups/packagegroup-kubernetes.bb RDEPENDS on or otherwise requires it)
> k3s RPROVIDES k3s-server but was skipped: missing required distro feature 'seccomp' (not in DISTRO_FEATURES)
> NOTE: Runtime target 'k3s-server' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['k3s-server']
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'packagegroup-kubernetes', 'k3s-server']
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  recipes-core/packagegroups/packagegroup-kubernetes.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/recipes-core/packagegroups/packagegroup-kubernetes.bb b/recipes-core/packagegroups/packagegroup-kubernetes.bb
> index ec528e0..237e72e 100644
> --- a/recipes-core/packagegroups/packagegroup-kubernetes.bb
> +++ b/recipes-core/packagegroups/packagegroup-kubernetes.bb
> @@ -4,6 +4,10 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
>  
>  inherit packagegroup
>  
> +# k3s has this restriction
> +inherit features_check
> +REQUIRED_DISTRO_FEATURES ?= "seccomp"
> +
>  PACKAGES = "\
>      packagegroup-kubernetes-base \
>      packagegroup-k8s-host \
> -- 
> 2.30.2
> 

> 
> 
>