From: kernel test robot <lkp@intel.com> To: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org Cc: kbuild-all@lists.01.org Subject: Re: [PATCH 6/7] xfs: remove XFS_IFINLINE Date: Sat, 3 Apr 2021 11:31:17 +0800 [thread overview] Message-ID: <202104031134.aKlv2gye-lkp@intel.com> (raw) In-Reply-To: <20210402142409.372050-7-hch@lst.de> [-- Attachment #1: Type: text/plain, Size: 4929 bytes --] Hi Christoph, I love your patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/xfs-move-the-XFS_IFEXTENTS-check-into-xfs_iread_extents/20210402-232422 base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next config: microblaze-randconfig-r036-20210401 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3a376a77f4296e338a26df75eb05a1b7ae0def2a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christoph-Hellwig/xfs-move-the-XFS_IFEXTENTS-check-into-xfs_iread_extents/20210402-232422 git checkout 3a376a77f4296e338a26df75eb05a1b7ae0def2a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_iops.c:6: fs/xfs/xfs_iops.c: In function 'xfs_vn_get_link_inline': >> fs/xfs/xfs_iops.c:522:9: error: 'dp' undeclared (first use in this function); did you mean 'ip'? 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_iops.c:522:2: note: in expansion of macro 'ASSERT' 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~~~~~ fs/xfs/xfs_iops.c:522:9: note: each undeclared identifier is reported only once for each function it appears in 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_iops.c:522:2: note: in expansion of macro 'ASSERT' 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~~~~~ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_symlink.c:7: fs/xfs/xfs_symlink.c: In function 'xfs_readlink': >> fs/xfs/xfs_symlink.c:107:9: error: 'dp' undeclared (first use in this function); did you mean 'mp'? 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_symlink.c:107:2: note: in expansion of macro 'ASSERT' 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~~~~~ fs/xfs/xfs_symlink.c:107:9: note: each undeclared identifier is reported only once for each function it appears in 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_symlink.c:107:2: note: in expansion of macro 'ASSERT' 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~~~~~ vim +522 fs/xfs/xfs_iops.c 512 513 STATIC const char * 514 xfs_vn_get_link_inline( 515 struct dentry *dentry, 516 struct inode *inode, 517 struct delayed_call *done) 518 { 519 struct xfs_inode *ip = XFS_I(inode); 520 char *link; 521 > 522 ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); 523 524 /* 525 * The VFS crashes on a NULL pointer, so return -EFSCORRUPTED if 526 * if_data is junk. 527 */ 528 link = ip->i_df.if_u1.if_data; 529 if (XFS_IS_CORRUPT(ip->i_mount, !link)) 530 return ERR_PTR(-EFSCORRUPTED); 531 return link; 532 } 533 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 28131 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 6/7] xfs: remove XFS_IFINLINE Date: Sat, 03 Apr 2021 11:31:17 +0800 [thread overview] Message-ID: <202104031134.aKlv2gye-lkp@intel.com> (raw) In-Reply-To: <20210402142409.372050-7-hch@lst.de> [-- Attachment #1: Type: text/plain, Size: 5039 bytes --] Hi Christoph, I love your patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/xfs-move-the-XFS_IFEXTENTS-check-into-xfs_iread_extents/20210402-232422 base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next config: microblaze-randconfig-r036-20210401 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3a376a77f4296e338a26df75eb05a1b7ae0def2a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christoph-Hellwig/xfs-move-the-XFS_IFEXTENTS-check-into-xfs_iread_extents/20210402-232422 git checkout 3a376a77f4296e338a26df75eb05a1b7ae0def2a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_iops.c:6: fs/xfs/xfs_iops.c: In function 'xfs_vn_get_link_inline': >> fs/xfs/xfs_iops.c:522:9: error: 'dp' undeclared (first use in this function); did you mean 'ip'? 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_iops.c:522:2: note: in expansion of macro 'ASSERT' 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~~~~~ fs/xfs/xfs_iops.c:522:9: note: each undeclared identifier is reported only once for each function it appears in 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_iops.c:522:2: note: in expansion of macro 'ASSERT' 522 | ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); | ^~~~~~ -- In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_symlink.c:7: fs/xfs/xfs_symlink.c: In function 'xfs_readlink': >> fs/xfs/xfs_symlink.c:107:9: error: 'dp' undeclared (first use in this function); did you mean 'mp'? 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_symlink.c:107:2: note: in expansion of macro 'ASSERT' 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~~~~~ fs/xfs/xfs_symlink.c:107:9: note: each undeclared identifier is reported only once for each function it appears in 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~ include/linux/compiler.h:77:40: note: in definition of macro 'likely' 77 | # define likely(x) __builtin_expect(!!(x), 1) | ^ fs/xfs/xfs_symlink.c:107:2: note: in expansion of macro 'ASSERT' 107 | ASSERT(dp->i_df.if_format != XFS_DINODE_FMT_LOCAL); | ^~~~~~ vim +522 fs/xfs/xfs_iops.c 512 513 STATIC const char * 514 xfs_vn_get_link_inline( 515 struct dentry *dentry, 516 struct inode *inode, 517 struct delayed_call *done) 518 { 519 struct xfs_inode *ip = XFS_I(inode); 520 char *link; 521 > 522 ASSERT(dp->i_df.if_format == XFS_DINODE_FMT_LOCAL); 523 524 /* 525 * The VFS crashes on a NULL pointer, so return -EFSCORRUPTED if 526 * if_data is junk. 527 */ 528 link = ip->i_df.if_u1.if_data; 529 if (XFS_IS_CORRUPT(ip->i_mount, !link)) 530 return ERR_PTR(-EFSCORRUPTED); 531 return link; 532 } 533 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 28131 bytes --]
next prev parent reply other threads:[~2021-04-03 3:32 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-02 14:24 RFC: remove the if_flags field in struct xfs_ifork Christoph Hellwig 2021-04-02 14:24 ` [PATCH 1/7] xfs: move the XFS_IFEXTENTS check into xfs_iread_extents Christoph Hellwig 2021-04-05 16:33 ` Brian Foster 2021-04-06 13:51 ` Darrick J. Wong 2021-04-06 13:54 ` Christoph Hellwig 2021-04-02 14:24 ` [PATCH 2/7] xfs: rename and simplify xfs_bmap_one_block Christoph Hellwig 2021-04-05 16:33 ` Brian Foster 2021-04-02 14:24 ` [PATCH 3/7] xfs: simplify xfs_attr_remove_args Christoph Hellwig 2021-04-05 16:33 ` Brian Foster 2021-04-02 14:24 ` [PATCH 4/7] xfs: only look at the fork format in xfs_idestroy_fork Christoph Hellwig 2021-04-05 16:35 ` Brian Foster 2021-04-02 14:24 ` [PATCH 5/7] xfs: remove XFS_IFBROOT Christoph Hellwig 2021-04-02 14:24 ` [PATCH 6/7] xfs: remove XFS_IFINLINE Christoph Hellwig 2021-04-02 21:48 ` kernel test robot 2021-04-02 21:48 ` kernel test robot 2021-04-03 3:31 ` kernel test robot [this message] 2021-04-03 3:31 ` kernel test robot 2021-04-02 14:24 ` [PATCH 7/7] xfs: remove XFS_IFEXTENTS Christoph Hellwig 2021-04-12 13:38 remove the if_flags field in struct xfs_ifork Christoph Hellwig 2021-04-12 13:38 ` [PATCH 6/7] xfs: remove XFS_IFINLINE Christoph Hellwig 2021-04-12 16:03 ` Brian Foster 2021-04-14 0:33 ` Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202104031134.aKlv2gye-lkp@intel.com \ --to=lkp@intel.com \ --cc=hch@lst.de \ --cc=kbuild-all@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.