* [PATCH 1/3] board: freescale: imxrt1020-evk: fix console is not enabled while init dram
@ 2021-04-04 18:21 Giulio Benetti
2021-04-04 18:21 ` [PATCH 2/3] board: freescale: imxrt1050-evk: " Giulio Benetti
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Giulio Benetti @ 2021-04-04 18:21 UTC (permalink / raw)
To: u-boot
While initializing dram in spl_dram_init(), mdelay() is called that in
order calls get_ticks() that verifies if timer exists, if doesn't, it
throws a panic(), but since preloader_console_init() has still not been
called those panic()s will fail. This doesn't help debugging, so let's
setup console before calling spl_dram_init() by moving it after
spl_dram_init().
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
board/freescale/imxrt1020-evk/imxrt1020-evk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/imxrt1020-evk/imxrt1020-evk.c b/board/freescale/imxrt1020-evk/imxrt1020-evk.c
index 35241acd22..479e66bddc 100644
--- a/board/freescale/imxrt1020-evk/imxrt1020-evk.c
+++ b/board/freescale/imxrt1020-evk/imxrt1020-evk.c
@@ -60,8 +60,8 @@ int spl_dram_init(void)
void spl_board_init(void)
{
- spl_dram_init();
preloader_console_init();
+ spl_dram_init();
arch_cpu_init(); /* to configure mpu for sdram rw permissions */
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] board: freescale: imxrt1050-evk: fix console is not enabled while init dram
2021-04-04 18:21 [PATCH 1/3] board: freescale: imxrt1020-evk: fix console is not enabled while init dram Giulio Benetti
@ 2021-04-04 18:21 ` Giulio Benetti
2021-04-08 20:59 ` sbabic at denx.de
2021-04-04 18:21 ` [PATCH 3/3] board: st: stm32f746-disco: " Giulio Benetti
2021-04-08 20:58 ` [PATCH 1/3] board: freescale: imxrt1020-evk: " sbabic at denx.de
2 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2021-04-04 18:21 UTC (permalink / raw)
To: u-boot
While initializing dram in spl_dram_init(), mdelay() is called that in
order calls get_ticks() that verifies if timer exists, if doesn't, it
throws a panic(), but since preloader_console_init() has still not been
called those panic()s will fail. This doesn't help debugging, so let's
setup console before calling spl_dram_init() by moving it after
spl_dram_init().
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
board/freescale/imxrt1050-evk/imxrt1050-evk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/imxrt1050-evk/imxrt1050-evk.c b/board/freescale/imxrt1050-evk/imxrt1050-evk.c
index b8d852f097..eb492390db 100644
--- a/board/freescale/imxrt1050-evk/imxrt1050-evk.c
+++ b/board/freescale/imxrt1050-evk/imxrt1050-evk.c
@@ -60,8 +60,8 @@ int spl_dram_init(void)
void spl_board_init(void)
{
- spl_dram_init();
preloader_console_init();
+ spl_dram_init();
arch_cpu_init(); /* to configure mpu for sdram rw permissions */
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] board: st: stm32f746-disco: fix console is not enabled while init dram
2021-04-04 18:21 [PATCH 1/3] board: freescale: imxrt1020-evk: fix console is not enabled while init dram Giulio Benetti
2021-04-04 18:21 ` [PATCH 2/3] board: freescale: imxrt1050-evk: " Giulio Benetti
@ 2021-04-04 18:21 ` Giulio Benetti
2021-04-08 20:58 ` sbabic at denx.de
2021-04-08 20:58 ` [PATCH 1/3] board: freescale: imxrt1020-evk: " sbabic at denx.de
2 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2021-04-04 18:21 UTC (permalink / raw)
To: u-boot
While initializing dram in spl_dram_init(), mdelay() is called that in
order calls get_ticks() that verifies if timer exists, if doesn't, it
throws a panic(), but since preloader_console_init() has still not been
called those panic()s will fail. This doesn't help debugging, so let's
setup console before calling spl_dram_init() by moving it after
spl_dram_init().
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
board/st/stm32f746-disco/stm32f746-disco.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/st/stm32f746-disco/stm32f746-disco.c b/board/st/stm32f746-disco/stm32f746-disco.c
index 143cc6e1ea..efa38a0e26 100644
--- a/board/st/stm32f746-disco/stm32f746-disco.c
+++ b/board/st/stm32f746-disco/stm32f746-disco.c
@@ -69,8 +69,8 @@ int spl_dram_init(void)
}
void spl_board_init(void)
{
- spl_dram_init();
preloader_console_init();
+ spl_dram_init();
arch_cpu_init(); /* to configure mpu for sdram rw permissions */
}
u32 spl_boot_device(void)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] board: st: stm32f746-disco: fix console is not enabled while init dram
2021-04-04 18:21 ` [PATCH 3/3] board: st: stm32f746-disco: " Giulio Benetti
@ 2021-04-08 20:58 ` sbabic at denx.de
0 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2021-04-08 20:58 UTC (permalink / raw)
To: u-boot
> While initializing dram in spl_dram_init(), mdelay() is called that in
> order calls get_ticks() that verifies if timer exists, if doesn't, it
> throws a panic(), but since preloader_console_init() has still not been
> called those panic()s will fail. This doesn't help debugging, so let's
> setup console before calling spl_dram_init() by moving it after
> spl_dram_init().
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] board: freescale: imxrt1020-evk: fix console is not enabled while init dram
2021-04-04 18:21 [PATCH 1/3] board: freescale: imxrt1020-evk: fix console is not enabled while init dram Giulio Benetti
2021-04-04 18:21 ` [PATCH 2/3] board: freescale: imxrt1050-evk: " Giulio Benetti
2021-04-04 18:21 ` [PATCH 3/3] board: st: stm32f746-disco: " Giulio Benetti
@ 2021-04-08 20:58 ` sbabic at denx.de
2 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2021-04-08 20:58 UTC (permalink / raw)
To: u-boot
> While initializing dram in spl_dram_init(), mdelay() is called that in
> order calls get_ticks() that verifies if timer exists, if doesn't, it
> throws a panic(), but since preloader_console_init() has still not been
> called those panic()s will fail. This doesn't help debugging, so let's
> setup console before calling spl_dram_init() by moving it after
> spl_dram_init().
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] board: freescale: imxrt1050-evk: fix console is not enabled while init dram
2021-04-04 18:21 ` [PATCH 2/3] board: freescale: imxrt1050-evk: " Giulio Benetti
@ 2021-04-08 20:59 ` sbabic at denx.de
0 siblings, 0 replies; 6+ messages in thread
From: sbabic at denx.de @ 2021-04-08 20:59 UTC (permalink / raw)
To: u-boot
> While initializing dram in spl_dram_init(), mdelay() is called that in
> order calls get_ticks() that verifies if timer exists, if doesn't, it
> throws a panic(), but since preloader_console_init() has still not been
> called those panic()s will fail. This doesn't help debugging, so let's
> setup console before calling spl_dram_init() by moving it after
> spl_dram_init().
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-08 20:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 18:21 [PATCH 1/3] board: freescale: imxrt1020-evk: fix console is not enabled while init dram Giulio Benetti
2021-04-04 18:21 ` [PATCH 2/3] board: freescale: imxrt1050-evk: " Giulio Benetti
2021-04-08 20:59 ` sbabic at denx.de
2021-04-04 18:21 ` [PATCH 3/3] board: st: stm32f746-disco: " Giulio Benetti
2021-04-08 20:58 ` sbabic at denx.de
2021-04-08 20:58 ` [PATCH 1/3] board: freescale: imxrt1020-evk: " sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.