* drivers/vdpa/mlx5/net/mlx5_vnet.c:614 umem_size() error: uninitialized symbol 'p_a'.
@ 2021-04-05 15:02 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-05 15:02 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 11258 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Eli Cohen <eli@mellanox.com>
CC: "Michael S. Tsirkin" <mst@redhat.com>
CC: Parav Pandit <parav@mellanox.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e49d033bddf5b565044e2abe4241353959bc9120
commit: 1a86b377aa2147a7c866b03142e848c18e5f3cb8 vdpa/mlx5: Add VDPA driver for supported mlx5 devices
date: 8 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 8 months ago
config: microblaze-randconfig-m031-20210405 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:614 umem_size() error: uninitialized symbol 'p_a'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:614 umem_size() error: uninitialized symbol 'p_b'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:696 umem_destroy() error: potentially dereferencing uninitialized 'umem'.
Old smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:219 print_features() warn: should '((((1))) << (57))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:220 print_features() warn: should '((((1))) << (60))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:221 print_features() warn: should '((((1))) << (61))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:222 print_features() warn: should '((((1))) << (62))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:223 print_features() warn: should '((((1))) << (63))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:226 print_features() warn: should '((((1))) << (32))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:227 print_features() warn: should '((((1))) << (33))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:228 print_features() warn: should '((((1))) << (34))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:229 print_features() warn: should '((((1))) << (36))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:230 print_features() warn: should '((((1))) << (37))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:870 alloc_inout() warn: variable dereferenced before check 'in' (see line 868)
drivers/vdpa/mlx5/net/mlx5_vnet.c:870 alloc_inout() warn: variable dereferenced before check 'out' (see line 869)
drivers/vdpa/mlx5/net/mlx5_vnet.c:882 alloc_inout() warn: variable dereferenced before check 'in' (see line 880)
drivers/vdpa/mlx5/net/mlx5_vnet.c:882 alloc_inout() warn: variable dereferenced before check 'out' (see line 881)
drivers/vdpa/mlx5/net/mlx5_vnet.c:899 alloc_inout() warn: variable dereferenced before check 'in' (see line 897)
drivers/vdpa/mlx5/net/mlx5_vnet.c:899 alloc_inout() warn: variable dereferenced before check 'out' (see line 898)
drivers/vdpa/mlx5/net/mlx5_vnet.c:917 alloc_inout() warn: variable dereferenced before check 'in' (see line 915)
drivers/vdpa/mlx5/net/mlx5_vnet.c:917 alloc_inout() warn: variable dereferenced before check 'out' (see line 916)
drivers/vdpa/mlx5/net/mlx5_vnet.c:1470 verify_min_features() warn: should '((((1))) << (33))' be a 64 bit type?
drivers/vdpa/mlx5/net/mlx5_vnet.c:1470 verify_min_features() warn: bitwise AND condition is false here
vim +/p_a +614 drivers/vdpa/mlx5/net/mlx5_vnet.c
1a86b377aa2147 Eli Cohen 2020-08-04 589
1a86b377aa2147 Eli Cohen 2020-08-04 590 static int umem_size(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *mvq, int num,
1a86b377aa2147 Eli Cohen 2020-08-04 591 struct mlx5_vdpa_umem **umemp)
1a86b377aa2147 Eli Cohen 2020-08-04 592 {
1a86b377aa2147 Eli Cohen 2020-08-04 593 struct mlx5_core_dev *mdev = ndev->mvdev.mdev;
1a86b377aa2147 Eli Cohen 2020-08-04 594 int p_a;
1a86b377aa2147 Eli Cohen 2020-08-04 595 int p_b;
1a86b377aa2147 Eli Cohen 2020-08-04 596
1a86b377aa2147 Eli Cohen 2020-08-04 597 switch (num) {
1a86b377aa2147 Eli Cohen 2020-08-04 598 case 1:
1a86b377aa2147 Eli Cohen 2020-08-04 599 p_a = MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_1_buffer_param_a);
1a86b377aa2147 Eli Cohen 2020-08-04 600 p_b = MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_1_buffer_param_b);
1a86b377aa2147 Eli Cohen 2020-08-04 601 *umemp = &mvq->umem1;
1a86b377aa2147 Eli Cohen 2020-08-04 602 break;
1a86b377aa2147 Eli Cohen 2020-08-04 603 case 2:
1a86b377aa2147 Eli Cohen 2020-08-04 604 p_a = MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_2_buffer_param_a);
1a86b377aa2147 Eli Cohen 2020-08-04 605 p_b = MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_2_buffer_param_b);
1a86b377aa2147 Eli Cohen 2020-08-04 606 *umemp = &mvq->umem2;
1a86b377aa2147 Eli Cohen 2020-08-04 607 break;
1a86b377aa2147 Eli Cohen 2020-08-04 608 case 3:
1a86b377aa2147 Eli Cohen 2020-08-04 609 p_a = MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_3_buffer_param_a);
1a86b377aa2147 Eli Cohen 2020-08-04 610 p_b = MLX5_CAP_DEV_VDPA_EMULATION(mdev, umem_3_buffer_param_b);
1a86b377aa2147 Eli Cohen 2020-08-04 611 *umemp = &mvq->umem3;
1a86b377aa2147 Eli Cohen 2020-08-04 612 break;
1a86b377aa2147 Eli Cohen 2020-08-04 613 }
1a86b377aa2147 Eli Cohen 2020-08-04 @614 return p_a * mvq->num_ent + p_b;
1a86b377aa2147 Eli Cohen 2020-08-04 615 }
1a86b377aa2147 Eli Cohen 2020-08-04 616
1a86b377aa2147 Eli Cohen 2020-08-04 617 static void umem_frag_buf_free(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_umem *umem)
1a86b377aa2147 Eli Cohen 2020-08-04 618 {
1a86b377aa2147 Eli Cohen 2020-08-04 619 mlx5_frag_buf_free(ndev->mvdev.mdev, &umem->frag_buf);
1a86b377aa2147 Eli Cohen 2020-08-04 620 }
1a86b377aa2147 Eli Cohen 2020-08-04 621
1a86b377aa2147 Eli Cohen 2020-08-04 622 static int create_umem(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *mvq, int num)
1a86b377aa2147 Eli Cohen 2020-08-04 623 {
1a86b377aa2147 Eli Cohen 2020-08-04 624 int inlen;
1a86b377aa2147 Eli Cohen 2020-08-04 625 u32 out[MLX5_ST_SZ_DW(create_umem_out)] = {};
1a86b377aa2147 Eli Cohen 2020-08-04 626 void *um;
1a86b377aa2147 Eli Cohen 2020-08-04 627 void *in;
1a86b377aa2147 Eli Cohen 2020-08-04 628 int err;
1a86b377aa2147 Eli Cohen 2020-08-04 629 __be64 *pas;
1a86b377aa2147 Eli Cohen 2020-08-04 630 int size;
1a86b377aa2147 Eli Cohen 2020-08-04 631 struct mlx5_vdpa_umem *umem;
1a86b377aa2147 Eli Cohen 2020-08-04 632
1a86b377aa2147 Eli Cohen 2020-08-04 633 size = umem_size(ndev, mvq, num, &umem);
1a86b377aa2147 Eli Cohen 2020-08-04 634 if (size < 0)
1a86b377aa2147 Eli Cohen 2020-08-04 635 return size;
1a86b377aa2147 Eli Cohen 2020-08-04 636
1a86b377aa2147 Eli Cohen 2020-08-04 637 umem->size = size;
1a86b377aa2147 Eli Cohen 2020-08-04 638 err = umem_frag_buf_alloc(ndev, umem, size);
1a86b377aa2147 Eli Cohen 2020-08-04 639 if (err)
1a86b377aa2147 Eli Cohen 2020-08-04 640 return err;
1a86b377aa2147 Eli Cohen 2020-08-04 641
1a86b377aa2147 Eli Cohen 2020-08-04 642 inlen = MLX5_ST_SZ_BYTES(create_umem_in) + MLX5_ST_SZ_BYTES(mtt) * umem->frag_buf.npages;
1a86b377aa2147 Eli Cohen 2020-08-04 643
1a86b377aa2147 Eli Cohen 2020-08-04 644 in = kzalloc(inlen, GFP_KERNEL);
1a86b377aa2147 Eli Cohen 2020-08-04 645 if (!in) {
1a86b377aa2147 Eli Cohen 2020-08-04 646 err = -ENOMEM;
1a86b377aa2147 Eli Cohen 2020-08-04 647 goto err_in;
1a86b377aa2147 Eli Cohen 2020-08-04 648 }
1a86b377aa2147 Eli Cohen 2020-08-04 649
1a86b377aa2147 Eli Cohen 2020-08-04 650 MLX5_SET(create_umem_in, in, opcode, MLX5_CMD_OP_CREATE_UMEM);
1a86b377aa2147 Eli Cohen 2020-08-04 651 MLX5_SET(create_umem_in, in, uid, ndev->mvdev.res.uid);
1a86b377aa2147 Eli Cohen 2020-08-04 652 um = MLX5_ADDR_OF(create_umem_in, in, umem);
1a86b377aa2147 Eli Cohen 2020-08-04 653 MLX5_SET(umem, um, log_page_size, umem->frag_buf.page_shift - MLX5_ADAPTER_PAGE_SHIFT);
1a86b377aa2147 Eli Cohen 2020-08-04 654 MLX5_SET64(umem, um, num_of_mtt, umem->frag_buf.npages);
1a86b377aa2147 Eli Cohen 2020-08-04 655
1a86b377aa2147 Eli Cohen 2020-08-04 656 pas = (__be64 *)MLX5_ADDR_OF(umem, um, mtt[0]);
1a86b377aa2147 Eli Cohen 2020-08-04 657 mlx5_fill_page_frag_array_perm(&umem->frag_buf, pas, MLX5_MTT_PERM_RW);
1a86b377aa2147 Eli Cohen 2020-08-04 658
1a86b377aa2147 Eli Cohen 2020-08-04 659 err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out));
1a86b377aa2147 Eli Cohen 2020-08-04 660 if (err) {
1a86b377aa2147 Eli Cohen 2020-08-04 661 mlx5_vdpa_warn(&ndev->mvdev, "create umem(%d)\n", err);
1a86b377aa2147 Eli Cohen 2020-08-04 662 goto err_cmd;
1a86b377aa2147 Eli Cohen 2020-08-04 663 }
1a86b377aa2147 Eli Cohen 2020-08-04 664
1a86b377aa2147 Eli Cohen 2020-08-04 665 kfree(in);
1a86b377aa2147 Eli Cohen 2020-08-04 666 umem->id = MLX5_GET(create_umem_out, out, umem_id);
1a86b377aa2147 Eli Cohen 2020-08-04 667
1a86b377aa2147 Eli Cohen 2020-08-04 668 return 0;
1a86b377aa2147 Eli Cohen 2020-08-04 669
1a86b377aa2147 Eli Cohen 2020-08-04 670 err_cmd:
1a86b377aa2147 Eli Cohen 2020-08-04 671 kfree(in);
1a86b377aa2147 Eli Cohen 2020-08-04 672 err_in:
1a86b377aa2147 Eli Cohen 2020-08-04 673 umem_frag_buf_free(ndev, umem);
1a86b377aa2147 Eli Cohen 2020-08-04 674 return err;
1a86b377aa2147 Eli Cohen 2020-08-04 675 }
1a86b377aa2147 Eli Cohen 2020-08-04 676
1a86b377aa2147 Eli Cohen 2020-08-04 677 static void umem_destroy(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue *mvq, int num)
1a86b377aa2147 Eli Cohen 2020-08-04 678 {
1a86b377aa2147 Eli Cohen 2020-08-04 679 u32 in[MLX5_ST_SZ_DW(destroy_umem_in)] = {};
1a86b377aa2147 Eli Cohen 2020-08-04 680 u32 out[MLX5_ST_SZ_DW(destroy_umem_out)] = {};
1a86b377aa2147 Eli Cohen 2020-08-04 681 struct mlx5_vdpa_umem *umem;
1a86b377aa2147 Eli Cohen 2020-08-04 682
1a86b377aa2147 Eli Cohen 2020-08-04 683 switch (num) {
1a86b377aa2147 Eli Cohen 2020-08-04 684 case 1:
1a86b377aa2147 Eli Cohen 2020-08-04 685 umem = &mvq->umem1;
1a86b377aa2147 Eli Cohen 2020-08-04 686 break;
1a86b377aa2147 Eli Cohen 2020-08-04 687 case 2:
1a86b377aa2147 Eli Cohen 2020-08-04 688 umem = &mvq->umem2;
1a86b377aa2147 Eli Cohen 2020-08-04 689 break;
1a86b377aa2147 Eli Cohen 2020-08-04 690 case 3:
1a86b377aa2147 Eli Cohen 2020-08-04 691 umem = &mvq->umem3;
1a86b377aa2147 Eli Cohen 2020-08-04 692 break;
1a86b377aa2147 Eli Cohen 2020-08-04 693 }
1a86b377aa2147 Eli Cohen 2020-08-04 694
1a86b377aa2147 Eli Cohen 2020-08-04 695 MLX5_SET(destroy_umem_in, in, opcode, MLX5_CMD_OP_DESTROY_UMEM);
1a86b377aa2147 Eli Cohen 2020-08-04 @696 MLX5_SET(destroy_umem_in, in, umem_id, umem->id);
1a86b377aa2147 Eli Cohen 2020-08-04 697 if (mlx5_cmd_exec(ndev->mvdev.mdev, in, sizeof(in), out, sizeof(out)))
1a86b377aa2147 Eli Cohen 2020-08-04 698 return;
1a86b377aa2147 Eli Cohen 2020-08-04 699
1a86b377aa2147 Eli Cohen 2020-08-04 700 umem_frag_buf_free(ndev, umem);
1a86b377aa2147 Eli Cohen 2020-08-04 701 }
1a86b377aa2147 Eli Cohen 2020-08-04 702
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27490 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-05 15:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 15:02 drivers/vdpa/mlx5/net/mlx5_vnet.c:614 umem_size() error: uninitialized symbol 'p_a' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.