[lunn:v5.12-rc4-net-next-netlink-sfp 8/9] drivers/net/phy/sfp.c:2333:5: sparse: sparse: symbol 'sfp_module_eeprom_by_page' was not declared. Should it be static?

[lunn:v5.12-rc4-net-next-netlink-sfp 8/9] drivers/net/phy/sfp.c:2333:5: sparse: sparse: symbol 'sfp_module_eeprom_by_page' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

tree:   https://github.com/lunn/linux.git v5.12-rc4-net-next-netlink-sfp
head:   262b3e781bca97735c172d22eb13811a095800df
commit: 9aec56dc8e7b241eff58faa5102ac7c4428aea33 [8/9] phy: sfp: add netlink SFP support to generic SFP code
config: x86_64-randconfig-s021-20210405 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-279-g6d5d9b42-dirty
        # https://github.com/lunn/linux/commit/9aec56dc8e7b241eff58faa5102ac7c4428aea33
        git remote add lunn https://github.com/lunn/linux.git
        git fetch --no-tags lunn v5.12-rc4-net-next-netlink-sfp
        git checkout 9aec56dc8e7b241eff58faa5102ac7c4428aea33
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/net/phy/sfp.c:2333:5: sparse: sparse: symbol 'sfp_module_eeprom_by_page' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33321 bytes --]

[RFC PATCH lunn] phy: sfp: sfp_module_eeprom_by_page() can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]


Fixes: 9aec56dc8e7b ("phy: sfp: add netlink SFP support to generic SFP code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 sfp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 54a6d8e5b34d3..d4d372a8e18ec 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -2330,9 +2330,9 @@ static int sfp_module_eeprom(struct sfp *sfp, struct ethtool_eeprom *ee,
 	return 0;
 }
 
-int sfp_module_eeprom_by_page(struct sfp *sfp,
-			      const struct ethtool_module_eeprom *page,
-			      struct netlink_ext_ack *extack)
+static int sfp_module_eeprom_by_page(struct sfp *sfp,
+				     const struct ethtool_module_eeprom *page,
+				     struct netlink_ext_ack *extack)
 {
 	if (page->bank) {
 		NL_SET_ERR_MSG(extack, "Banks not supported");