* [PATCH -next] arm: patch: FUNCTION_GRAPH_TRACER depends on CPU_ENDIAN_BE8 or !CPU_ENDIAN_BE32
@ 2021-04-06 10:23 Zhang Jianhua
2021-04-06 13:06 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Jianhua @ 2021-04-06 10:23 UTC (permalink / raw)
To: rostedt, mingo, zhangjianhua18; +Cc: linux-kernel, johnny.chenyi, heying24
If CONFIG_FUNCTION_GRAPH_TRACER=y, the following errors will be seen
while compiling patch.c
arch/arm/kernel/patch.c: In function ‘__patch_text_real’:
arch/arm/kernel/patch.c:94:11: error: implicit declaration of function
‘__opcode_to_mem_thumb32’; did you mean ‘__opcode_to_mem_thumb16’?
[-Werror=implicit-function-declaration]
insn = __opcode_to_mem_thumb32(insn);
^~~~~~~~~~~~~~~~~~~~~~~
__opcode_to_mem_thumb16
Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
---
kernel/trace/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 7fa82778c3e6..fbf5fd80f105 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -177,6 +177,7 @@ config FUNCTION_GRAPH_TRACER
depends on HAVE_FUNCTION_GRAPH_TRACER
depends on FUNCTION_TRACER
depends on !X86_32 || !CC_OPTIMIZE_FOR_SIZE
+ depends on CPU_ENDIAN_BE8 || !CPU_ENDIAN_BE32
default y
help
Enable the kernel to trace a function at both its return
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] arm: patch: FUNCTION_GRAPH_TRACER depends on CPU_ENDIAN_BE8 or !CPU_ENDIAN_BE32
2021-04-06 10:23 [PATCH -next] arm: patch: FUNCTION_GRAPH_TRACER depends on CPU_ENDIAN_BE8 or !CPU_ENDIAN_BE32 Zhang Jianhua
@ 2021-04-06 13:06 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2021-04-06 13:06 UTC (permalink / raw)
To: Zhang Jianhua; +Cc: mingo, linux-kernel, johnny.chenyi, heying24
On Tue, 6 Apr 2021 18:23:51 +0800
Zhang Jianhua <zhangjianhua18@huawei.com> wrote:
> If CONFIG_FUNCTION_GRAPH_TRACER=y, the following errors will be seen
> while compiling patch.c
>
> arch/arm/kernel/patch.c: In function ‘__patch_text_real’:
> arch/arm/kernel/patch.c:94:11: error: implicit declaration of function
> ‘__opcode_to_mem_thumb32’; did you mean ‘__opcode_to_mem_thumb16’?
> [-Werror=implicit-function-declaration]
> insn = __opcode_to_mem_thumb32(insn);
> ^~~~~~~~~~~~~~~~~~~~~~~
> __opcode_to_mem_thumb16
>
> Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 7fa82778c3e6..fbf5fd80f105 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -177,6 +177,7 @@ config FUNCTION_GRAPH_TRACER
> depends on HAVE_FUNCTION_GRAPH_TRACER
> depends on FUNCTION_TRACER
> depends on !X86_32 || !CC_OPTIMIZE_FOR_SIZE
> + depends on CPU_ENDIAN_BE8 || !CPU_ENDIAN_BE32
Doesn't this break 32 bit big endian powerpc?
Not to mention, my config doesn't have either of those.
NACK
-- Steve
> default y
> help
> Enable the kernel to trace a function at both its return
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-06 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 10:23 [PATCH -next] arm: patch: FUNCTION_GRAPH_TRACER depends on CPU_ENDIAN_BE8 or !CPU_ENDIAN_BE32 Zhang Jianhua
2021-04-06 13:06 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.