From: Mark Brown <broonie@kernel.org>
To: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com,
catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable
Date: Tue, 6 Apr 2021 12:02:57 +0100 [thread overview]
Message-ID: <20210406110257.GA6443@sirena.org.uk> (raw)
In-Reply-To: <9ebc341b-ba5a-db9a-c5e6-17b30d4b1fd4@linux.microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Thu, Apr 01, 2021 at 02:47:11PM -0500, Madhavan T. Venkataraman wrote:
> On 4/1/21 1:53 PM, Madhavan T. Venkataraman wrote:
> > Alternatively, I could just move the SYM_INNER_LABEL(ftrace_graph_call..) to outside the ifdef.
> Or, even better, I could just use ftrace_call+4 because that would be the return
> address for the tracer function at ftrace_call:
> I think that would be cleaner. And, I don't need the complicated comments for ftrace_graph_call.
> Is this acceptable?
I think either of those should be fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>
Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com,
catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable
Date: Tue, 6 Apr 2021 12:02:57 +0100 [thread overview]
Message-ID: <20210406110257.GA6443@sirena.org.uk> (raw)
In-Reply-To: <9ebc341b-ba5a-db9a-c5e6-17b30d4b1fd4@linux.microsoft.com>
[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]
On Thu, Apr 01, 2021 at 02:47:11PM -0500, Madhavan T. Venkataraman wrote:
> On 4/1/21 1:53 PM, Madhavan T. Venkataraman wrote:
> > Alternatively, I could just move the SYM_INNER_LABEL(ftrace_graph_call..) to outside the ifdef.
> Or, even better, I could just use ftrace_call+4 because that would be the return
> address for the tracer function at ftrace_call:
> I think that would be cleaner. And, I don't need the complicated comments for ftrace_graph_call.
> Is this acceptable?
I think either of those should be fine.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-06 11:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <77bd5edeea72d44533c769b1e8c0fea7a9d7eb3a>
2021-03-30 19:09 ` [RFC PATCH v1 0/4] arm64: Implement stack trace reliability checks madvenka
2021-03-30 19:09 ` madvenka
2021-03-30 19:09 ` [RFC PATCH v1 1/4] arm64: Implement infrastructure for " madvenka
2021-03-30 19:09 ` madvenka
2021-04-01 15:27 ` Mark Brown
2021-04-01 15:27 ` Mark Brown
2021-04-01 17:44 ` Madhavan T. Venkataraman
2021-04-01 17:44 ` Madhavan T. Venkataraman
2021-03-30 19:09 ` [RFC PATCH v1 2/4] arm64: Mark a stack trace unreliable if an EL1 exception frame is detected madvenka
2021-03-30 19:09 ` madvenka
2021-04-01 17:21 ` Mark Brown
2021-04-01 17:21 ` Mark Brown
2021-03-30 19:09 ` [RFC PATCH v1 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable madvenka
2021-03-30 19:09 ` madvenka
2021-04-01 14:27 ` Mark Brown
2021-04-01 14:27 ` Mark Brown
2021-04-01 17:43 ` Madhavan T. Venkataraman
2021-04-01 17:43 ` Madhavan T. Venkataraman
2021-04-01 18:28 ` Mark Brown
2021-04-01 18:28 ` Mark Brown
2021-04-01 18:40 ` Madhavan T. Venkataraman
2021-04-01 18:40 ` Madhavan T. Venkataraman
2021-04-01 18:53 ` Madhavan T. Venkataraman
2021-04-01 18:53 ` Madhavan T. Venkataraman
2021-04-01 19:47 ` Madhavan T. Venkataraman
2021-04-01 19:47 ` Madhavan T. Venkataraman
2021-04-06 11:02 ` Mark Brown [this message]
2021-04-06 11:02 ` Mark Brown
2021-04-01 17:48 ` Madhavan T. Venkataraman
2021-04-01 17:48 ` Madhavan T. Venkataraman
2021-03-30 19:09 ` [RFC PATCH v1 4/4] arm64: Mark stack trace as unreliable if kretprobed functions are present madvenka
2021-03-30 19:09 ` madvenka
2021-04-01 17:23 ` Mark Brown
2021-04-01 17:23 ` Mark Brown
2021-04-03 17:01 ` [RFC PATCH v1 0/4] arm64: Implement stack trace reliability checks Josh Poimboeuf
2021-04-03 17:01 ` Josh Poimboeuf
2021-04-04 3:29 ` Madhavan T. Venkataraman
2021-04-04 3:29 ` Madhavan T. Venkataraman
2021-04-05 13:24 ` Masami Hiramatsu
2021-04-05 13:24 ` Masami Hiramatsu
2021-04-05 13:46 ` Madhavan T. Venkataraman
2021-04-05 13:46 ` Madhavan T. Venkataraman
2021-04-05 14:56 ` Madhavan T. Venkataraman
2021-04-05 14:56 ` Madhavan T. Venkataraman
2021-04-05 17:12 ` Madhavan T. Venkataraman
2021-04-05 17:12 ` Madhavan T. Venkataraman
2021-04-05 23:39 ` Masami Hiramatsu
2021-04-05 23:39 ` Masami Hiramatsu
2021-04-05 23:40 ` Masami Hiramatsu
2021-04-05 23:40 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406110257.GA6443@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.