* [PATCH resend] mmc: kconfig: Add CONFIG_SPL_MMC_VERBOSE
@ 2021-04-06 13:52 ` Klaus Heinrich Kiwi
2021-04-06 22:17 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Klaus Heinrich Kiwi @ 2021-04-06 13:52 UTC (permalink / raw)
To: u-boot
When building the SPL with MMC config and CONFIG_LOGLEVEL > 7, the
function mmc_select_mode() at drivers/mmc/mmc.c will call
mmc_mode_name() which is only defined if CONFIG_IS_ENABLED(MMC_VERBOSE)
which doesn't have a corresponding CONFIG_SPL_MMC_VERBOSE defined in
Kconfig.
Fixes this build error:
arm-linux-gnueabi-ld.bfd: drivers/built-in.o: in function
`mmc_select_mode':
/drivers/mmc/mmc.c:192: undefined
reference to `mmc_mode_name'
make[1]: *** [scripts/Makefile.spl:432: spl/u-boot-spl] Error 1
make: *** [Makefile:1942: spl/u-boot-spl] Error 2
Signed-off-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
---
common/spl/Kconfig | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 0711cbf951..5b0eaa1414 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -710,6 +710,13 @@ config SPL_MMC_SUPPORT
this option to build the drivers in drivers/mmc as part of an SPL
build.
+config SPL_MMC_VERBOSE
+ bool "Output mode information about the MMC"
+ depends on SPL_MMC_SUPPORT
+ help
+ Enable the output of more information about the card such as the
+ operating mode.
+
config SYS_MMCSD_FS_BOOT_PARTITION
int "MMC Boot Partition"
default 1
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH resend] mmc: kconfig: Add CONFIG_SPL_MMC_VERBOSE
2021-04-06 13:52 ` [PATCH resend] mmc: kconfig: Add CONFIG_SPL_MMC_VERBOSE Klaus Heinrich Kiwi
@ 2021-04-06 22:17 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2021-04-06 22:17 UTC (permalink / raw)
To: u-boot
On 4/6/21 10:52 PM, Klaus Heinrich Kiwi wrote:
> When building the SPL with MMC config and CONFIG_LOGLEVEL > 7, the
> function mmc_select_mode() at drivers/mmc/mmc.c will call
> mmc_mode_name() which is only defined if CONFIG_IS_ENABLED(MMC_VERBOSE)
> which doesn't have a corresponding CONFIG_SPL_MMC_VERBOSE defined in
> Kconfig.
Sorry, i didn't see your build error.
Best Regards,
Jaehoon Chung
>
> Fixes this build error:
>
> arm-linux-gnueabi-ld.bfd: drivers/built-in.o: in function
> `mmc_select_mode':
>
> /drivers/mmc/mmc.c:192: undefined
> reference to `mmc_mode_name'
> make[1]: *** [scripts/Makefile.spl:432: spl/u-boot-spl] Error 1
> make: *** [Makefile:1942: spl/u-boot-spl] Error 2
>
> Signed-off-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
> ---
> common/spl/Kconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 0711cbf951..5b0eaa1414 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -710,6 +710,13 @@ config SPL_MMC_SUPPORT
> this option to build the drivers in drivers/mmc as part of an SPL
> build.
>
> +config SPL_MMC_VERBOSE
> + bool "Output mode information about the MMC"
> + depends on SPL_MMC_SUPPORT
> + help
> + Enable the output of more information about the card such as the
> + operating mode.
> +
> config SYS_MMCSD_FS_BOOT_PARTITION
> int "MMC Boot Partition"
> default 1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-06 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210406135305epcas1p37884c16acc750fd6da1ecb7e56dd51d6@epcas1p3.samsung.com>
2021-04-06 13:52 ` [PATCH resend] mmc: kconfig: Add CONFIG_SPL_MMC_VERBOSE Klaus Heinrich Kiwi
2021-04-06 22:17 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.