* drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
@ 2021-04-06 10:23 kernel test robot
2021-04-06 10:23 ` [PATCH] regulator: qcom-labibb: fix irqf_oneshot.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-04-06 10:23 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0a50438c84363bd37fe18fe432888ae9a074dcab
commit: 390af53e04114f790d60b63802a4de9d815ade03 regulator: qcom-labibb: Implement short-circuit and over-current IRQs
date: 3 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 3 months ago
config: sh-randconfig-c024-20210406 (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23215 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] regulator: qcom-labibb: fix irqf_oneshot.cocci warnings
2021-04-06 10:23 drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT kernel test robot
@ 2021-04-06 10:23 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-06 10:23 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
CC: Mark Brown <broonie@kernel.org>
CC: Andy Gross <agross@kernel.org>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
CC: Liam Girdwood <lgirdwood@gmail.com>
CC: linux-arm-msm(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Fixes: 390af53e0411 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs")
CC: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0a50438c84363bd37fe18fe432888ae9a074dcab
commit: 390af53e04114f790d60b63802a4de9d815ade03 regulator: qcom-labibb: Implement short-circuit and over-current IRQs
:::::: branch date: 18 hours ago
:::::: commit date: 3 months ago
Please take the patch only if it's a positive warning. Thanks!
qcom-labibb-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/regulator/qcom-labibb-regulator.c
+++ b/drivers/regulator/qcom-labibb-regulator.c
@@ -362,7 +362,8 @@ static int qcom_labibb_set_ocp(struct re
return ret;
return devm_request_threaded_irq(vreg->dev, vreg->ocp_irq, NULL,
- qcom_labibb_ocp_isr, irq_flags,
+ qcom_labibb_ocp_isr,
+ irq_flags | IRQF_ONESHOT,
ocp_irq_name, vreg);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-06 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 10:23 drivers/regulator/qcom-labibb-regulator.c:364:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT kernel test robot
2021-04-06 10:23 ` [PATCH] regulator: qcom-labibb: fix irqf_oneshot.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.