* [PATCH] blk-zoned: Remove the definition of blk_zone_start()
@ 2021-04-06 20:08 Bart Van Assche
2021-04-06 20:21 ` Himanshu Madhani
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Bart Van Assche @ 2021-04-06 20:08 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Bart Van Assche, Damien Le Moal
Commit e76239a3748c ("block: add a report_zones method") removed the last
blk_zone_start() call. Hence also remove the definition of this function.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-zoned.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index c0276b42d9fb..250cb76ee615 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -52,14 +52,6 @@ const char *blk_zone_cond_str(enum blk_zone_cond zone_cond)
}
EXPORT_SYMBOL_GPL(blk_zone_cond_str);
-static inline sector_t blk_zone_start(struct request_queue *q,
- sector_t sector)
-{
- sector_t zone_mask = blk_queue_zone_sectors(q) - 1;
-
- return sector & ~zone_mask;
-}
-
/*
* Return true if a request is a write requests that needs zone write locking.
*/
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()
2021-04-06 20:08 [PATCH] blk-zoned: Remove the definition of blk_zone_start() Bart Van Assche
@ 2021-04-06 20:21 ` Himanshu Madhani
2021-04-06 20:59 ` Chaitanya Kulkarni
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Himanshu Madhani @ 2021-04-06 20:21 UTC (permalink / raw)
To: Bart Van Assche
Cc: Jens Axboe, linux-block, Christoph Hellwig, Damien Le Moal
> On Apr 6, 2021, at 3:08 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> block/blk-zoned.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index c0276b42d9fb..250cb76ee615 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -52,14 +52,6 @@ const char *blk_zone_cond_str(enum blk_zone_cond zone_cond)
> }
> EXPORT_SYMBOL_GPL(blk_zone_cond_str);
>
> -static inline sector_t blk_zone_start(struct request_queue *q,
> - sector_t sector)
> -{
> - sector_t zone_mask = blk_queue_zone_sectors(q) - 1;
> -
> - return sector & ~zone_mask;
> -}
> -
> /*
> * Return true if a request is a write requests that needs zone write locking.
> */
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()
2021-04-06 20:08 [PATCH] blk-zoned: Remove the definition of blk_zone_start() Bart Van Assche
2021-04-06 20:21 ` Himanshu Madhani
@ 2021-04-06 20:59 ` Chaitanya Kulkarni
2021-04-07 5:17 ` Christoph Hellwig
2021-04-07 20:32 ` Jens Axboe
3 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2021-04-06 20:59 UTC (permalink / raw)
To: Bart Van Assche, Jens Axboe
Cc: linux-block, Christoph Hellwig, Damien Le Moal
On 4/6/21 13:08, Bart Van Assche wrote:
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()
2021-04-06 20:08 [PATCH] blk-zoned: Remove the definition of blk_zone_start() Bart Van Assche
2021-04-06 20:21 ` Himanshu Madhani
2021-04-06 20:59 ` Chaitanya Kulkarni
@ 2021-04-07 5:17 ` Christoph Hellwig
2021-04-07 20:32 ` Jens Axboe
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2021-04-07 5:17 UTC (permalink / raw)
To: Bart Van Assche
Cc: Jens Axboe, linux-block, Christoph Hellwig, Damien Le Moal
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()
2021-04-06 20:08 [PATCH] blk-zoned: Remove the definition of blk_zone_start() Bart Van Assche
` (2 preceding siblings ...)
2021-04-07 5:17 ` Christoph Hellwig
@ 2021-04-07 20:32 ` Jens Axboe
3 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2021-04-07 20:32 UTC (permalink / raw)
To: Bart Van Assche; +Cc: linux-block, Christoph Hellwig, Damien Le Moal
On 4/6/21 2:08 PM, Bart Van Assche wrote:
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-07 20:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 20:08 [PATCH] blk-zoned: Remove the definition of blk_zone_start() Bart Van Assche
2021-04-06 20:21 ` Himanshu Madhani
2021-04-06 20:59 ` Chaitanya Kulkarni
2021-04-07 5:17 ` Christoph Hellwig
2021-04-07 20:32 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.