From: Maxime Ripard <maxime@cerno.tech>
To: Ivan Uvarov <i.uvarov@cognitivepilot.com>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Andre Przywara <andre.przywara@arm.com>,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v3 4/4] ARM: dts: sun8i: r40: add devicetree for Forlinx FETA40i-C & OKA40i-C
Date: Wed, 7 Apr 2021 09:30:54 +0200 [thread overview]
Message-ID: <20210407073054.wzus3zmzfksilwcf@gilmour> (raw)
In-Reply-To: <20210401175938.1f6d065c@NervousEnergy>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Thu, Apr 01, 2021 at 05:59:38PM +0300, Ivan Uvarov wrote:
> > > + leds {
> > > + compatible = "gpio-leds";
> > > +
> > > + led-5 {
> > > + gpios = <&pio 7 26 GPIO_ACTIVE_LOW>; /*
> > > PH26 */
> > > + color = <LED_COLOR_ID_GREEN>;
> > > + function = LED_FUNCTION_STATUS;
> > > + };
> > > +
> > > + led-6 {
> > > + gpios = <&pio 8 15 GPIO_ACTIVE_LOW>; /*
> > > PI15 */
> > > + color = <LED_COLOR_ID_BLUE>;
> > > + function = LED_FUNCTION_STATUS;
> > > + };
> >
> > led-5 and led-6? You can start at 0 :)
> >
> > Looks good otherwise, thanks
>
> This is how they are labeled on the board, so I kept the names. Should
> I rename them anyway?
No, it makes sense then, just add a comment to make it obvious :)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Ivan Uvarov <i.uvarov@cognitivepilot.com>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Andre Przywara <andre.przywara@arm.com>,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v3 4/4] ARM: dts: sun8i: r40: add devicetree for Forlinx FETA40i-C & OKA40i-C
Date: Wed, 7 Apr 2021 09:30:54 +0200 [thread overview]
Message-ID: <20210407073054.wzus3zmzfksilwcf@gilmour> (raw)
In-Reply-To: <20210401175938.1f6d065c@NervousEnergy>
[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]
On Thu, Apr 01, 2021 at 05:59:38PM +0300, Ivan Uvarov wrote:
> > > + leds {
> > > + compatible = "gpio-leds";
> > > +
> > > + led-5 {
> > > + gpios = <&pio 7 26 GPIO_ACTIVE_LOW>; /*
> > > PH26 */
> > > + color = <LED_COLOR_ID_GREEN>;
> > > + function = LED_FUNCTION_STATUS;
> > > + };
> > > +
> > > + led-6 {
> > > + gpios = <&pio 8 15 GPIO_ACTIVE_LOW>; /*
> > > PI15 */
> > > + color = <LED_COLOR_ID_BLUE>;
> > > + function = LED_FUNCTION_STATUS;
> > > + };
> >
> > led-5 and led-6? You can start at 0 :)
> >
> > Looks good otherwise, thanks
>
> This is how they are labeled on the board, so I kept the names. Should
> I rename them anyway?
No, it makes sense then, just add a comment to make it obvious :)
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-07 7:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 15:56 [PATCH v3 0/4] add devicetree for Forlinx FETA40i-C & OKA40i-C Ivan Uvarov
2021-03-31 15:56 ` Ivan Uvarov
2021-03-31 15:56 ` [PATCH v3 1/4] ARM: dts: sun8i: r40: add /omit-if-no-ref/ to pinmux nodes for UARTs 0&3 Ivan Uvarov
2021-03-31 15:56 ` Ivan Uvarov
2021-03-31 15:56 ` [PATCH v3 2/4] ARM: dts: sun8i: r40: add pinmux settings for MMC3 and UARTs 2,4,5&7 Ivan Uvarov
2021-03-31 15:56 ` [PATCH v3 2/4] ARM: dts: sun8i: r40: add pinmux settings for MMC3 and UARTs 2, 4, 5&7 Ivan Uvarov
2021-04-01 9:39 ` [PATCH v3 2/4] ARM: dts: sun8i: r40: add pinmux settings for MMC3 and UARTs 2,4,5&7 Maxime Ripard
2021-04-01 9:39 ` Maxime Ripard
2021-03-31 15:56 ` [PATCH v3 3/4] dt-bindings: arm: add compatible strings for Forlinx OKA40i-C Ivan Uvarov
2021-03-31 15:56 ` Ivan Uvarov
2021-04-01 9:40 ` Maxime Ripard
2021-04-01 9:40 ` Maxime Ripard
2021-04-01 14:55 ` Ivan Uvarov
2021-04-01 14:55 ` Ivan Uvarov
2021-04-07 7:23 ` Maxime Ripard
2021-04-07 7:23 ` Maxime Ripard
2021-04-01 16:59 ` Rob Herring
2021-04-01 16:59 ` Rob Herring
2021-03-31 15:56 ` [PATCH v3 4/4] ARM: dts: sun8i: r40: add devicetree for Forlinx FETA40i-C & OKA40i-C Ivan Uvarov
2021-03-31 15:56 ` Ivan Uvarov
2021-04-01 9:43 ` Maxime Ripard
2021-04-01 9:43 ` Maxime Ripard
2021-04-01 14:59 ` Ivan Uvarov
2021-04-01 14:59 ` Ivan Uvarov
2021-04-07 7:30 ` Maxime Ripard [this message]
2021-04-07 7:30 ` Maxime Ripard
2021-04-01 14:02 ` Andre Przywara
2021-04-01 14:02 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407073054.wzus3zmzfksilwcf@gilmour \
--to=maxime@cerno.tech \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=i.uvarov@cognitivepilot.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.