From: Nishanth Menon <nm@ti.com>
To: Aswath Govindraju <a-govindraju@ti.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Add support for UHS-I modes in MMCSD1 subsystem
Date: Wed, 7 Apr 2021 09:59:37 -0500 [thread overview]
Message-ID: <20210407145937.prvue66guhdls2fw@immovably> (raw)
In-Reply-To: <20210407104303.25950-1-a-govindraju@ti.com>
On 16:13-20210407, Aswath Govindraju wrote:
> UHS-I speed modes are supported in AM65 S.R. 2.0 SoC[1].
>
> Add support by removing the no-1-8-v tag and including the voltage
> regulator device tree nodes for power cycling.
>
> [1] - https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf, section 12.3.6.1.1
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>
> test logs:
> https://pastebin.ubuntu.com/p/vpYbY9QWh8/
>
Thanks, but I dont plan on queuing this for 5.13-rc1 (my PR is already
out). but it does trigger an interesting discussion..
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 33 +++++++++++++++++++
> 2 files changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index cb340d1b401f..632f32fce4a1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -301,7 +301,6 @@
> ti,otap-del-sel = <0x2>;
> ti,trm-icp = <0x8>;
> dma-coherent;
> - no-1-8-v;
> };
>
Jan - this will break your IOT SR1.0 boards, no? with all the SR1.0,
2.0, 2.1 coming along, the plan for TI was to support older revs via
overlays hoping that older boards will eventually get replaced or die
out of lack of use.. but you do have production on 1.0 -> so would you
rather handle this in overlay OR IOT boards dts introduce no-1-8-v
property?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Aswath Govindraju <a-govindraju@ti.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Add support for UHS-I modes in MMCSD1 subsystem
Date: Wed, 7 Apr 2021 09:59:37 -0500 [thread overview]
Message-ID: <20210407145937.prvue66guhdls2fw@immovably> (raw)
In-Reply-To: <20210407104303.25950-1-a-govindraju@ti.com>
On 16:13-20210407, Aswath Govindraju wrote:
> UHS-I speed modes are supported in AM65 S.R. 2.0 SoC[1].
>
> Add support by removing the no-1-8-v tag and including the voltage
> regulator device tree nodes for power cycling.
>
> [1] - https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf, section 12.3.6.1.1
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>
> test logs:
> https://pastebin.ubuntu.com/p/vpYbY9QWh8/
>
Thanks, but I dont plan on queuing this for 5.13-rc1 (my PR is already
out). but it does trigger an interesting discussion..
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 33 +++++++++++++++++++
> 2 files changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index cb340d1b401f..632f32fce4a1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -301,7 +301,6 @@
> ti,otap-del-sel = <0x2>;
> ti,trm-icp = <0x8>;
> dma-coherent;
> - no-1-8-v;
> };
>
Jan - this will break your IOT SR1.0 boards, no? with all the SR1.0,
2.0, 2.1 coming along, the plan for TI was to support older revs via
overlays hoping that older boards will eventually get replaced or die
out of lack of use.. but you do have production on 1.0 -> so would you
rather handle this in overlay OR IOT boards dts introduce no-1-8-v
property?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-07 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:43 [PATCH] arm64: dts: ti: k3-am65: Add support for UHS-I modes in MMCSD1 subsystem Aswath Govindraju
2021-04-07 10:43 ` Aswath Govindraju
2021-04-07 14:59 ` Nishanth Menon [this message]
2021-04-07 14:59 ` Nishanth Menon
2021-04-07 15:13 ` Jan Kiszka
2021-04-07 15:13 ` Jan Kiszka
2021-04-07 15:30 ` Nishanth Menon
2021-04-07 15:30 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407145937.prvue66guhdls2fw@immovably \
--to=nm@ti.com \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kishon@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.