* [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7
@ 2021-04-07 18:27 Julien Grall
2021-04-08 6:17 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2021-04-07 18:27 UTC (permalink / raw)
To: xen-devel
Cc: julien, Julien Grall, Andrew Cooper, George Dunlap, Ian Jackson,
Jan Beulich, Stefano Stabellini, Wei Liu
From: Julien Grall <jgrall@amazon.com>
The compilation will fail when building Xen with clang and
CONFIG_DEBUG=y:
make[4]: Leaving directory '/oss/xen/xen/common/libelf'
INIT_O gunzip.init.o
Error: size of gunzip.o:.text is 0x00000019
This is because the function init_allocator() will not be inlined
and is not part of the init section.
Fix it by marking init_allocator() with INIT.
Fixes: 33bc2a8495f7 ("xen/gunzip: Allow perform_gunzip() to be called multiple times")
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/common/inflate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/inflate.c b/xen/common/inflate.c
index d8c28a3e9593..c593b94d481e 100644
--- a/xen/common/inflate.c
+++ b/xen/common/inflate.c
@@ -238,7 +238,7 @@ STATIC const ush mask_bits[] = {
static unsigned long INITDATA malloc_ptr;
static int INITDATA malloc_count;
-static void init_allocator(void)
+static void INIT init_allocator(void)
{
malloc_ptr = free_mem_ptr;
malloc_count = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7
2021-04-07 18:27 [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7 Julien Grall
@ 2021-04-08 6:17 ` Jan Beulich
2021-04-09 8:43 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2021-04-08 6:17 UTC (permalink / raw)
To: Julien Grall
Cc: Julien Grall, Andrew Cooper, George Dunlap, Ian Jackson,
Stefano Stabellini, Wei Liu, xen-devel
On 07.04.2021 20:27, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The compilation will fail when building Xen with clang and
> CONFIG_DEBUG=y:
>
> make[4]: Leaving directory '/oss/xen/xen/common/libelf'
> INIT_O gunzip.init.o
> Error: size of gunzip.o:.text is 0x00000019
>
> This is because the function init_allocator() will not be inlined
> and is not part of the init section.
>
> Fix it by marking init_allocator() with INIT.
>
> Fixes: 33bc2a8495f7 ("xen/gunzip: Allow perform_gunzip() to be called multiple times")
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7
2021-04-08 6:17 ` Jan Beulich
@ 2021-04-09 8:43 ` Julien Grall
0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2021-04-09 8:43 UTC (permalink / raw)
To: Jan Beulich
Cc: Julien Grall, Andrew Cooper, George Dunlap, Ian Jackson,
Stefano Stabellini, Wei Liu, xen-devel
Hi Jan,
On 08/04/2021 07:17, Jan Beulich wrote:
> On 07.04.2021 20:27, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The compilation will fail when building Xen with clang and
>> CONFIG_DEBUG=y:
>>
>> make[4]: Leaving directory '/oss/xen/xen/common/libelf'
>> INIT_O gunzip.init.o
>> Error: size of gunzip.o:.text is 0x00000019
>>
>> This is because the function init_allocator() will not be inlined
>> and is not part of the init section.
>>
>> Fix it by marking init_allocator() with INIT.
>>
>> Fixes: 33bc2a8495f7 ("xen/gunzip: Allow perform_gunzip() to be called multiple times")
>> Reported-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks! I have committed the patch.
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-09 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 18:27 [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7 Julien Grall
2021-04-08 6:17 ` Jan Beulich
2021-04-09 8:43 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.